select:false makes the schema basically ignored and not effective, which is clearly not what we want for a device binding.
Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
---
Cc: Shubhrajyoti Datta shubhrajyoti.datta@amd.com --- Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 2 -- 1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml index e9cf747bf89b..04ea327d5313 100644 --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml @@ -14,8 +14,6 @@ description: | reads required input clock frequencies from the devicetree and acts as clock provider for all clock consumers of PS clocks.
-select: false - properties: compatible: oneOf:
On Fri, Jul 28, 2023 at 06:59:23PM +0200, Krzysztof Kozlowski wrote:
select:false makes the schema basically ignored and not effective, which is clearly not what we want for a device binding.
Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Thanks for spotting it! Validation of the other patch seems to function as intended with this applied.
Reviewed-by: Conor Dooley conor.dooley@microchip.com
Thanks, Conor.
Cc: Shubhrajyoti Datta shubhrajyoti.datta@amd.com
Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 2 -- 1 file changed, 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml index e9cf747bf89b..04ea327d5313 100644 --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml @@ -14,8 +14,6 @@ description: | reads required input clock frequencies from the devicetree and acts as clock provider for all clock consumers of PS clocks. -select: false
properties: compatible: oneOf: -- 2.34.1
[AMD Official Use Only - General]
-----Original Message----- From: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org Sent: Friday, July 28, 2023 10:29 PM To: Michael Turquette mturquette@baylibre.com; Stephen Boyd sboyd@kernel.org; Rob Herring robh+dt@kernel.org; Krzysztof Kozlowski krzysztof.kozlowski+dt@linaro.org; Conor Dooley conor+dt@kernel.org; Simek, Michal michal.simek@amd.com; Rajan Vaja rajan.vaja@xilinx.com; linux-clk@vger.kernel.org; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org; stable@vger.kernel.org; Datta, Shubhrajyoti shubhrajyoti.datta@amd.com Subject: [PATCH] dt-bindings: clock: xlnx,versal-clk: drop select:false
Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
select:false makes the schema basically ignored and not effective, which is clearly not what we want for a device binding.
Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Reviewed-by: Shubhrajyoti Datta shubhrajyoti.datta@amd.com
Quoting Krzysztof Kozlowski (2023-07-28 09:59:23)
select:false makes the schema basically ignored and not effective, which is clearly not what we want for a device binding.
Fixes: 352546805a44 ("dt-bindings: clock: Add bindings for versal clock driver") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@linaro.org
Applied to clk-next
linux-stable-mirror@lists.linaro.org
-
Conor Dooley -
Datta, Shubhrajyoti -
Krzysztof Kozlowski -
Stephen Boyd