Re: [REGRESSION] "ALSA: HDA: Early Forbid of runtime PM" broke my laptop's internal audio
On Fri, 29 Jan 2021 17:12:08 +0100, Michael Catanzaro wrote:
On Fri, Jan 29, 2021 at 9:30 am, Michael Catanzaro mcatanzaro@redhat.com wrote:
OK, I found "ALSA: hda/via: Apply the workaround generically for Clevo machines" which was just merged yesterday. So I will test again to find out.
Hi Takashi, hi Harsha,
I can confirm that the problem is fixed by this commit:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
Thanks, good to hear.
Then I think we can drop the entry from power_save_denylist in hda_intel.c. Could you try that it still works with the patch below?
thanks,
Takashi
--- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = { /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ - SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0), - /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ /* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA dev */
On Fri, Jan 29, 2021 at 5:17 pm, Takashi Iwai tiwai@suse.de wrote:
--- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = { /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
- SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
- /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ /* Note the P55A-UD3 and Z87-D3HP share the subsys id for the HDA
dev */
Hi,
This patch works fine on my laptop. I have no clue whether that means it's really safe to remove the quirk. I've never noticed any clicking noise myself, but I understand it has been a problem for other System76 laptops.
Michael
On Fri, 29 Jan 2021 18:24:16 +0100, Michael Catanzaro wrote:
On Fri, Jan 29, 2021 at 5:17 pm, Takashi Iwai tiwai@suse.de wrote:
--- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2217,8 +2217,6 @@ static const struct snd_pci_quirk power_save_denylist[] = { /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1043, 0x8733, "Asus Prime X370-Pro", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */
- SND_PCI_QUIRK(0x1558, 0x6504, "Clevo W65_67SB", 0),
- /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ SND_PCI_QUIRK(0x1028, 0x0497, "Dell Precision T3600", 0), /* https://bugzilla.redhat.com/show_bug.cgi?id=1525104 */ /* Note the P55A-UD3 and Z87-D3HP share the subsys id for the
HDA dev */
Hi,
This patch works fine on my laptop. I have no clue whether that means it's really safe to remove the quirk. I've never noticed any clicking noise myself, but I understand it has been a problem for other System76 laptops.
If you find no noticeable problem, that's fine, and I believe we can drop from the deny list. But it's no urgent issue and fit well as a 5.12 material. Will submit a proper patch later.
thanks,
Takashi
I am not sure if I should join this old thread, but it seems that I saw the same issue on my ASUS B23E laptop. It couldn't produce any sound after upgrading to Linux 5.10, and 'git bisect' shows it was broken by the same commit a0645daf16101bb9a6d87598c17e9a8b7bd60ea7.
I have tested the latest master branch (v5.14-rc4-322-gcceb634774ef) last week. It still had no sound. If I reverted the broken commit, sound worked.
alsa-info from the broken kernel: https://gist.github.com/lantw44/0660e059c488e3ff3d841bb03b371866
alsa-info from the working kernel: https://gist.github.com/lantw44/9367f425e4f5ba98cf12343cb90f3301
lspci: 00:00.0 Host bridge: Intel Corporation 2nd Generation Core Processor Family DRAM Controller (rev 09) 00:02.0 VGA compatible controller: Intel Corporation 2nd Generation Core Processor Family Integrated Graphics Controller (rev 09) 00:16.0 Communication controller: Intel Corporation 6 Series/C200 Series Chipset Family MEI Controller #1 (rev 04) 00:16.3 Serial controller: Intel Corporation 6 Series/C200 Series Chipset Family KT Controller (rev 04) 00:19.0 Ethernet controller: Intel Corporation 82579LM Gigabit Network Connection (Lewisville) (rev 05) 00:1a.0 USB controller: Intel Corporation 6 Series/C200 Series Chipset Family USB Enhanced Host Controller #2 (rev 05) 00:1b.0 Audio device: Intel Corporation 6 Series/C200 Series Chipset Family High Definition Audio Controller (rev 05) 00:1c.0 PCI bridge: Intel Corporation 6 Series/C200 Series Chipset Family PCI Express Root Port 1 (rev b5) 00:1c.1 PCI bridge: Intel Corporation 6 Series/C200 Series Chipset Family PCI Express Root Port 2 (rev b5) 00:1c.2 PCI bridge: Intel Corporation 6 Series/C200 Series Chipset Family PCI Express Root Port 3 (rev b5) 00:1c.3 PCI bridge: Intel Corporation 6 Series/C200 Series Chipset Family PCI Express Root Port 4 (rev b5) 00:1d.0 USB controller: Intel Corporation 6 Series/C200 Series Chipset Family USB Enhanced Host Controller #1 (rev 05) 00:1f.0 ISA bridge: Intel Corporation QM67 Express Chipset LPC Controller (rev 05) 00:1f.2 SATA controller: Intel Corporation 6 Series/C200 Series Chipset Family 6 port Mobile SATA AHCI Controller (rev 05) 00:1f.3 SMBus: Intel Corporation 6 Series/C200 Series Chipset Family SMBus Controller (rev 05) 02:00.0 Network controller: Intel Corporation Centrino Advanced-N 6230 [Rainbow Peak] (rev 34) 06:00.0 USB controller: Fresco Logic FL1000G USB 3.0 Host Controller (rev 04)
On Sat, 14 Aug 2021 16:02:36 +0200, 藍挺瑋 wrote:
I am not sure if I should join this old thread, but it seems that I saw the same issue on my ASUS B23E laptop. It couldn't produce any sound after upgrading to Linux 5.10, and 'git bisect' shows it was broken by the same commit a0645daf16101bb9a6d87598c17e9a8b7bd60ea7.
I have tested the latest master branch (v5.14-rc4-322-gcceb634774ef) last week. It still had no sound. If I reverted the broken commit, sound worked.
alsa-info from the broken kernel: https://gist.github.com/lantw44/0660e059c488e3ff3d841bb03b371866
alsa-info from the working kernel: https://gist.github.com/lantw44/9367f425e4f5ba98cf12343cb90f3301
Thanks for the report. A quick workaround be a patch like below. Could you verify whether it fixes the problem?
Takashi
--- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c @@ -1041,6 +1041,7 @@ static const struct hda_fixup via_fixups[] = { };
static const struct snd_pci_quirk vt2002p_fixups[] = { + SND_PCI_QUIRK(0x1043, 0x13f7, "Asus B23E", VIA_FIXUP_POWER_SAVE), SND_PCI_QUIRK(0x1043, 0x1487, "Asus G75", VIA_FIXUP_ASUS_G75), SND_PCI_QUIRK(0x1043, 0x8532, "Asus X202E", VIA_FIXUP_INTMIC_BOOST), SND_PCI_QUIRK_VENDOR(0x1558, "Clevo", VIA_FIXUP_POWER_SAVE),
於 星期日，2021-08-15 於 11:20 +0200，Takashi Iwai 提到：
On Sat, 14 Aug 2021 16:02:36 +0200, 藍挺瑋 wrote:
I am not sure if I should join this old thread, but it seems that I saw the same issue on my ASUS B23E laptop. It couldn't produce any sound after upgrading to Linux 5.10, and 'git bisect' shows it was broken by the same commit a0645daf16101bb9a6d87598c17e9a8b7bd60ea7.
I have tested the latest master branch (v5.14-rc4-322-gcceb634774ef) last week. It still had no sound. If I reverted the broken commit, sound worked.
alsa-info from the broken kernel: https://gist.github.com/lantw44/0660e059c488e3ff3d841bb03b371866
alsa-info from the working kernel: https://gist.github.com/lantw44/9367f425e4f5ba98cf12343cb90f3301
Thanks for the report. A quick workaround be a patch like below. Could you verify whether it fixes the problem?
Yes, it fixes the problem.
Takashi
--- a/sound/pci/hda/patch_via.c +++ b/sound/pci/hda/patch_via.c @@ -1041,6 +1041,7 @@ static const struct hda_fixup via_fixups[] = { }; static const struct snd_pci_quirk vt2002p_fixups[] = { + SND_PCI_QUIRK(0x1043, 0x13f7, "Asus B23E", VIA_FIXUP_POWER_SAVE), SND_PCI_QUIRK(0x1043, 0x1487, "Asus G75", VIA_FIXUP_ASUS_G75), SND_PCI_QUIRK(0x1043, 0x8532, "Asus X202E", VIA_FIXUP_INTMIC_BOOST), SND_PCI_QUIRK_VENDOR(0x1558, "Clevo", VIA_FIXUP_POWER_SAVE),
On Mon, 16 Aug 2021 18:57:03 +0200, 藍挺瑋 wrote:
於 星期日，2021-08-15 於 11:20 +0200，Takashi Iwai 提到：
On Sat, 14 Aug 2021 16:02:36 +0200, 藍挺瑋 wrote:
I am not sure if I should join this old thread, but it seems that I saw the same issue on my ASUS B23E laptop. It couldn't produce any sound after upgrading to Linux 5.10, and 'git bisect' shows it was broken by the same commit a0645daf16101bb9a6d87598c17e9a8b7bd60ea7.
I have tested the latest master branch (v5.14-rc4-322-gcceb634774ef) last week. It still had no sound. If I reverted the broken commit, sound worked.
alsa-info from the broken kernel: https://gist.github.com/lantw44/0660e059c488e3ff3d841bb03b371866
alsa-info from the working kernel: https://gist.github.com/lantw44/9367f425e4f5ba98cf12343cb90f3301
Thanks for the report. A quick workaround be a patch like below. Could you verify whether it fixes the problem?
Yes, it fixes the problem.
Thanks. Now I submitted a final patch and will merge it for 5.14-rc7 pull request.
Takashi
linux-stable-mirror@lists.linaro.org
-
Michael Catanzaro -
Takashi Iwai -
藍挺瑋