If uart_get_rs485() fails, the driver returns without detaching the PM domain list.
Fix the error handling path in uart_get_rs485_mode() to ensure the PM domain list is detached before exiting.
Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms") Cc: stable@vger.kernel.org Signed-off-by: Anup Kulkarni anup.kulkarni@oss.qualcomm.com --- drivers/tty/serial/qcom_geni_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 9c7b1cea7cfe..0fc0f215b85c 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -1928,7 +1928,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
ret = uart_get_rs485_mode(uport); if (ret) - return ret; + goto error;
devm_pm_runtime_enable(port->se.dev);
On 16/09/2025 10:39, Anup Kulkarni wrote:
If uart_get_rs485() fails, the driver returns without detaching the PM domain list.
Fix the error handling path in uart_get_rs485_mode() to ensure the PM domain list is detached before exiting.
Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms") Cc: stable@vger.kernel.org Signed-off-by: Anup Kulkarni anup.kulkarni@oss.qualcomm.com
drivers/tty/serial/qcom_geni_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c index 9c7b1cea7cfe..0fc0f215b85c 100644 --- a/drivers/tty/serial/qcom_geni_serial.c +++ b/drivers/tty/serial/qcom_geni_serial.c @@ -1928,7 +1928,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev) ret = uart_get_rs485_mode(uport); if (ret)
return ret;
goto error;devm_pm_runtime_enable(port->se.dev);
Reviewed-by: Bryan O'Donoghue bryan.odonoghue@linaro.org
On Tue, Sep 16, 2025 at 03:09:57PM +0530, Anup Kulkarni wrote:
If uart_get_rs485() fails, the driver returns without detaching the PM domain list.
Fix the error handling path in uart_get_rs485_mode() to ensure the PM domain list is detached before exiting.
Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms") Cc: stable@vger.kernel.org Signed-off-by: Anup Kulkarni anup.kulkarni@oss.qualcomm.com
drivers/tty/serial/qcom_geni_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I've taken https://lore.kernel.org/r/20250917010437.129912-2-krzysztof.kozlowski@linaro... instead, so this shouldn't be needed anymore.
thanks,
greg k-h
On Wed, Sep 17, 2025 at 4:45 PM Greg KH gregkh@linuxfoundation.org wrote:
On Tue, Sep 16, 2025 at 03:09:57PM +0530, Anup Kulkarni wrote:
If uart_get_rs485() fails, the driver returns without detaching the PM domain list.
Fix the error handling path in uart_get_rs485_mode() to ensure the PM domain list is detached before exiting.
Fixes: 86fa39dd6fb7 ("serial: qcom-geni: Enable Serial on SA8255p Qualcomm platforms") Cc: stable@vger.kernel.org Signed-off-by: Anup Kulkarni anup.kulkarni@oss.qualcomm.com
drivers/tty/serial/qcom_geni_serial.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
I've taken https://lore.kernel.org/r/20250917010437.129912-2-krzysztof.kozlowski@linaro... instead, so this shouldn't be needed anymore.
Agree. It's not required now.
thanks,
greg k-h
thanks,
Anup
linux-stable-mirror@lists.linaro.org
-
Anup Kulkarni -
Bryan O'Donoghue -
Greg KH