On Tue, 2024-08-13 at 08:25 -0700, Darrick J. Wong wrote:
On Tue, Aug 13, 2024 at 04:59:25PM +0200, Christoph Hellwig wrote:
On Tue, Aug 13, 2024 at 07:19:28PM +1000, Dave Chinner wrote:
In hindsight, this was a wholly avoidable bug - a single patch made two different API modifications that only differed by a single letter, and one of the 23 conversions missed a single letter. If that was two patches - one for the finobt conversion, the second for the inobt conversion, the bug would have been plainly obvious during review....
Maybe we should avoid identifiers that close anyway :)
The change looks good:
Reviewed-by: Christoph Hellwig hch@lst.de
Looks good to me too Reviewed-by: Darrick J. Wong djwong@kernel.org
Is it (now commit 95179935bea) going to -stable too?
On Wed, Sep 04, 2024 at 08:45:14AM +0100, David Woodhouse wrote:
On Tue, 2024-08-13 at 08:25 -0700, Darrick J. Wong wrote:
On Tue, Aug 13, 2024 at 04:59:25PM +0200, Christoph Hellwig wrote:
On Tue, Aug 13, 2024 at 07:19:28PM +1000, Dave Chinner wrote:
In hindsight, this was a wholly avoidable bug - a single patch made two different API modifications that only differed by a single letter, and one of the 23 conversions missed a single letter. If that was two patches - one for the finobt conversion, the second for the inobt conversion, the bug would have been plainly obvious during review....
Maybe we should avoid identifiers that close anyway :)
The change looks good:
Reviewed-by: Christoph Hellwig hch@lst.de
Looks good to me too Reviewed-by: Darrick J. Wong djwong@kernel.org
Is it (now commit 95179935bea) going to -stable too?
It's in the 6.10.y queue now, thanks!
greg k-h
linux-stable-mirror@lists.linaro.org
-
David Woodhouse -
Greg KH