On Thu, Aug 24, 2023 at 01:22:03PM +0800, Ming Lei wrote:

commit 9c7c4bc986932218fd0df9d2a100509772028fb1 upstream

sizeof(struct ublksrv_io_cmd) is 16bytes, which can be held in 64byte SQE, so not necessary to check IO_URING_F_SQE128.

With this change, we get chance to save half SQ ring memory.

Fixed: 71f28f3136af ("ublk_drv: add io_uring based userspace block driver") Signed-off-by: Ming Lei ming.lei@redhat.com Link: https://lore.kernel.org/r/20230220041413.1524335-1-ming.lei@redhat.com Signed-off-by: Jens Axboe axboe@kernel.dk

---

drivers/block/ublk_drv.c | 3 --- 1 file changed, 3 deletions(-)

diff --git a/drivers/block/ublk_drv.c b/drivers/block/ublk_drv.c index f48d213fb65e..09d29fa53939 100644 --- a/drivers/block/ublk_drv.c +++ b/drivers/block/ublk_drv.c @@ -1271,9 +1271,6 @@ static int ublk_ch_uring_cmd(struct io_uring_cmd *cmd, unsigned int issue_flags) __func__, cmd->cmd_op, ub_cmd->q_id, tag, ub_cmd->result);

• if (!(issue_flags & IO_URING_F_SQE128))

• goto out;
  

• if (ub_cmd->q_id >= ub->dev_info.nr_hw_queues) goto out;

2.40.1

Now queued up, thanks.

greg k-h