- restore the behavior in enable_net_traffic() to avoid regressions - Jakub Kicinski; - hurried up and removed redundant assignment in pegasus_open() before yet another checker complains;
v3: Added CC: stable@vger.kernel.org in a vague hope this time it'll go in;
Fixes: 8a160e2e9aeb ("net: usb: pegasus: Check the return value of get_geristers() and friends;") CC: stable@vger.kernel.org Reported-by: Jakub Kicinski kuba@kernel.org Signed-off-by: Petko Manolov petko.manolov@konsulko.com
--- drivers/net/usb/pegasus.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index 652e9fcf0b77..9f9dd0de33cb 100644 --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c @@ -446,7 +446,7 @@ static int enable_net_traffic(struct net_device *dev, struct usb_device *usb) write_mii_word(pegasus, 0, 0x1b, &auxmode); }
- return 0; + return ret; fail: netif_dbg(pegasus, drv, pegasus->net, "%s failed\n", __func__); return ret; @@ -835,7 +835,7 @@ static int pegasus_open(struct net_device *net) if (!pegasus->rx_skb) goto exit;
- res = set_registers(pegasus, EthID, 6, net->dev_addr); + set_registers(pegasus, EthID, 6, net->dev_addr);
usb_fill_bulk_urb(pegasus->rx_urb, pegasus->usb, usb_rcvbulkpipe(pegasus->usb, 1),
On Sun, Aug 29, 2021 at 11:34:02PM +0300, Petko Manolov wrote:
- restore the behavior in enable_net_traffic() to avoid regressions - Jakub Kicinski;
- hurried up and removed redundant assignment in pegasus_open() before yet another checker complains;
THat is two different things, why not just do one thing per patch?
v3: Added CC: stable@vger.kernel.org in a vague hope this time it'll go in;
This goes below the --- line, as the documentation states.
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org