Remove kfree(&vi->smb_vol), since &vi->smb_vol is a pointer to an area inside the allocated memory.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 54be1f6c1c37 ("cifs: Add DFS cache routines") Signed-off-by: Alexandra Diupina adiupina@astralinux.ru --- fs/cifs/dfs_cache.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/fs/cifs/dfs_cache.c b/fs/cifs/dfs_cache.c index 7b6db272fd0b..da6d775102f2 100644 --- a/fs/cifs/dfs_cache.c +++ b/fs/cifs/dfs_cache.c @@ -1194,7 +1194,6 @@ static int dup_vol(struct smb_vol *vol, struct smb_vol *new) kfree_sensitive(new->password); err_free_username: kfree(new->username); - kfree(new); return -ENOMEM; }
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#opti...
Rule: The upstream commit ID must be specified with a separate line above the commit text. Subject: [PATCH 5.10] cifs: Fix freeing non heap memory in dup_vol() Link: https://lore.kernel.org/stable/20240904144832.28857-1-adiupina%40astralinux....
Please ignore this mail if the patch is not relevant for upstream.
linux-stable-mirror@lists.linaro.org