Hi again,
also for 6.1.132-rc1 the review hasn't started yet, but as it was already available on [1], our CI has also tried to built it for ia64 in the morning. Unfortunately that failed, too - I assume due to the following **missing** upstream commit:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commi...
[1]: https://web.git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.g...
Build failure (see [2]):
``` [...] In file included from ./include/linux/string.h:5, from ./include/linux/uuid.h:12, from ./fs/xfs/xfs_linux.h:10, from ./fs/xfs/xfs.h:22, from fs/xfs/libxfs/xfs_alloc.c:6: fs/xfs/libxfs/xfs_alloc.c: In function '__xfs_free_extent_later': fs/xfs/libxfs/xfs_alloc.c:2551:51: error: 'mp' undeclared (first use in this function); did you mean 'tp'? 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~ ./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ fs/xfs/libxfs/xfs_alloc.c:2551:51: note: each undeclared identifier is reported only once for each function it appears in 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~ ./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ ./fs/xfs/xfs_linux.h:225:63: warning: left-hand operand of comma expression has no effect [-Wunused-value] 225 | __this_address), \ | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ make[5]: *** [scripts/Makefile.build:250: fs/xfs/libxfs/xfs_alloc.o] Error 1 [...] ```
[2]: https://github.com/linux-ia64/linux-stable-rc/actions/runs/13914712427/job/3...
[3] (7dfee17b13e5024c5c0ab1911859ded4182de3e5 upstream) introduced the XFS_IS_CORRUPT macro call now in `fs/xfs/libxfs/xfs_alloc.c:2551`, but the struct "mp" is only there when DEBUG is defined in 6.1.132-rc1. The above upstream commit (f6b3846) moves "mp" out of that guard and hence should fix that specific build regression IIUC. Again not build-tested yet, though.
[3]: https://web.git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.g...
Cheers, Frank
v6.1.132-rc1 build fails on Azure x86 and arm64 VM:
fs/xfs/libxfs/xfs_alloc.c: In function '__xfs_free_extent_later': fs/xfs/libxfs/xfs_alloc.c:2551:51: error: 'mp' undeclared (first use in this function); did you mean 'tp'? 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~ ./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ fs/xfs/libxfs/xfs_alloc.c:2551:51: note: each undeclared identifier is reported only once for each function it appears in 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~ ./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ In file included from ./fs/xfs/xfs.h:22, from fs/xfs/libxfs/xfs_alloc.c:6: ./fs/xfs/xfs_linux.h:225:63: warning: left-hand operand of comma expression has no effect [-Wunused-value] 225 | __this_address), \ | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ CC [M] net/ipv4/netfilter/arpt_mangle.o CC net/unix/scm.o make[3]: *** [scripts/Makefile.build:250: fs/xfs/libxfs/xfs_alloc.o] Error 1 make[2]: *** [scripts/Makefile.build:503: fs/xfs] Error 2
Tested-by: Hardik Garg hargar@linux.microsoft.com
Thanks, Hardik
Hey this is my bad, I cherry picked the fix to my local 6.1.y, running tests now, should be out for review tomo or friday.
Thanks Frank for finding the missing commit! (https://lore.kernel.org/stable/8c6125d7-363c-42b3-bdbb-f802cb8b4408@web.de/)
- leah
On Wed, Mar 19, 2025 at 3:25 PM Hardik Garg hargar@linux.microsoft.com wrote:
v6.1.132-rc1 build fails on Azure x86 and arm64 VM:
fs/xfs/libxfs/xfs_alloc.c: In function '__xfs_free_extent_later': fs/xfs/libxfs/xfs_alloc.c:2551:51: error: 'mp' undeclared (first use in this function); did you mean 'tp'? 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~ ./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ fs/xfs/libxfs/xfs_alloc.c:2551:51: note: each undeclared identifier is reported only once for each function it appears in 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~ ./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ In file included from ./fs/xfs/xfs.h:22, from fs/xfs/libxfs/xfs_alloc.c:6: ./fs/xfs/xfs_linux.h:225:63: warning: left-hand operand of comma expression has no effect [-Wunused-value] 225 | __this_address), \ | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ CC [M] net/ipv4/netfilter/arpt_mangle.o CC net/unix/scm.o make[3]: *** [scripts/Makefile.build:250: fs/xfs/libxfs/xfs_alloc.o] Error 1 make[2]: *** [scripts/Makefile.build:503: fs/xfs] Error 2
Tested-by: Hardik Garg hargar@linux.microsoft.com
Thanks, Hardik
Hi Leah,
On 20.03.25 00:50, Leah Rumancik wrote:
Hey this is my bad, I cherry picked the fix to my local 6.1.y, running tests now, should be out for review tomo or friday.
Ah, ok, looking into [1] again, I should have CCed to all Signed-of-bys when sending [2] in the first place. :-)
[1]: https://web.git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.g...
[2]: https://lore.kernel.org/lkml/8c6125d7-363c-42b3-bdbb-f802cb8b4408@web.de/
Thanks Frank for finding the missing commit! (https://lore.kernel.org/stable/8c6125d7-363c-42b3-bdbb-f802cb8b4408@web.de/)
You're welcome.
Cheers, Frank
On Wed, Mar 19, 2025 at 03:25:50PM -0700, Hardik Garg wrote:
v6.1.132-rc1 build fails on Azure x86 and arm64 VM:
Odd, there is no real 6.1.132-rc1 announcement yet, so there's no rush at the moment :)
fs/xfs/libxfs/xfs_alloc.c: In function '__xfs_free_extent_later': fs/xfs/libxfs/xfs_alloc.c:2551:51: error: 'mp' undeclared (first use in this function); did you mean 'tp'? 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~ ./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ fs/xfs/libxfs/xfs_alloc.c:2551:51: note: each undeclared identifier is reported only once for each function it appears in 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~ ./include/linux/compiler.h:78:45: note: in definition of macro 'unlikely' 78 | # define unlikely(x) __builtin_expect(!!(x), 0) | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ In file included from ./fs/xfs/xfs.h:22, from fs/xfs/libxfs/xfs_alloc.c:6: ./fs/xfs/xfs_linux.h:225:63: warning: left-hand operand of comma expression has no effect [-Wunused-value] 225 | __this_address), \ | ^ fs/xfs/libxfs/xfs_alloc.c:2551:13: note: in expansion of macro 'XFS_IS_CORRUPT' 2551 | if (XFS_IS_CORRUPT(mp, !xfs_verify_fsbext(mp, bno, len))) | ^~~~~~~~~~~~~~ CC [M] net/ipv4/netfilter/arpt_mangle.o CC net/unix/scm.o make[3]: *** [scripts/Makefile.build:250: fs/xfs/libxfs/xfs_alloc.o] Error 1 make[2]: *** [scripts/Makefile.build:503: fs/xfs] Error 2
Something is odd with the xfs patches I took?
Any hints on what to do is appreciated.
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Frank Scheiner -
Greg KH -
Hardik Garg -
Leah Rumancik