Hi Greg, We noticed that the Tegra PCIe host controller driver enabled "Relaxed Ordering" bit in the PCIe configuration space for "all" devices erroneously. We pushed a fix for this through the commit: 7be142caabc4780b13a522c485abc806de5c4114 and it has been soaking in main line for the last four months. Based on the discussion we had @ http://patchwork.ozlabs.org/patch/1127604/ we would now like to push it to the following stable kernels 4.19 : Applies cleanly 3.16, 4.4, 4.9 & 4.14 : Following equivalent patch needs to be used as the file was at drivers/pci/host/pci-tegra.c earlier (and moved to drivers/pci/controller/pci-tegra.c starting 4.19)
--- drivers/pci/host/pci-tegra.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/host/pci-tegra.c b/drivers/pci/host/pci-tegra.c index 083cf37ca047..56daa83b041c 100644 --- a/drivers/pci/host/pci-tegra.c +++ b/drivers/pci/host/pci-tegra.c @@ -615,12 +615,15 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x0bf1, tegra_pcie_fixup_class); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x0e1c, tegra_pcie_fixup_class); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_NVIDIA, 0x0e1d, tegra_pcie_fixup_class);
-/* Tegra PCIE requires relaxed ordering */ +/* Tegra20 and Tegra30 PCIE requires relaxed ordering */ static void tegra_pcie_relax_enable(struct pci_dev *dev) { pcie_capability_set_word(dev, PCI_EXP_DEVCTL, PCI_EXP_DEVCTL_RELAX_EN); } -DECLARE_PCI_FIXUP_FINAL(PCI_ANY_ID, PCI_ANY_ID, tegra_pcie_relax_enable); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x0bf0, tegra_pcie_relax_enable); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x0bf1, tegra_pcie_relax_enable); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x0e1c, tegra_pcie_relax_enable); +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_NVIDIA, 0x0e1d, tegra_pcie_relax_enable);
static int tegra_pcie_setup(int nr, struct pci_sys_data *sys) { -- 2.17.1
On Mon, Nov 11, 2019 at 06:24:53PM +0530, Vidya Sagar wrote:
Hi Greg, We noticed that the Tegra PCIe host controller driver enabled "Relaxed Ordering" bit in the PCIe configuration space for "all" devices erroneously. We pushed a fix for this through the commit: 7be142caabc4780b13a522c485abc806de5c4114 and it has been soaking in main line for the last four months. Based on the discussion we had @ http://patchwork.ozlabs.org/patch/1127604/ we would now like to push it to the following stable kernels 4.19 : Applies cleanly 3.16, 4.4, 4.9 & 4.14 : Following equivalent patch needs to be used as the file was at drivers/pci/host/pci-tegra.c earlier (and moved to drivers/pci/controller/pci-tegra.c starting 4.19)
All now queued up (except for 3.16, that's Ben's tree, he will get to it soon.)
thanks,
greg k-h
On 11/11/2019 6:39 PM, Greg Kroah-Hartman wrote:
On Mon, Nov 11, 2019 at 06:24:53PM +0530, Vidya Sagar wrote:
Hi Greg, We noticed that the Tegra PCIe host controller driver enabled "Relaxed Ordering" bit in the PCIe configuration space for "all" devices erroneously. We pushed a fix for this through the commit: 7be142caabc4780b13a522c485abc806de5c4114 and it has been soaking in main line for the last four months. Based on the discussion we had @ http://patchwork.ozlabs.org/patch/1127604/ we would now like to push it to the following stable kernels 4.19 : Applies cleanly 3.16, 4.4, 4.9 & 4.14 : Following equivalent patch needs to be used as the file was at drivers/pci/host/pci-tegra.c earlier (and moved to drivers/pci/controller/pci-tegra.c starting 4.19)
All now queued up (except for 3.16, that's Ben's tree, he will get to it soon.)
thanks,
greg k-h
Thanks a lot Greg.
- Vidya Sagar
On 11/11/2019 8:52 PM, Vidya Sagar wrote:
On 11/11/2019 6:39 PM, Greg Kroah-Hartman wrote:
On Mon, Nov 11, 2019 at 06:24:53PM +0530, Vidya Sagar wrote:
Hi Greg, We noticed that the Tegra PCIe host controller driver enabled "Relaxed Ordering" bit in the PCIe configuration space for "all" devices erroneously. We pushed a fix for this through the commit: 7be142caabc4780b13a522c485abc806de5c4114 and it has been soaking in main line for the last four months. Based on the discussion we had @ http://patchwork.ozlabs.org/patch/1127604/ we would now like to push it to the following stable kernels 4.19 : Applies cleanly 3.16, 4.4, 4.9 & 4.14 : Following equivalent patch needs to be used as the file was at drivers/pci/host/pci-tegra.c earlier (and moved to drivers/pci/controller/pci-tegra.c starting 4.19)
All now queued up (except for 3.16, that's Ben's tree, he will get to it soon.)
Hi Ben, Could you please queue this up for 3.16 as well?
- Vidya Sagar
thanks,
greg k-h
Thanks a lot Greg.
- Vidya Sagar
On Mon, 2019-11-18 at 12:05 +0530, Vidya Sagar wrote:
On 11/11/2019 8:52 PM, Vidya Sagar wrote:
On 11/11/2019 6:39 PM, Greg Kroah-Hartman wrote:
On Mon, Nov 11, 2019 at 06:24:53PM +0530, Vidya Sagar wrote:
Hi Greg, We noticed that the Tegra PCIe host controller driver enabled "Relaxed Ordering" bit in the PCIe configuration space for "all" devices erroneously. We pushed a fix for this through the commit: 7be142caabc4780b13a522c485abc806de5c4114 and it has been soaking in main line for the last four months. Based on the discussion we had @ http://patchwork.ozlabs.org/patch/1127604/ we would now like to push it to the following stable kernels 4.19 : Applies cleanly 3.16, 4.4, 4.9 & 4.14 : Following equivalent patch needs to be used as the file was at drivers/pci/host/pci-tegra.c earlier (and moved to drivers/pci/controller/pci-tegra.c starting 4.19)
All now queued up (except for 3.16, that's Ben's tree, he will get to it soon.)
Hi Ben, Could you please queue this up for 3.16 as well?
OK, I've added it to my queue.
Ben.
On 11/19/2019 8:01 PM, Ben Hutchings wrote:
On Mon, 2019-11-18 at 12:05 +0530, Vidya Sagar wrote:
On 11/11/2019 8:52 PM, Vidya Sagar wrote:
On 11/11/2019 6:39 PM, Greg Kroah-Hartman wrote:
On Mon, Nov 11, 2019 at 06:24:53PM +0530, Vidya Sagar wrote:
Hi Greg, We noticed that the Tegra PCIe host controller driver enabled "Relaxed Ordering" bit in the PCIe configuration space for "all" devices erroneously. We pushed a fix for this through the commit: 7be142caabc4780b13a522c485abc806de5c4114 and it has been soaking in main line for the last four months. Based on the discussion we had @ http://patchwork.ozlabs.org/patch/1127604/ we would now like to push it to the following stable kernels 4.19 : Applies cleanly 3.16, 4.4, 4.9 & 4.14 : Following equivalent patch needs to be used as the file was at drivers/pci/host/pci-tegra.c earlier (and moved to drivers/pci/controller/pci-tegra.c starting 4.19)
All now queued up (except for 3.16, that's Ben's tree, he will get to it soon.)
Hi Ben, Could you please queue this up for 3.16 as well?
OK, I've added it to my queue.
Ben.
Thanks Ben DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1574175887; bh=uXgYUHwtrZapitSGWf5JwJRJHk5Ptu14CGrFy5WPBBY=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=BPvs5cLXDhhzLY5asc+jfjOrcDfSlyLorXJ5IgqoZzGwtoQ5I7z6XjucTqpIfjqvw vygAgc9INi1iMl3JQz19LURImeo9BxUh7BSosY61mt8KGlFI0vWOiCBtdKiWMy7avG V9pqAEnRT6/i4VNoqZdFLItXcW8UXe/JP8Pw5vFyQn4+XzGDefCFLqGLySYDcUH8E0 djZWIOywbATPq1ULSYYChrKdqoRMTbhz2C1cA4f2LTMzoOB27bFwjRJxEGuMjIAYT+ m1Q/FvH2fSse30bw3za+YkstE61vC8SyMV2/4sOT1vb4JNVsVI9/0GyguV2syIrmlR KjiT61+BAXAkg==
- Vidya Sagar
linux-stable-mirror@lists.linaro.org
-
Ben Hutchings -
Greg Kroah-Hartman -
Vidya Sagar