A copy/paste bug (probably) caused setting of an app_tag check mask in case where a ref_tag check was needed.
Fixes: 38a2d0d429f1 ("IB/isert: convert to the generic RDMA READ/WRITE API") Fixes: 9e961ae73c2c ("IB/isert: Support T10-PI protected transactions") Cc: stable@vger.kernel.org Signed-off-by: Max Gurtovoy maxg@mellanox.com --- drivers/infiniband/ulp/isert/ib_isert.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c index fff40b0..d8b6bde 100644 --- a/drivers/infiniband/ulp/isert/ib_isert.c +++ b/drivers/infiniband/ulp/isert/ib_isert.c @@ -2108,7 +2108,7 @@
sig_attrs->check_mask = (se_cmd->prot_checks & TARGET_DIF_CHECK_GUARD ? 0xc0 : 0) | - (se_cmd->prot_checks & TARGET_DIF_CHECK_REFTAG ? 0x30 : 0) | + (se_cmd->prot_checks & TARGET_DIF_CHECK_APPTAG ? 0x30 : 0) | (se_cmd->prot_checks & TARGET_DIF_CHECK_REFTAG ? 0x0f : 0); return 0; }
On Sun, May 27, 2018 at 06:50:06PM +0300, Max Gurtovoy wrote:
A copy/paste bug (probably) caused setting of an app_tag check mask in case where a ref_tag check was needed.
Fixes: 38a2d0d429f1 ("IB/isert: convert to the generic RDMA READ/WRITE API") Fixes: 9e961ae73c2c ("IB/isert: Support T10-PI protected transactions") Cc: stable@vger.kernel.org Signed-off-by: Max Gurtovoy maxg@mellanox.com
Looks good, and should probably got into the scsi tree ASAP.
Btw, please don't cc stable@ for the whole series.
On 5/28/2018 10:21 AM, Christoph Hellwig wrote:
On Sun, May 27, 2018 at 06:50:06PM +0300, Max Gurtovoy wrote:
A copy/paste bug (probably) caused setting of an app_tag check mask in case where a ref_tag check was needed.
Fixes: 38a2d0d429f1 ("IB/isert: convert to the generic RDMA READ/WRITE API") Fixes: 9e961ae73c2c ("IB/isert: Support T10-PI protected transactions") Cc: stable@vger.kernel.org Signed-off-by: Max Gurtovoy maxg@mellanox.com
Looks good, and should probably got into the scsi tree ASAP.
Yes, there are few patches that can be pushed "as is".
Should it go through Nicholas PR ?
Btw, please don't cc stable@ for the whole series.
The cc stable@ is only for this patch and not for the series.
On Mon, May 28, 2018 at 02:54:48PM +0300, Max Gurtovoy wrote:
On 5/28/2018 10:21 AM, Christoph Hellwig wrote:
On Sun, May 27, 2018 at 06:50:06PM +0300, Max Gurtovoy wrote:
A copy/paste bug (probably) caused setting of an app_tag check mask in case where a ref_tag check was needed.
Fixes: 38a2d0d429f1 ("IB/isert: convert to the generic RDMA READ/WRITE API") Fixes: 9e961ae73c2c ("IB/isert: Support T10-PI protected transactions") Cc: stable@vger.kernel.org Signed-off-by: Max Gurtovoy maxg@mellanox.com
Looks good, and should probably got into the scsi tree ASAP.
Yes, there are few patches that can be pushed "as is".
Should it go through Nicholas PR ?
Nic has been non-responsive for a while and Martin has queued up target fixes when needed.
Hi Martin/Jason,
can you please coordinate on taking this fix through your PR (RDMA or SCSi) ?
On 5/28/2018 3:03 PM, Christoph Hellwig wrote:
On Mon, May 28, 2018 at 02:54:48PM +0300, Max Gurtovoy wrote:
On 5/28/2018 10:21 AM, Christoph Hellwig wrote:
On Sun, May 27, 2018 at 06:50:06PM +0300, Max Gurtovoy wrote:
A copy/paste bug (probably) caused setting of an app_tag check mask in case where a ref_tag check was needed.
Fixes: 38a2d0d429f1 ("IB/isert: convert to the generic RDMA READ/WRITE API") Fixes: 9e961ae73c2c ("IB/isert: Support T10-PI protected transactions") Cc: stable@vger.kernel.org Signed-off-by: Max Gurtovoy maxg@mellanox.com
Looks good, and should probably got into the scsi tree ASAP.
Yes, there are few patches that can be pushed "as is".
Should it go through Nicholas PR ?
Nic has been non-responsive for a while and Martin has queued up target fixes when needed.
On 5/29/2018 6:01 AM, Martin K. Petersen wrote:
Jason,
I see no problem for you to take it. Let me know if you prefer we do it through RDMA.
Applied to 4.17/scsi-fixes. Thanks!
Thanks Martin.
Jason, how do you suggest to proceed with patches 2/3/4 that were reviewed by Christoph ?
we must wait until Martin PR for sure...
-Max.
On Tue, May 29, 2018 at 03:08:21PM +0300, Max Gurtovoy wrote:
On 5/29/2018 6:01 AM, Martin K. Petersen wrote:
Jason,
I see no problem for you to take it. Let me know if you prefer we do it through RDMA.
Applied to 4.17/scsi-fixes. Thanks!
Thanks Martin.
Jason, how do you suggest to proceed with patches 2/3/4 that were reviewed by Christoph ?
If you want RDMA to take any patches send them to linux-rdma@vger.kernel.org, updated to include the tags that Christoph included.. Otherwise they are not in the RDMA patchworks.
we must wait until Martin PR for sure...
Hmm, maybe we should have sent this patch through rdma in that case.. The merge window is soon anyhow so it doesn't really matter this time - but you need to think about what tree patches need to go to when building your patch plan, don't just send a large unstructured series like this and expect the maintainers to figure out all the dependencies!
So, send the patches you want to the rdma list around rc1
Thanks, Jason
Jason,
we must wait until Martin PR for sure...
Hmm, maybe we should have sent this patch through rdma in that case.. The merge window is soon anyhow so it doesn't really matter this time - but you need to think about what tree patches need to go to when building your patch plan, don't just send a large unstructured series like this and expect the maintainers to figure out all the dependencies!
I am also happy to just drop the patch from scsi-fixes and you can funnel everything through RDMA. Doesn't matter to me.
On Tue, May 29, 2018 at 06:11:18PM -0400, Martin K. Petersen wrote:
Jason,
we must wait until Martin PR for sure...
Hmm, maybe we should have sent this patch through rdma in that case.. The merge window is soon anyhow so it doesn't really matter this time - but you need to think about what tree patches need to go to when building your patch plan, don't just send a large unstructured series like this and expect the maintainers to figure out all the dependencies!
I am also happy to just drop the patch from scsi-fixes and you can funnel everything through RDMA. Doesn't matter to me.
Sure, if you can still do that.. Max can you send me all four patches tomorrow and I'll route them through rdma.
Thanks, Jason
On 5/30/2018 1:19 AM, Jason Gunthorpe wrote:
On Tue, May 29, 2018 at 06:11:18PM -0400, Martin K. Petersen wrote:
Jason,
we must wait until Martin PR for sure...
Hmm, maybe we should have sent this patch through rdma in that case.. The merge window is soon anyhow so it doesn't really matter this time - but you need to think about what tree patches need to go to when building your patch plan, don't just send a large unstructured series like this and expect the maintainers to figure out all the dependencies!
I am also happy to just drop the patch from scsi-fixes and you can funnel everything through RDMA. Doesn't matter to me.
Sure, if you can still do that.. Max can you send me all four patches tomorrow and I'll route them through rdma.
Yes sure. I'm sorry for the ping-pong, I've tried to cover this in the cover letter but I guess I should've mentioned specifically what patches goes through which tree.
Thanks, Jason
On Wed, May 30, 2018 at 11:07:17AM +0300, Max Gurtovoy wrote:
On 5/30/2018 1:19 AM, Jason Gunthorpe wrote:
On Tue, May 29, 2018 at 06:11:18PM -0400, Martin K. Petersen wrote:
Jason,
we must wait until Martin PR for sure...
Hmm, maybe we should have sent this patch through rdma in that case.. The merge window is soon anyhow so it doesn't really matter this time - but you need to think about what tree patches need to go to when building your patch plan, don't just send a large unstructured series like this and expect the maintainers to figure out all the dependencies!
I am also happy to just drop the patch from scsi-fixes and you can funnel everything through RDMA. Doesn't matter to me.
Sure, if you can still do that.. Max can you send me all four patches tomorrow and I'll route them through rdma.
Yes sure. I'm sorry for the ping-pong, I've tried to cover this in the cover letter but I guess I should've mentioned specifically what patches goes through which tree.
Just in general don't send such a jumble of patches for multiple maintainers under one cover letter. It is error prone to sort it out.
Jason
btw, please CC target-devel for isert patches in the future. Also the subject prefix is usually iser-target (not a must though)
linux-stable-mirror@lists.linaro.org
-
Christoph Hellwig -
Jason Gunthorpe -
Martin K. Petersen -
Max Gurtovoy -
Sagi Grimberg