Request to pick "ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size"
Hi,
please pick
1e020e1b96afd ("ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size")
from linux-next to stable trees. The commit fixes a problem with another recent commit
1b42b1a36fc94 ("ubi: ensure that VID header offset ... size")
which has already made it to stable trees and thereby broke attaching UBI and hence renders devices unbootable.
As a temporary fix I have applied this patch downstream in OpenWrt.
Thank you!
Best regards
Daniel
----- Forwarded message from Daniel Golle daniel@makrotopia.org -----
Date: Sat, 15 Apr 2023 00:12:46 +0100 From: Daniel Golle daniel@makrotopia.org To: Richard Weinberger richard@nod.at Cc: Miquel Raynal miquel.raynal@bootlin.com, chengzhihao1 chengzhihao1@huawei.com, Nicolas Schichan nschichan@freebox.fr, George Kennedy george.kennedy@oracle.com, linux-kernel linux-kernel@vger.kernel.org, linux-mtd linux-mtd@lists.infradead.org, Sascha Hauer s.hauer@pengutronix.de, yi zhang yi.zhang@huawei.com Subject: Re: [PATCH -next v3] ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size
Hi Richard,
On Wed, Mar 29, 2023 at 11:33:40PM +0200, Richard Weinberger wrote:
----- Ursprüngliche Mail -----
Von: "Miquel Raynal" miquel.raynal@bootlin.com
Thanks for testing.
Tested-by: Nicolas Schichan nschichan@freebox.fr
Same here.
Tested-by: Miquel Raynal miquel.raynal@bootlin.com # v5.10, v4.19
Applied to next, PR will follow soon.
As stable linux trees are affected I wonder when this will hit linux-stable, ie. will it be part of 5.15.108, for example?
Cheers
Daniel
----- End forwarded message -----
On Sat, Apr 15, 2023 at 07:02:26PM +0100, Daniel Golle wrote:
Hi,
please pick
1e020e1b96afd ("ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size")
from linux-next to stable trees.
We need to have it hit Linus's tree first. Any reason why it isn't there yet?
thanks,
greg k-h
----- Ursprüngliche Mail -----
Von: "Daniel Golle" daniel@makrotopia.org An: "stable" stable@vger.kernel.org, "linux-mtd" linux-mtd@lists.infradead.org CC: "Hauke Mehrtens" hauke@hauke-m.de, "richard" richard@nod.at, "Miquel Raynal" miquel.raynal@bootlin.com, "chengzhihao1" chengzhihao1@huawei.com, "Nicolas Schichan" nschichan@freebox.fr, "George Kennedy" george.kennedy@oracle.com, "Sascha Hauer" s.hauer@pengutronix.de, "yi zhang" yi.zhang@huawei.com Gesendet: Samstag, 15. April 2023 20:02:26 Betreff: Request to pick "ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size"
Hi,
please pick
1e020e1b96afd ("ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size")
from linux-next to stable trees.
FYI, the fix is not yet in Linus' master. But I guess it will be very soon. The pull request is on the mailinglist.
Thanks, //richard
On Sat, Apr 15, 2023 at 08:26:17PM +0200, Richard Weinberger wrote:
----- Ursprüngliche Mail -----
Von: "Daniel Golle" daniel@makrotopia.org An: "stable" stable@vger.kernel.org, "linux-mtd" linux-mtd@lists.infradead.org CC: "Hauke Mehrtens" hauke@hauke-m.de, "richard" richard@nod.at, "Miquel Raynal" miquel.raynal@bootlin.com, "chengzhihao1" chengzhihao1@huawei.com, "Nicolas Schichan" nschichan@freebox.fr, "George Kennedy" george.kennedy@oracle.com, "Sascha Hauer" s.hauer@pengutronix.de, "yi zhang" yi.zhang@huawei.com Gesendet: Samstag, 15. April 2023 20:02:26 Betreff: Request to pick "ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size"
Hi,
please pick
1e020e1b96afd ("ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size")
from linux-next to stable trees.
FYI, the fix is not yet in Linus' master. But I guess it will be very soon. The pull request is on the mailinglist.
Any specific reason why it wasn't tagged cc: stable@ if it was known to be fixing a regression so that we would pick it up automatically?
thanks,
greg k-h
----- Ursprüngliche Mail -----
Von: "Greg Kroah-Hartman" gregkh@linuxfoundation.org Any specific reason why it wasn't tagged cc: stable@ if it was known to be fixing a regression so that we would pick it up automatically?
Because I noticed only after I pushed already to next and therefore planned to inform you by mail. But Daniel was faster...
Thanks, //richard
On Sat, Apr 15, 2023 at 07:02:26PM +0100, Daniel Golle wrote:
Hi,
please pick
1e020e1b96afd ("ubi: Fix failure attaching when vid_hdr offset equals to (sub)page size")
from linux-next to stable trees. The commit fixes a problem with another recent commit
1b42b1a36fc94 ("ubi: ensure that VID header offset ... size")
which has already made it to stable trees and thereby broke attaching UBI and hence renders devices unbootable.
As a temporary fix I have applied this patch downstream in OpenWrt.
Now queued up, thanks.
greg k-h
linux-stable-mirror@lists.linaro.org
-
Daniel Golle -
Greg KH -
Richard Weinberger