Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.
This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.
Given the code similarity it is likely to affect ofdrm in the same way.
It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328 Link: https://bugs.debian.org/1033058 Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique") Cc: stable@vger.kernel.org # v6.2+ Signed-off-by: Cyril Brulebois cyril@debamax.com --- drivers/gpu/drm/tiny/ofdrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c index 6e349ca42485..92df021d71df 100644 --- a/drivers/gpu/drm/tiny/ofdrm.c +++ b/drivers/gpu/drm/tiny/ofdrm.c @@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
static struct platform_driver ofdrm_platform_driver = { .driver = { - .name = "of-display", + .name = "of-display.0", .of_match_table = ofdrm_of_match_display, }, .probe = ofdrm_probe,
Hi Cyril,
CC DT
On Wed, Apr 12, 2023 at 12:05 PM Cyril Brulebois cyril@debamax.com wrote:
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.
This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.
Given the code similarity it is likely to affect ofdrm in the same way.
It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328 Link: https://bugs.debian.org/1033058 Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique") Cc: stable@vger.kernel.org # v6.2+ Signed-off-by: Cyril Brulebois cyril@debamax.com
Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.
--- a/drivers/gpu/drm/tiny/ofdrm.c +++ b/drivers/gpu/drm/tiny/ofdrm.c @@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
static struct platform_driver ofdrm_platform_driver = { .driver = {
.name = "of-display",
.name = "of-display.0", .of_match_table = ofdrm_of_match_display, }, .probe = ofdrm_probe,
Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".
https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hN...
Gr{oetje,eeting}s,
Geert
Hi
Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:
Hi Cyril,
CC DT
On Wed, Apr 12, 2023 at 12:05 PM Cyril Brulebois cyril@debamax.com wrote:
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.
This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.
Given the code similarity it is likely to affect ofdrm in the same way.
It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328 Link: https://bugs.debian.org/1033058 Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique") Cc: stable@vger.kernel.org # v6.2+ Signed-off-by: Cyril Brulebois cyril@debamax.com
Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.
--- a/drivers/gpu/drm/tiny/ofdrm.c +++ b/drivers/gpu/drm/tiny/ofdrm.c @@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
static struct platform_driver ofdrm_platform_driver = { .driver = {
.name = "of-display",
.name = "of-display.0", .of_match_table = ofdrm_of_match_display, }, .probe = ofdrm_probe,Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".
https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hN...
Sorry that I missed this patch. I agree that it's probably not correct. At least in ofdrm, we want to be able to use multiple framebuffers at the same time; a feature that has been broken by this change.
Best regards Thomas
Gr{oetje,eeting}s,
Geert
On 4/24/23 11:07, Thomas Zimmermann wrote:
Hi
Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:
Hi Cyril,
CC DT
On Wed, Apr 12, 2023 at 12:05 PM Cyril Brulebois cyril@debamax.com wrote:
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.
This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.
Given the code similarity it is likely to affect ofdrm in the same way.
It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328 Link: https://bugs.debian.org/1033058 Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique") Cc: stable@vger.kernel.org # v6.2+ Signed-off-by: Cyril Brulebois cyril@debamax.com
Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.
--- a/drivers/gpu/drm/tiny/ofdrm.c +++ b/drivers/gpu/drm/tiny/ofdrm.c @@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
static struct platform_driver ofdrm_platform_driver = { .driver = { - .name = "of-display", + .name = "of-display.0", .of_match_table = ofdrm_of_match_display, }, .probe = ofdrm_probe,
Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".
https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hN...
Sorry that I missed this patch. I agree that it's probably not correct. At least in ofdrm, we want to be able to use multiple framebuffers at the same time; a feature that has been broken by this change.
Geert & Thomas, thanks for the review!
I've dropped both patches from fbdev tree for now. Would be great to find another good solution though, as it breaks the debian installer.
Helge
Hi, Thorsten here, the Linux kernel's regression tracker. Top-posting for once, to make this easily accessible to everyone.
Was a proper solution for the regression the initial mail in this thread is about ever found? Doesn't look like it for here, but maybe I'm missing something.
Reminder, the problem afaik is caused by 241d2fb56a ("of: Make OF framebuffer device names unique") [merged for v6.2-rc8, authored by Michal Suchanek; committed by Rob Herring].
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.
#regzbot poke
On 24.04.23 11:35, Helge Deller wrote:
On 4/24/23 11:07, Thomas Zimmermann wrote:
Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:
On Wed, Apr 12, 2023 at 12:05 PM Cyril Brulebois cyril@debamax.com wrote:
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.
This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.
Given the code similarity it is likely to affect ofdrm in the same way.
It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328 Link: https://bugs.debian.org/1033058 Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique") Cc: stable@vger.kernel.org # v6.2+ Signed-off-by: Cyril Brulebois cyril@debamax.com
Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.
--- a/drivers/gpu/drm/tiny/ofdrm.c +++ b/drivers/gpu/drm/tiny/ofdrm.c @@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
static struct platform_driver ofdrm_platform_driver = { .driver = { - .name = "of-display", + .name = "of-display.0", .of_match_table = ofdrm_of_match_display, }, .probe = ofdrm_probe,
Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".
https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hN...
Sorry that I missed this patch. I agree that it's probably not correct. At least in ofdrm, we want to be able to use multiple framebuffers at the same time; a feature that has been broken by this change.
Geert & Thomas, thanks for the review!
I've dropped both patches from fbdev tree for now. Would be great to find another good solution though, as it breaks the debian installer.
Helge
On Mon, Apr 24, 2023 at 11:07:45AM +0200, Thomas Zimmermann wrote:
Hi
Am 24.04.23 um 09:33 schrieb Geert Uytterhoeven:
Hi Cyril,
CC DT
On Wed, Apr 12, 2023 at 12:05 PM Cyril Brulebois cyril@debamax.com wrote:
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.
This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.
Given the code similarity it is likely to affect ofdrm in the same way.
It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328 Link: https://bugs.debian.org/1033058 Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique") Cc: stable@vger.kernel.org # v6.2+ Signed-off-by: Cyril Brulebois cyril@debamax.com
Thanks for your patch, which is now commit 3a9d8ea2539ebebd ("drm/ofdrm: Update expected device name") in fbdev/for-next.
--- a/drivers/gpu/drm/tiny/ofdrm.c +++ b/drivers/gpu/drm/tiny/ofdrm.c @@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display);
static struct platform_driver ofdrm_platform_driver = { .driver = {
.name = "of-display",
.name = "of-display.0", .of_match_table = ofdrm_of_match_display, }, .probe = ofdrm_probe,Same comment as for "[PATCH 1/2] fbdev/offb: Update expected device name".
https://lore.kernel.org/r/CAMuHMdVGEeAsmb4tAuuqqGJ-4+BBETwEwYJA+M9NyJv0BJ_hN...
Sorry that I missed this patch. I agree that it's probably not correct. At least in ofdrm, we want to be able to use multiple framebuffers at the same time; a feature that has been broken by this change.
How did it work before, though?
We did not have this device name clash, then we did, and it was solved by renaming the devices to numnered.
Now matching the first device should restore the previously available functionality, mathing any of the numbered devices would potentially allow to use multiple devices.
Or am I missing something?
Thanks
Michal
On Wed, Apr 12, 2023 at 11:55:09AM +0200, Cyril Brulebois wrote:
Since commit 241d2fb56a18 ("of: Make OF framebuffer device names unique"), as spotted by Frédéric Bonnard, the historical "of-display" device is gone: the updated logic creates "of-display.0" instead, then as many "of-display.N" as required.
This means that offb no longer finds the expected device, which prevents the Debian Installer from setting up its interface, at least on ppc64el.
Given the code similarity it is likely to affect ofdrm in the same way.
It might be better to iterate on all possible nodes, but updating the hardcoded device from "of-display" to "of-display.0" is likely to help as a first step.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=217328 Link: https://bugs.debian.org/1033058 Fixes: 241d2fb56a18 ("of: Make OF framebuffer device names unique") Cc: stable@vger.kernel.org # v6.2+ Signed-off-by: Cyril Brulebois cyril@debamax.com
Reviewed-by: Michal Suchánek msuchanek@suse.de
drivers/gpu/drm/tiny/ofdrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/tiny/ofdrm.c b/drivers/gpu/drm/tiny/ofdrm.c index 6e349ca42485..92df021d71df 100644 --- a/drivers/gpu/drm/tiny/ofdrm.c +++ b/drivers/gpu/drm/tiny/ofdrm.c @@ -1390,7 +1390,7 @@ MODULE_DEVICE_TABLE(of, ofdrm_of_match_display); static struct platform_driver ofdrm_platform_driver = { .driver = {
.name = "of-display",
.name = "of-display.0",-- 2.30.2
linux-stable-mirror@lists.linaro.org
-
Cyril Brulebois -
Geert Uytterhoeven -
Helge Deller -
Linux regression tracking (Thorsten Leemhuis) -
Michal Suchánek -
Thomas Zimmermann