Hi,
I couldn't find an existing mail with "[PATCH AUTOSEL 6.1 N/M] XYZ" to reply to, so I'm just sending an email like this. Hope that's ok.
In https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/ tree/queue-6.1 there are a number of patches which start with: crypto-rockchip- like crypto-rockchip-add-fallback-for-ahash.patch
I guess they were (auto) selected as they contain a "Fixes: <commitid>" line. Those 7 patches are actually part of a larger patch set, see here: https://lore.kernel.org/all/20220927075511.3147847-1-clabbe@baylibre.com/
All those patches have been merged into Linus' tree for 6.2 and there's a hotfix planned to be submitted for 6.2 here: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/ commit/?h=v6.2-armsoc/dtsfixes&id=53e8e1e6e9c1653095211a8edf17912f2374bb03
Wouldn't it make more sense to queue the whole patch set for 6.1? Or (at least) the whole crypto rockchip part as mentioned here: https://lore.kernel.org/all/Y5mGGrBJaDL6mnQJ@gondor.apana.org.au/ under the "Corentin Labbe (32):" label?
Cheers, Diederik
On Wed, Dec 28, 2022 at 11:37:16AM +0100, Diederik de Haas wrote:
Hi,
I couldn't find an existing mail with "[PATCH AUTOSEL 6.1 N/M] XYZ" to reply to, so I'm just sending an email like this. Hope that's ok.
In https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/ tree/queue-6.1 there are a number of patches which start with: crypto-rockchip- like crypto-rockchip-add-fallback-for-ahash.patch
I guess they were (auto) selected as they contain a "Fixes: <commitid>" line. Those 7 patches are actually part of a larger patch set, see here: https://lore.kernel.org/all/20220927075511.3147847-1-clabbe@baylibre.com/
All those patches have been merged into Linus' tree for 6.2 and there's a hotfix planned to be submitted for 6.2 here: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/ commit/?h=v6.2-armsoc/dtsfixes&id=53e8e1e6e9c1653095211a8edf17912f2374bb03
Wouldn't it make more sense to queue the whole patch set for 6.1? Or (at least) the whole crypto rockchip part as mentioned here: https://lore.kernel.org/all/Y5mGGrBJaDL6mnQJ@gondor.apana.org.au/ under the "Corentin Labbe (32):" label?
Please provide us a list of the specific git commits and in the order in which you wish to see them applied and we will be glad to review them.
Looking at random links (that are wrapped and not able to be easily used) is not going to work well.
thanks,
greg k-h
On Wednesday, 28 December 2022 11:41:40 CET Greg KH wrote:
All those patches have been merged into Linus' tree for 6.2 and there's a hotfix planned to be submitted for 6.2 here: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/ commit/?h=v6.2-armsoc/dtsfixes&id=53e8e1e6e9c1653095211a8edf17912f2374bb03
Wouldn't it make more sense to queue the whole patch set for 6.1? Or (at least) the whole crypto rockchip part as mentioned here: https://lore.kernel.org/all/Y5mGGrBJaDL6mnQJ@gondor.apana.org.au/ under the "Corentin Labbe (32):" label?
Please provide us a list of the specific git commits and in the order in which you wish to see them applied and we will be glad to review them.
Looking at random links (that are wrapped and not able to be easily used) is not going to work well.
These are the commits from Linus' tree (in the correct order):
https://git.kernel.org/linus/299c481fa5c121f892420d97f1123a853b7f1079 https://git.kernel.org/linus/8ccd9c8cd1d1618f5e073c86ffcfe15f292eefe6 https://git.kernel.org/linus/c50ef1411c8cbad0c7db100c477126076b6e3348 https://git.kernel.org/linus/6d11c9387865723fd779be00ae37a4588e60133d https://git.kernel.org/linus/87e356c4966444866186f68f05832fdcc0f351a3 https://git.kernel.org/linus/68ef8af09a1a912a5ed2cfaa4cca7606f52cef90 https://git.kernel.org/linus/816600485cb597b3ff7d6806a95a78512839f775 https://git.kernel.org/linus/d6b23ccef82816050c2fd458c9dabfa0e0af09b9 https://git.kernel.org/linus/bb3c7b73363c9a149b12b74c44ae94b73a8fddf8 https://git.kernel.org/linus/57d67c6e8219b2a034c16d6149e30fb40fd39935 https://git.kernel.org/linus/6d55c4a206d29006c733b5083ba5da8391abbdbd https://git.kernel.org/linus/48d904d428b68080abd9161148ca2ab1331124a4 https://git.kernel.org/linus/a216be3964c15661579005012b1f0d7d20a1f265 https://git.kernel.org/linus/6f61192549d0214f8d9d1e1d3152e450658ed1e9 https://git.kernel.org/linus/3a6fd464f48ad35d8cf15d81fd92094132dc862a https://git.kernel.org/linus/e803188400d32d28ecfbef0878c289e3c7026723 https://git.kernel.org/linus/37bc22159c456ad43fb852fc6ed60f4081df25df https://git.kernel.org/linus/456698746b40008eb0924eb7e9ec908330948b2d https://git.kernel.org/linus/e65e90101329de0fe304e2df057f68c5f0fa4748 https://git.kernel.org/linus/a7fa0644dd0b91fab97398de7ea4672a6526261f https://git.kernel.org/linus/2e3b149578c30275db9c3501c1d9dec36d16622a https://git.kernel.org/linus/c018c7a9dd198ce965ca4d10c7b083849bc533be https://git.kernel.org/linus/ea389be9857721252367fd2cf81bc8068e060693 https://git.kernel.org/linus/81aaf680e85207d6521b250b2a80ba7c91cc9cbe https://git.kernel.org/linus/d1b5749687618d969c0be6428174a18a7e94ebd2 https://git.kernel.org/linus/b136468a0024ea90c1259767c732eed12ce6edba https://git.kernel.org/linus/d1152bc533c941f7e267bf53d344cee510ea2808 https://git.kernel.org/linus/8c701fa6e38c43dba75282e4d919298a5cfc5b05 https://git.kernel.org/linus/2d3c756adcd7a7ee15b6a55cf01b363e3f134e79 https://git.kernel.org/linus/e220e6719438f7a99fe0a73e6e126481380202fa https://git.kernel.org/linus/0d31b14c9e4178a129a1aa5e491e4da1489c07de https://git.kernel.org/linus/c5a1e104c35e5134b6048f1e03960a6ac9c42935 https://git.kernel.org/linus/9dcd71c863a6f6476378d076d3e9189c854d49fd
These commands will show them too: git log --oneline -25 d1b5749687618d969c0be6428174a18a7e94ebd2 --reverse git log --oneline -1 b136468a0024ea90c1259767c732eed12ce6edba git log --oneline -2 8c701fa6e38c43dba75282e4d919298a5cfc5b05 --reverse git log --oneline -5 9dcd71c863a6f6476378d076d3e9189c854d49fd --reverse
And this is the hotfix, planned for 6.2 (unwrapped): https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/com...
Regards, Diederik
On Wed, Dec 28, 2022 at 12:11:40PM +0100, Diederik de Haas wrote:
On Wednesday, 28 December 2022 11:41:40 CET Greg KH wrote:
All those patches have been merged into Linus' tree for 6.2 and there's a hotfix planned to be submitted for 6.2 here: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/ commit/?h=v6.2-armsoc/dtsfixes&id=53e8e1e6e9c1653095211a8edf17912f2374bb03
Wouldn't it make more sense to queue the whole patch set for 6.1? Or (at least) the whole crypto rockchip part as mentioned here: https://lore.kernel.org/all/Y5mGGrBJaDL6mnQJ@gondor.apana.org.au/ under the "Corentin Labbe (32):" label?
Please provide us a list of the specific git commits and in the order in which you wish to see them applied and we will be glad to review them.
Looking at random links (that are wrapped and not able to be easily used) is not going to work well.
These are the commits from Linus' tree (in the correct order):
https://git.kernel.org/linus/299c481fa5c121f892420d97f1123a853b7f1079 https://git.kernel.org/linus/8ccd9c8cd1d1618f5e073c86ffcfe15f292eefe6 https://git.kernel.org/linus/c50ef1411c8cbad0c7db100c477126076b6e3348 https://git.kernel.org/linus/6d11c9387865723fd779be00ae37a4588e60133d https://git.kernel.org/linus/87e356c4966444866186f68f05832fdcc0f351a3 https://git.kernel.org/linus/68ef8af09a1a912a5ed2cfaa4cca7606f52cef90 https://git.kernel.org/linus/816600485cb597b3ff7d6806a95a78512839f775 https://git.kernel.org/linus/d6b23ccef82816050c2fd458c9dabfa0e0af09b9 https://git.kernel.org/linus/bb3c7b73363c9a149b12b74c44ae94b73a8fddf8 https://git.kernel.org/linus/57d67c6e8219b2a034c16d6149e30fb40fd39935 https://git.kernel.org/linus/6d55c4a206d29006c733b5083ba5da8391abbdbd https://git.kernel.org/linus/48d904d428b68080abd9161148ca2ab1331124a4 https://git.kernel.org/linus/a216be3964c15661579005012b1f0d7d20a1f265 https://git.kernel.org/linus/6f61192549d0214f8d9d1e1d3152e450658ed1e9 https://git.kernel.org/linus/3a6fd464f48ad35d8cf15d81fd92094132dc862a https://git.kernel.org/linus/e803188400d32d28ecfbef0878c289e3c7026723 https://git.kernel.org/linus/37bc22159c456ad43fb852fc6ed60f4081df25df https://git.kernel.org/linus/456698746b40008eb0924eb7e9ec908330948b2d https://git.kernel.org/linus/e65e90101329de0fe304e2df057f68c5f0fa4748 https://git.kernel.org/linus/a7fa0644dd0b91fab97398de7ea4672a6526261f https://git.kernel.org/linus/2e3b149578c30275db9c3501c1d9dec36d16622a https://git.kernel.org/linus/c018c7a9dd198ce965ca4d10c7b083849bc533be https://git.kernel.org/linus/ea389be9857721252367fd2cf81bc8068e060693 https://git.kernel.org/linus/81aaf680e85207d6521b250b2a80ba7c91cc9cbe https://git.kernel.org/linus/d1b5749687618d969c0be6428174a18a7e94ebd2 https://git.kernel.org/linus/b136468a0024ea90c1259767c732eed12ce6edba https://git.kernel.org/linus/d1152bc533c941f7e267bf53d344cee510ea2808 https://git.kernel.org/linus/8c701fa6e38c43dba75282e4d919298a5cfc5b05 https://git.kernel.org/linus/2d3c756adcd7a7ee15b6a55cf01b363e3f134e79 https://git.kernel.org/linus/e220e6719438f7a99fe0a73e6e126481380202fa https://git.kernel.org/linus/0d31b14c9e4178a129a1aa5e491e4da1489c07de https://git.kernel.org/linus/c5a1e104c35e5134b6048f1e03960a6ac9c42935 https://git.kernel.org/linus/9dcd71c863a6f6476378d076d3e9189c854d49fd
That's a lot, I'll look at them in a week or so after catching up with the rest of the stable queue.
Any reason why you all didn't properly mark these for the stable tree beforehand?
These commands will show them too: git log --oneline -25 d1b5749687618d969c0be6428174a18a7e94ebd2 --reverse git log --oneline -1 b136468a0024ea90c1259767c732eed12ce6edba git log --oneline -2 8c701fa6e38c43dba75282e4d919298a5cfc5b05 --reverse git log --oneline -5 9dcd71c863a6f6476378d076d3e9189c854d49fd --reverse
And this is the hotfix, planned for 6.2 (unwrapped): https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/com...
fix for what? When will it be sent to Linus?
thanks,
greg k-h
On Wednesday, 28 December 2022 14:06:03 CET Greg KH wrote:
These commands will show them too: git log --oneline -25 d1b5749687618d969c0be6428174a18a7e94ebd2 --reverse git log --oneline -1 b136468a0024ea90c1259767c732eed12ce6edba git log --oneline -2 8c701fa6e38c43dba75282e4d919298a5cfc5b05 --reverse git log --oneline -5 9dcd71c863a6f6476378d076d3e9189c854d49fd --reverse
That's a lot, I'll look at them in a week or so after catching up with the rest of the stable queue.
Ok.
Any reason why you all didn't properly mark these for the stable tree beforehand?
Insofar as this was (also) directed at me: I don't know how this works (yet).
I'm an interested 'bystander' who is interested in kernel 6.1 as that'll likely be Debian Bookworm's kernel and rockchip/Pine64 devices.
As such I regularly look at the (6.1) queue and found those rockchip crypto patches. I also tested this whole patch set to see whether it does what it claimed; which it does.
And this is the hotfix, planned for 6.2 (unwrapped): https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/c ommit?id=53e8e1e6e9c1653095211a8edf17912f2374bb03
fix for what?
Rob Herring noted a mismatch between the dt-bindings of the "reset-names" property and the implementation in rk3399.dtsi in commit 8c701fa6e38c here: https://lore.kernel.org/all/CAL_JsqJkHR+iccEf=5SU40Qq+cQpGZRq26TLzec-_Nr-Buu... ("lave" -> "slave" and "crypto" -> "crypto-rst")
I may have used the word 'hotfix' incorrectly.
When will it be sent to Linus?
I don't know, but I've seen several "Merge tag 'vX.Y-rockchip-dtsfixes' ..." commits by Arnd Bergmann around rc6 or rc7 in the past.
On Wed, Dec 28, 2022 at 02:06:03PM +0100, Greg KH wrote:
On Wed, Dec 28, 2022 at 12:11:40PM +0100, Diederik de Haas wrote:
On Wednesday, 28 December 2022 11:41:40 CET Greg KH wrote:
All those patches have been merged into Linus' tree for 6.2 and there's a hotfix planned to be submitted for 6.2 here: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/ commit/?h=v6.2-armsoc/dtsfixes&id=53e8e1e6e9c1653095211a8edf17912f2374bb03
Wouldn't it make more sense to queue the whole patch set for 6.1? Or (at least) the whole crypto rockchip part as mentioned here: https://lore.kernel.org/all/Y5mGGrBJaDL6mnQJ@gondor.apana.org.au/ under the "Corentin Labbe (32):" label?
Please provide us a list of the specific git commits and in the order in which you wish to see them applied and we will be glad to review them.
Looking at random links (that are wrapped and not able to be easily used) is not going to work well.
These are the commits from Linus' tree (in the correct order):
https://git.kernel.org/linus/299c481fa5c121f892420d97f1123a853b7f1079 https://git.kernel.org/linus/8ccd9c8cd1d1618f5e073c86ffcfe15f292eefe6 https://git.kernel.org/linus/c50ef1411c8cbad0c7db100c477126076b6e3348 https://git.kernel.org/linus/6d11c9387865723fd779be00ae37a4588e60133d https://git.kernel.org/linus/87e356c4966444866186f68f05832fdcc0f351a3 https://git.kernel.org/linus/68ef8af09a1a912a5ed2cfaa4cca7606f52cef90 https://git.kernel.org/linus/816600485cb597b3ff7d6806a95a78512839f775 https://git.kernel.org/linus/d6b23ccef82816050c2fd458c9dabfa0e0af09b9 https://git.kernel.org/linus/bb3c7b73363c9a149b12b74c44ae94b73a8fddf8 https://git.kernel.org/linus/57d67c6e8219b2a034c16d6149e30fb40fd39935 https://git.kernel.org/linus/6d55c4a206d29006c733b5083ba5da8391abbdbd https://git.kernel.org/linus/48d904d428b68080abd9161148ca2ab1331124a4 https://git.kernel.org/linus/a216be3964c15661579005012b1f0d7d20a1f265 https://git.kernel.org/linus/6f61192549d0214f8d9d1e1d3152e450658ed1e9 https://git.kernel.org/linus/3a6fd464f48ad35d8cf15d81fd92094132dc862a https://git.kernel.org/linus/e803188400d32d28ecfbef0878c289e3c7026723 https://git.kernel.org/linus/37bc22159c456ad43fb852fc6ed60f4081df25df https://git.kernel.org/linus/456698746b40008eb0924eb7e9ec908330948b2d https://git.kernel.org/linus/e65e90101329de0fe304e2df057f68c5f0fa4748 https://git.kernel.org/linus/a7fa0644dd0b91fab97398de7ea4672a6526261f https://git.kernel.org/linus/2e3b149578c30275db9c3501c1d9dec36d16622a https://git.kernel.org/linus/c018c7a9dd198ce965ca4d10c7b083849bc533be https://git.kernel.org/linus/ea389be9857721252367fd2cf81bc8068e060693 https://git.kernel.org/linus/81aaf680e85207d6521b250b2a80ba7c91cc9cbe https://git.kernel.org/linus/d1b5749687618d969c0be6428174a18a7e94ebd2 https://git.kernel.org/linus/b136468a0024ea90c1259767c732eed12ce6edba https://git.kernel.org/linus/d1152bc533c941f7e267bf53d344cee510ea2808 https://git.kernel.org/linus/8c701fa6e38c43dba75282e4d919298a5cfc5b05 https://git.kernel.org/linus/2d3c756adcd7a7ee15b6a55cf01b363e3f134e79 https://git.kernel.org/linus/e220e6719438f7a99fe0a73e6e126481380202fa https://git.kernel.org/linus/0d31b14c9e4178a129a1aa5e491e4da1489c07de https://git.kernel.org/linus/c5a1e104c35e5134b6048f1e03960a6ac9c42935 https://git.kernel.org/linus/9dcd71c863a6f6476378d076d3e9189c854d49fd
That's a lot, I'll look at them in a week or so after catching up with the rest of the stable queue.
I looked at this now, and some of the more obvious "fixes" are already in the 6.1.y tree (and older kernels).
So this series does not apply as-is, and it seems like there is a lot of extra stuff in this series that is not needed (like a MAINTAINER entry?)
Can you provide a patch series, that has been tested and with your signed-off-by for whatever you feel still needs to be applied to the 6.1.y tree to resolve any existing bugs in 6.1.y for this driver (note, that does NOT mean that you can add new functionality that was never there...)
thanks,
greg k-h
On Friday, 3 February 2023 10:33:16 CET Greg KH wrote:
That's a lot, I'll look at them in a week or so after catching up with the rest of the stable queue.
I looked at this now, and some of the more obvious "fixes" are already in the 6.1.y tree (and older kernels).
So this series does not apply as-is, and it seems like there is a lot of extra stuff in this series that is not needed (like a MAINTAINER entry?)
Can you provide a patch series, that has been tested and with your signed-off-by for whatever you feel still needs to be applied to the 6.1.y tree to resolve any existing bugs in 6.1.y for this driver (note, that does NOT mean that you can add new functionality that was never there...)
I don't feel confident (enough) that I could 'pull that off', especially since it would effectively be a new patch set, which would likely not get the same level of review/testing as the original one got. It would also (effectively) add new functionality as the crypto engine (at least on rk3328 and rk3399) did not work previously as among others they don't have the crypto node in the dts files.
So I think it's better that the (new) patch set does not get applied to the 6.1 Stable release (series).
The reason I raised my initial question was because I did test (and provided my Tested-By to) the patch set as a whole, not any single patch in isolation.
Regards, Diederik
linux-stable-mirror@lists.linaro.org
-
Diederik de Haas -
Greg KH