Issue happens on 4.16.5 as well.   Thanks.

Best John

Gesendet: Sonntag, 29. April 2018 um 07:27 Uhr Von: "Greg KH" gregkh@linuxfoundation.org An: "John Smith" john-s-84@gmx.net Cc: stable@vger.kernel.org Betreff: Re: [PATCH 3.18 18/52] HID: i2c-hid: fix size check and type usage On Sat, Apr 28, 2018 at 11:09:00PM +0200, John Smith wrote:

...

• if (ret_size > size) {

• if ((ret_size > size) || (ret_size <= 2)) {

dev_err(&ihid->client->dev, "%s: incomplete report (%d/%d)\n", __func__, size, ret_size); return;

This change spams in the dmesg output. Could you please undo this change? Or

• if ((ret_size > size) || (ret_size <= 2)) {

• if ((ret_size > size) || (ret_size < 2)) {

$ dmesg

[ 1781.266353] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2) [ 1781.273898] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2) [ 1781.281464] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2) [ 1781.289064] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2) [ 1781.296607] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2) [ 1781.304131] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2) [ 1781.311751] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2) [ 1781.319315] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2) [ 1781.326882] i2c_hid i2c-ALP0017:00: i2c_hid_get_input: incomplete report (30/2)

Does this happen in newer kernels as well? Is there a patch there that I need to just backport to 3.18.y to remove this "noise"?

thanks,

greg k-h