Commit d2aaf1996504 ("ACPI: resource: Add DMI quirks for ASUS Vivobook E1504GA and E1504GAB") does exactly what the subject says, adding DMI matches for both the E1504GA and E1504GAB. But DMI_MATCH() does a substring match, so checking for E1504GA will also match E1504GAB.
Drop the unnecessary E1504GAB entry since that is covered already by the E1504GA entry.
Fixes: d2aaf1996504 ("ACPI: resource: Add DMI quirks for ASUS Vivobook E1504GA and E1504GAB") Cc: Ben Mayo benny1091@gmail.com Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com --- drivers/acpi/resource.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 8a4726e2eb69..1ff251fd1901 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -511,19 +511,12 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { }, }, { - /* Asus Vivobook E1504GA */ + /* Asus Vivobook E1504GA* */ .matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), DMI_MATCH(DMI_BOARD_NAME, "E1504GA"), }, }, - { - /* Asus Vivobook E1504GAB */ - .matches = { - DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), - DMI_MATCH(DMI_BOARD_NAME, "E1504GAB"), - }, - }, { /* Asus Vivobook Pro N6506MV */ .matches = {
Like other Asus Vivobooks, the Asus Vivobook Go E1404GA has a DSDT describing IRQ 1 as ActiveLow, while the kernel overrides to Edge_High.
$ sudo dmesg | grep DMI:.*BIOS [ 0.000000] DMI: ASUSTeK COMPUTER INC. Vivobook Go E1404GA_E1404GA/E1404GA, BIOS E1404GA.302 08/23/2023 $ sudo cp /sys/firmware/acpi/tables/DSDT dsdt.dat $ iasl -d dsdt.dat $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1 IRQ (Level, ActiveLow, Exclusive, ) {1}
There already is an entry in the irq1_level_low_skip_override[] DMI match table for the "E1404GAB", change this to match on "E1404GA" to cover the E1404GA model as well (DMI_MATCH() does a substring match).
Reported-by: Paul Menzel pmenzel@molgen.mpg.de Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224 Cc: Tamim Khan tamim@fusetak.com Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com --- Note this patch replaces Paul Menzel's patch which added a new entry for the "E1404GA", instead of loosening the "E1404GAB" match: https://lore.kernel.org/linux-acpi/20240911081612.3931-1-pmenzel@molgen.mpg.... --- drivers/acpi/resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 1ff251fd1901..dfe108e2ccde 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -504,10 +504,10 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { }, }, { - /* Asus Vivobook Go E1404GAB */ + /* Asus Vivobook Go E1404GA* */ .matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), - DMI_MATCH(DMI_BOARD_NAME, "E1404GAB"), + DMI_MATCH(DMI_BOARD_NAME, "E1404GA"), }, }, {
Dear Hans,
Thank you for your patch.
Am 27.09.24 um 16:16 schrieb Hans de Goede:
Like other Asus Vivobooks, the Asus Vivobook Go E1404GA has a DSDT describing IRQ 1 as ActiveLow, while the kernel overrides to Edge_High.
$ sudo dmesg | grep DMI:.*BIOS [ 0.000000] DMI: ASUSTeK COMPUTER INC. Vivobook Go E1404GA_E1404GA/E1404GA, BIOS E1404GA.302 08/23/2023 $ sudo cp /sys/firmware/acpi/tables/DSDT dsdt.dat $ iasl -d dsdt.dat $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1 IRQ (Level, ActiveLow, Exclusive, ) {1}There already is an entry in the irq1_level_low_skip_override[] DMI match table for the "E1404GAB", change this to match on "E1404GA" to cover the E1404GA model as well (DMI_MATCH() does a substring match).
Ah, good to know. Thank you for fixing it.
Reported-by: Paul Menzel pmenzel@molgen.mpg.de Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224 Cc: Tamim Khan tamim@fusetak.com Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com
Note this patch replaces Paul Menzel's patch which added a new entry for the "E1404GA", instead of loosening the "E1404GAB" match: https://lore.kernel.org/linux-acpi/20240911081612.3931-1-pmenzel@molgen.mpg....
drivers/acpi/resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 1ff251fd1901..dfe108e2ccde 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -504,10 +504,10 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { }, }, {
/* Asus Vivobook Go E1404GAB */
/* Asus Vivobook Go E1404GA* */
I guess people are going to grep for the model, if something does not work, so maybe the known ones should listed. I know it’s not optimal, as the comments are very likely be incomplete, but it’s better than than not having it listed, in my opinion.
.matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
DMI_MATCH(DMI_BOARD_NAME, "E1404GAB"),
DMI_MATCH(DMI_BOARD_NAME, "E1404GA"),
Kind regards,
Paul
Hi,
On 30-Sep-24 12:42 PM, Paul Menzel wrote:
Dear Hans,
Thank you for your patch.
Am 27.09.24 um 16:16 schrieb Hans de Goede:
Like other Asus Vivobooks, the Asus Vivobook Go E1404GA has a DSDT describing IRQ 1 as ActiveLow, while the kernel overrides to Edge_High.
$ sudo dmesg | grep DMI:.*BIOS [ 0.000000] DMI: ASUSTeK COMPUTER INC. Vivobook Go E1404GA_E1404GA/E1404GA, BIOS E1404GA.302 08/23/2023 $ sudo cp /sys/firmware/acpi/tables/DSDT dsdt.dat $ iasl -d dsdt.dat $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1 IRQ (Level, ActiveLow, Exclusive, ) {1}
There already is an entry in the irq1_level_low_skip_override[] DMI match table for the "E1404GAB", change this to match on "E1404GA" to cover the E1404GA model as well (DMI_MATCH() does a substring match).
Ah, good to know. Thank you for fixing it.
Reported-by: Paul Menzel pmenzel@molgen.mpg.de Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224 Cc: Tamim Khan tamim@fusetak.com Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com
Note this patch replaces Paul Menzel's patch which added a new entry for the "E1404GA", instead of loosening the "E1404GAB" match: https://lore.kernel.org/linux-acpi/20240911081612.3931-1-pmenzel@molgen.mpg....
drivers/acpi/resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 1ff251fd1901..dfe108e2ccde 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -504,10 +504,10 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { }, }, { - /* Asus Vivobook Go E1404GAB */ + /* Asus Vivobook Go E1404GA* */
I guess people are going to grep for the model, if something does not work, so maybe the known ones should listed. I know it’s not optimal, as the comments are very likely be incomplete, but it’s better than than not having it listed, in my opinion.
That is a valid point, OTOH I don't think we want to take patches later just to update the comment if more models show up.
I guess we could change the comment to:
/* Asus Vivobook Go E1404GA / E1404GAB */
Rafael any preference from you here ? (1)
Regards,
Hans
1) Other then coming up with a better fix which does not require this quirks at all ...
.matches = { DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), - DMI_MATCH(DMI_BOARD_NAME, "E1404GAB"), + DMI_MATCH(DMI_BOARD_NAME, "E1404GA"), }, }, {
Kind regards,
Paul
On Mon, Sep 30, 2024 at 12:56 PM Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 30-Sep-24 12:42 PM, Paul Menzel wrote:
Dear Hans,
Thank you for your patch.
Am 27.09.24 um 16:16 schrieb Hans de Goede:
Like other Asus Vivobooks, the Asus Vivobook Go E1404GA has a DSDT describing IRQ 1 as ActiveLow, while the kernel overrides to Edge_High.
$ sudo dmesg | grep DMI:.*BIOS [ 0.000000] DMI: ASUSTeK COMPUTER INC. Vivobook Go E1404GA_E1404GA/E1404GA, BIOS E1404GA.302 08/23/2023 $ sudo cp /sys/firmware/acpi/tables/DSDT dsdt.dat $ iasl -d dsdt.dat $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1 IRQ (Level, ActiveLow, Exclusive, ) {1}There already is an entry in the irq1_level_low_skip_override[] DMI match table for the "E1404GAB", change this to match on "E1404GA" to cover the E1404GA model as well (DMI_MATCH() does a substring match).
Ah, good to know. Thank you for fixing it.
Reported-by: Paul Menzel pmenzel@molgen.mpg.de Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224 Cc: Tamim Khan tamim@fusetak.com Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com
Note this patch replaces Paul Menzel's patch which added a new entry for the "E1404GA", instead of loosening the "E1404GAB" match: https://lore.kernel.org/linux-acpi/20240911081612.3931-1-pmenzel@molgen.mpg....
drivers/acpi/resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 1ff251fd1901..dfe108e2ccde 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -504,10 +504,10 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { }, }, {
/* Asus Vivobook Go E1404GAB */
/* Asus Vivobook Go E1404GA* */I guess people are going to grep for the model, if something does not work, so maybe the known ones should listed. I know it’s not optimal, as the comments are very likely be incomplete, but it’s better than than not having it listed, in my opinion.
That is a valid point, OTOH I don't think we want to take patches later just to update the comment if more models show up.
I guess we could change the comment to:
/* Asus Vivobook Go E1404GA / E1404GAB */Rafael any preference from you here ? (1)
Not really.
Regards,
Hans
- Other then coming up with a better fix which does not require this quirks at all ...
Yeah.
Hi,
On 30-Sep-24 2:18 PM, Rafael J. Wysocki wrote:
On Mon, Sep 30, 2024 at 12:56 PM Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 30-Sep-24 12:42 PM, Paul Menzel wrote:
Dear Hans,
Thank you for your patch.
Am 27.09.24 um 16:16 schrieb Hans de Goede:
Like other Asus Vivobooks, the Asus Vivobook Go E1404GA has a DSDT describing IRQ 1 as ActiveLow, while the kernel overrides to Edge_High.
$ sudo dmesg | grep DMI:.*BIOS [ 0.000000] DMI: ASUSTeK COMPUTER INC. Vivobook Go E1404GA_E1404GA/E1404GA, BIOS E1404GA.302 08/23/2023 $ sudo cp /sys/firmware/acpi/tables/DSDT dsdt.dat $ iasl -d dsdt.dat $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1 IRQ (Level, ActiveLow, Exclusive, ) {1}There already is an entry in the irq1_level_low_skip_override[] DMI match table for the "E1404GAB", change this to match on "E1404GA" to cover the E1404GA model as well (DMI_MATCH() does a substring match).
Ah, good to know. Thank you for fixing it.
Reported-by: Paul Menzel pmenzel@molgen.mpg.de Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224 Cc: Tamim Khan tamim@fusetak.com Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com
Note this patch replaces Paul Menzel's patch which added a new entry for the "E1404GA", instead of loosening the "E1404GAB" match: https://lore.kernel.org/linux-acpi/20240911081612.3931-1-pmenzel@molgen.mpg....
drivers/acpi/resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 1ff251fd1901..dfe108e2ccde 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -504,10 +504,10 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { }, }, {
/* Asus Vivobook Go E1404GAB */
/* Asus Vivobook Go E1404GA* */I guess people are going to grep for the model, if something does not work, so maybe the known ones should listed. I know it’s not optimal, as the comments are very likely be incomplete, but it’s better than than not having it listed, in my opinion.
That is a valid point, OTOH I don't think we want to take patches later just to update the comment if more models show up.
I guess we could change the comment to:
/* Asus Vivobook Go E1404GA / E1404GAB */Rafael any preference from you here ? (1)
Not really.
Ok, then my vote goes to keeping this as is. So if you're happy with this series please merge it as is.
Regards,
Hans
On Mon, Sep 30, 2024 at 2:20 PM Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 30-Sep-24 2:18 PM, Rafael J. Wysocki wrote:
On Mon, Sep 30, 2024 at 12:56 PM Hans de Goede hdegoede@redhat.com wrote:
Hi,
On 30-Sep-24 12:42 PM, Paul Menzel wrote:
Dear Hans,
Thank you for your patch.
Am 27.09.24 um 16:16 schrieb Hans de Goede:
Like other Asus Vivobooks, the Asus Vivobook Go E1404GA has a DSDT describing IRQ 1 as ActiveLow, while the kernel overrides to Edge_High.
$ sudo dmesg | grep DMI:.*BIOS [ 0.000000] DMI: ASUSTeK COMPUTER INC. Vivobook Go E1404GA_E1404GA/E1404GA, BIOS E1404GA.302 08/23/2023 $ sudo cp /sys/firmware/acpi/tables/DSDT dsdt.dat $ iasl -d dsdt.dat $ grep -A 30 PS2K dsdt.dsl | grep IRQ -A 1 IRQ (Level, ActiveLow, Exclusive, ) {1}There already is an entry in the irq1_level_low_skip_override[] DMI match table for the "E1404GAB", change this to match on "E1404GA" to cover the E1404GA model as well (DMI_MATCH() does a substring match).
Ah, good to know. Thank you for fixing it.
Reported-by: Paul Menzel pmenzel@molgen.mpg.de Closes: https://bugzilla.kernel.org/show_bug.cgi?id=219224 Cc: Tamim Khan tamim@fusetak.com Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com
Note this patch replaces Paul Menzel's patch which added a new entry for the "E1404GA", instead of loosening the "E1404GAB" match: https://lore.kernel.org/linux-acpi/20240911081612.3931-1-pmenzel@molgen.mpg....
drivers/acpi/resource.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 1ff251fd1901..dfe108e2ccde 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -504,10 +504,10 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { }, }, {
/* Asus Vivobook Go E1404GAB */
/* Asus Vivobook Go E1404GA* */I guess people are going to grep for the model, if something does not work, so maybe the known ones should listed. I know it’s not optimal, as the comments are very likely be incomplete, but it’s better than than not having it listed, in my opinion.
That is a valid point, OTOH I don't think we want to take patches later just to update the comment if more models show up.
I guess we could change the comment to:
/* Asus Vivobook Go E1404GA / E1404GAB */Rafael any preference from you here ? (1)
Not really.
Ok, then my vote goes to keeping this as is. So if you're happy with this series please merge it as is.
Now queued up as 6.12-rc2 material, thanks!
Like other Asus Vivobook models the X1704VAP has its keybopard IRQ (1) described as ActiveLow in the DSDT, which the kernel overrides to EdgeHigh which breaks the keyboard.
Add the X1704VAP to the irq1_level_low_skip_override[] quirk table to fix this.
Reported-by: Lamome Julien julien.lamome@wanadoo.fr Closes: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1078696 Closes: https://lore.kernel.org/all/1226760b-4699-4529-bf57-6423938157a3@wanadoo.fr/ Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com --- drivers/acpi/resource.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index dfe108e2ccde..8e672790ac51 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -440,6 +440,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { DMI_MATCH(DMI_BOARD_NAME, "S5602ZA"), }, }, + { + /* Asus Vivobook X1704VAP */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, "X1704VAP"), + }, + }, { /* Asus ExpertBook B1402CBA */ .matches = {
Like other Asus ExpertBook models the B2502CVA has its keybopard IRQ (1) described as ActiveLow in the DSDT, which the kernel overrides to EdgeHigh which breaks the keyboard.
Add the B2502CVA to the irq1_level_low_skip_override[] quirk table to fix this.
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217760 Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hdegoede@redhat.com --- drivers/acpi/resource.c | 7 +++++++ 1 file changed, 7 insertions(+)
diff --git a/drivers/acpi/resource.c b/drivers/acpi/resource.c index 8e672790ac51..3d74ebe9dbd8 100644 --- a/drivers/acpi/resource.c +++ b/drivers/acpi/resource.c @@ -510,6 +510,13 @@ static const struct dmi_system_id irq1_level_low_skip_override[] = { DMI_MATCH(DMI_BOARD_NAME, "B2502FBA"), }, }, + { + /* Asus ExpertBook B2502CVA */ + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."), + DMI_MATCH(DMI_BOARD_NAME, "B2502CVA"), + }, + }, { /* Asus Vivobook Go E1404GA* */ .matches = {
linux-stable-mirror@lists.linaro.org
-
Hans de Goede -
Paul Menzel -
Rafael J. Wysocki