Code expects array only with 2 items which should be checked. But also item checking is not working as it should likely because of incorrect items description.
Fixes: d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings to json-schema") Signed-off-by: Michal Simek michal.simek@amd.com Cc: stable@vger.kernel.org ---
Changes in v2: - Remove maxItems properties which are not needed - Add stable ML to CC
.../devicetree/bindings/serial/rs485.yaml | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml index 9418fd66a8e9..9665de41762e 100644 --- a/Documentation/devicetree/bindings/serial/rs485.yaml +++ b/Documentation/devicetree/bindings/serial/rs485.yaml @@ -18,16 +18,15 @@ properties: description: prop-encoded-array <a b> $ref: /schemas/types.yaml#/definitions/uint32-array items: - items: - - description: Delay between rts signal and beginning of data sent in - milliseconds. It corresponds to the delay before sending data. - default: 0 - maximum: 100 - - description: Delay between end of data sent and rts signal in milliseconds. - It corresponds to the delay after sending data and actual release - of the line. - default: 0 - maximum: 100 + - description: Delay between rts signal and beginning of data sent in + milliseconds. It corresponds to the delay before sending data. + default: 0 + maximum: 50 + - description: Delay between end of data sent and rts signal in milliseconds. + It corresponds to the delay after sending data and actual release + of the line. + default: 0 + maximum: 100
rs485-rts-active-high: description: drive RTS high when sending (this is the default).
On Fri, Sep 13, 2024 at 12:55:23PM +0200, Michal Simek wrote:
Code expects array only with 2 items which should be checked. But also item checking is not working as it should likely because of incorrect items description.
Fixes: d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings to json-schema") Signed-off-by: Michal Simek michal.simek@amd.com Cc: stable@vger.kernel.org
Changes in v2:
- Remove maxItems properties which are not needed
- Add stable ML to CC
.../devicetree/bindings/serial/rs485.yaml | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml index 9418fd66a8e9..9665de41762e 100644 --- a/Documentation/devicetree/bindings/serial/rs485.yaml +++ b/Documentation/devicetree/bindings/serial/rs485.yaml @@ -18,16 +18,15 @@ properties: description: prop-encoded-array <a b> $ref: /schemas/types.yaml#/definitions/uint32-array items:
items:- description: Delay between rts signal and beginning of data sent inmilliseconds. It corresponds to the delay before sending data.default: 0maximum: 100- description: Delay between end of data sent and rts signal in milliseconds.It corresponds to the delay after sending data and actual releaseof the line.default: 0maximum: 100
- description: Delay between rts signal and beginning of data sent inmilliseconds. It corresponds to the delay before sending data.default: 0maximum: 50
I would expect to see some mention in the commit message as to why the maximum has changed from 100 to 50 milliseconds.
- description: Delay between end of data sent and rts signal in milliseconds.It corresponds to the delay after sending data and actual releaseof the line.default: 0maximum: 100rs485-rts-active-high: description: drive RTS high when sending (this is the default). -- 2.43.0
On 9/13/24 19:24, Conor Dooley wrote:
On Fri, Sep 13, 2024 at 12:55:23PM +0200, Michal Simek wrote:
Code expects array only with 2 items which should be checked. But also item checking is not working as it should likely because of incorrect items description.
Fixes: d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings to json-schema") Signed-off-by: Michal Simek michal.simek@amd.com Cc: stable@vger.kernel.org
Changes in v2:
Remove maxItems properties which are not needed
Add stable ML to CC
.../devicetree/bindings/serial/rs485.yaml | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-)
diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml index 9418fd66a8e9..9665de41762e 100644 --- a/Documentation/devicetree/bindings/serial/rs485.yaml +++ b/Documentation/devicetree/bindings/serial/rs485.yaml @@ -18,16 +18,15 @@ properties: description: prop-encoded-array <a b> $ref: /schemas/types.yaml#/definitions/uint32-array items:
items:- description: Delay between rts signal and beginning of data sent inmilliseconds. It corresponds to the delay before sending data.default: 0maximum: 100- description: Delay between end of data sent and rts signal in milliseconds.It corresponds to the delay after sending data and actual releaseof the line.default: 0maximum: 100
- description: Delay between rts signal and beginning of data sent inmilliseconds. It corresponds to the delay before sending data.default: 0maximum: 50I would expect to see some mention in the commit message as to why the maximum has changed from 100 to 50 milliseconds.
grrr. I was playing with setting up different values and check if checking is working. That should be still 100. No reason for value change. Will fix in v3.
M
linux-stable-mirror@lists.linaro.org
-
Conor Dooley -
Michal Simek