On Thu, May 30, 2024 at 11:39:55AM +0100, Daniel Golle wrote:

Hi stable team,

...

...

On Mon, 15 Jan 2024 12:43:38 +0000 "Russell King (Oracle)" rmk+kernel@armlinux.org.uk wrote:

...

The referenced commit moved the setting of the Autoneg and pause bits early in sfp_parse_support(). However, we check whether the modes are empty before using the bitrate to set some modes. Setting these bits so early causes that test to always be false, preventing this working, and thus some modules that used to work no longer do.

Move them just before the call to the quirk.

Fixes: 8110633db49d ("net: sfp-bus: allow SFP quirks to override Autoneg and pause bits") Signed-off-by: Russell King (Oracle) rmk+kernel@armlinux.org.uk

please apply this patch also to Linux stable down to v6.4 which are affected by problems introduced by commit 8110633db49d ("net: sfp-bus: allow SFP quirks to override Autoneg and pause bits").

The fix has been applied to net tree as commit 97eb5d51b4a5 ("net: sfp-bus: fix SFP mode detect from bitrate") but never picked for older kernel versions affected as well.

Ok, applied to 6.6 only.

greg k-h