On Mon, Jan 8, 2018 at 2:44 PM, gregkh gregkh@linuxfoundation.org wrote:

On Mon, Jan 08, 2018 at 02:16:25PM +0100, Arnd Bergmann wrote:

...

On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot bot@kernelci.org wrote:

...

stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b) Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.110-18-g... Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.110-18-g5da3d9af3a4b Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Built: 4 unique architectures

Build Failures Detected:

arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05) cm_x300_defconfig FAIL mvebu_v7_defconfig FAIL pxa3xx_defconfig FAIL raumfeld_defconfig FAIL

mvebu_v7_defconfig (arm) — FAIL, 2 errors, 0 warnings, 0 section mismatches

Errors: drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here

Hi Greg,

Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was apparently backported in error, it looks like it should just be dropped here in 4.4.y.

The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-specific ECC BCH support")', that commit was merged into v4.14, so backporting the fix further is probably not appropriate for 4.9 or earlier kernels either.

$ git describe --contains 43bcfd2bb24a v3.14-rc1~65^2~127

That is why I backported these patches this far.

I'll drop the patch now, but the Fixes line is the problem here :)

I think my mistake in the report was misreading v3.14 as v4.14. That means we still need the fix, just as Boris explained, it just needs to be done differently for older kernels.

Arnd

On Mon, Jan 08, 2018 at 04:30:29PM +0100, Boris Brezillon wrote:

On Mon, 8 Jan 2018 15:01:38 +0100 Arnd Bergmann arnd@arndb.de wrote:

...

On Mon, Jan 8, 2018 at 2:44 PM, gregkh gregkh@linuxfoundation.org wrote:

...

On Mon, Jan 08, 2018 at 02:16:25PM +0100, Arnd Bergmann wrote:

...

On Mon, Jan 8, 2018 at 12:25 PM, kernelci.org bot bot@kernelci.org wrote:

...

stable-rc/linux-4.4.y build: 178 builds: 4 failed, 174 passed, 8 errors (v4.4.110-18-g5da3d9af3a4b) Full Build Summary: https://kernelci.org/build/stable-rc/branch/linux-4.4.y/kernel/v4.4.110-18-g... Tree: stable-rc Branch: linux-4.4.y Git Describe: v4.4.110-18-g5da3d9af3a4b Git Commit: 5da3d9af3a4b90d3c5ab19f9ad1dbb7d237edcf9 Git URL: http://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git Built: 4 unique architectures

Build Failures Detected:

arm: gcc version 5.3.1 20160412 (Linaro GCC 5.3-2016.05) cm_x300_defconfig FAIL mvebu_v7_defconfig FAIL pxa3xx_defconfig FAIL raumfeld_defconfig FAIL

mvebu_v7_defconfig (arm) — FAIL, 2 errors, 0 warnings, 0 section mismatches

Errors: drivers/mtd/nand/pxa3xx_nand.c:918:2: error: duplicate case value drivers/mtd/nand/pxa3xx_nand.c:915:2: error: previously used here

Hi Greg,

Commit fee4380f368e ("mtd: nand: pxa3xx: Fix READOOB implementation") was apparently backported in error, it looks like it should just be dropped here in 4.4.y.

The commit lists 'Fixes: 43bcfd2bb24a ("mtd: nand: pxa3xx: Add driver-specific ECC BCH support")', that commit was merged into v4.14, so backporting the fix further is probably not appropriate for 4.9 or earlier kernels either.

$ git describe --contains 43bcfd2bb24a v3.14-rc1~65^2~127

That is why I backported these patches this far.

I'll drop the patch now, but the Fixes line is the problem here :)

I think my mistake in the report was misreading v3.14 as v4.14. That means we still need the fix, just as Boris explained, it just needs to be done differently for older kernels.

Hm, actually I was wrong with my Fixes tag, it seems the bug has been introduced by 'c2cdace755b5 ("mtd: nand: pxa3xx_nand: add support for partial chunks")', so the fix is not needed for pre-4.6 kernels.

oops, also dropped it from 4.9, so I put it back there.

thanks,

greg k-h