Hello,
On Mon, Jul 30, 2018 at 05:43:43PM +0200, Linus Walleij wrote:
On Fri, Jul 13, 2018 at 4:55 PM Dan Carpenter dan.carpenter@oracle.com wrote:
The info->groups[] array is allocated in imx1_pinctrl_parse_dt(). It has info->ngroups elements. Thus the > here should be >= to prevent reading one element beyond the end of the array.
Fixes: 30612cd90005 ("pinctrl: imx1 core driver") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
Patch applied.
I am not tagging for stable as it is debug code and does not affect end users.
Not sure this is a valid reason. Distro kernels usually enable debugfs. I'd say an out-of-bounds access that can only be triggered by root should still be fixed. I won't argue but added stable to the addressees of this mail to at least raise awareness.
Best regards Uwe
On Tue, Jul 31, 2018 at 10:52 AM Uwe Kleine-König u.kleine-koenig@pengutronix.de wrote:
On Mon, Jul 30, 2018 at 05:43:43PM +0200, Linus Walleij wrote:
On Fri, Jul 13, 2018 at 4:55 PM Dan Carpenter dan.carpenter@oracle.com wrote:
The info->groups[] array is allocated in imx1_pinctrl_parse_dt(). It has info->ngroups elements. Thus the > here should be >= to prevent reading one element beyond the end of the array.
Fixes: 30612cd90005 ("pinctrl: imx1 core driver") Signed-off-by: Dan Carpenter dan.carpenter@oracle.com
Patch applied.
I am not tagging for stable as it is debug code and does not affect end users.
Not sure this is a valid reason. Distro kernels usually enable debugfs. I'd say an out-of-bounds access that can only be triggered by root should still be fixed. I won't argue but added stable to the addressees of this mail to at least raise awareness.
I won't argue either, I will just tag it for stable. If it matters for my friends, it matters to me, so: stable it is.
Yours, Linus Walleij
linux-stable-mirror@lists.linaro.org
-
Linus Walleij -
Uwe Kleine-König