On 4/3/20 1:34 PM, Christian Brauner wrote:

On Fri, Apr 03, 2020 at 02:11:39PM +0200, Michael Kerrisk (man-pages) wrote:

...

Dmitry, Andrei,

Looking at the contents of the /proc/PID/ns/time_for_children symlink shows an anomaly:

$ ls -l /proc/self/ns/* |awk '{print $9, $10, $11}' ... /proc/self/ns/pid -> pid:[4026531836] /proc/self/ns/pid_for_children -> pid:[4026531836] /proc/self/ns/time -> time:[4026531834] /proc/self/ns/time_for_children -> time_for_children:[4026531834] /proc/self/ns/user -> user:[4026531837] ...

The reference for 'time_for_children' should be a 'time' namespace, just as the reference for 'pid_for_children' is a 'pid' namespace. In other words, I think the above time_for_children link should read:

/proc/self/ns/time_for_children -> time:[4026531834]

If you agree with this patch, then it should be marked for stable@vger.kernel.org.

Signed-off-by: Michael Kerrisk mtk.manpages@gmail.com

Yeah, that just seems like an oversight.

Acked-by: Christian Brauner christian.brauner@ubuntu.com

Thanks,

Reviewed-by: Dmitry Safonov dima@arista.com Fixes: 769071ac9f20 ("ns: Introduce Time Namespace") +Cc: stable # v5.6