On 22-02-27 14:53:27, Krzysztof Kozlowski wrote:

The driver_override field from platform driver should not be initialized from static memory (string literal) because the core later kfree() it, for example when driver_override is set via sysfs.

Use dedicated helper to set driver_override properly.

Fixes: 77d8f3068c63 ("clk: imx: scu: add two cells binding support") Cc: stable@vger.kernel.org Signed-off-by: Krzysztof Kozlowski krzysztof.kozlowski@canonical.com

---

drivers/clk/imx/clk-scu.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c index 083da31dc3ea..4b2268b7d0d0 100644 --- a/drivers/clk/imx/clk-scu.c +++ b/drivers/clk/imx/clk-scu.c @@ -683,7 +683,12 @@ struct clk_hw *imx_clk_scu_alloc_dev(const char *name, return ERR_PTR(ret); }

• pdev->driver_override = "imx-scu-clk";

• ret = driver_set_override(&pdev->dev, &pdev->driver_override,

• 		  "imx-scu-clk", strlen("imx-scu-clk"));
  

See my comment to patch 01/11.

I would like this to look like the following:

ret = driver_set_override(&pdev->dev, "imx-scu-clk");

• if (ret) {

• platform_device_put(pdev);
  

• return ERR_PTR(ret);
  

• }

ret = imx_clk_scu_attach_pd(&pdev->dev, rsrc_id); if (ret) -- 2.32.0