Stuart Hayhurst has found that both at bootup and fullscreen VA-API video is leading to black screens for around 1 second and kernel WARNING [1] traces when calling dmub_psr_enable() with Parade 08-01 TCON.
These symptoms all go away with PSR-SU disabled for this TCON, so disable it for now while DMUB traces [2] from the failure can be analyzed and the failure state properly root caused.
Cc: stable@vger.kernel.org Cc: Marc Rossi Marc.Rossi@amd.com Cc: Hamza Mahfooz Hamza.Mahfooz@amd.com Link: https://gitlab.freedesktop.org/drm/amd/uploads/a832dd515b571ee171b3e3b566e99... [1] Link: https://gitlab.freedesktop.org/drm/amd/uploads/8f13ff3b00963c833e23e68aa8116... [2] Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2645 Signed-off-by: Mario Limonciello mario.limonciello@amd.com --- --- drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c index e304e8435fb8..477289846a0a 100644 --- a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c +++ b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c @@ -841,6 +841,8 @@ bool is_psr_su_specific_panel(struct dc_link *link) isPSRSUSupported = false; else if (dpcd_caps->sink_dev_id_str[1] == 0x08 && dpcd_caps->sink_dev_id_str[0] == 0x03) isPSRSUSupported = false; + else if (dpcd_caps->sink_dev_id_str[1] == 0x08 && dpcd_caps->sink_dev_id_str[0] == 0x01) + isPSRSUSupported = false; else if (dpcd_caps->psr_info.force_psrsu_cap == 0x1) isPSRSUSupported = true; }
Hi, can this be considered again please? Still facing issues with the 660M in my Lenovo Yoga 7 14ARB7. This fixes the weird behaviour I have with black screens, back-traces and flickering.
[AMD Official Use Only - AMD Internal Distribution Only]
Hi Stuart,
Is this on a mainline 6.11.y or 6.12-rc3 kernel? Can you please open up a new issue with all the details? You can ping it back here.
Thanks,
-----Original Message----- From: Stuart Hayhurst stuart.a.hayhurst@gmail.com Sent: Sunday, October 13, 2024 16:31 To: Limonciello, Mario Mario.Limonciello@amd.com Cc: Mahfooz, Hamza Hamza.Mahfooz@amd.com; Rossi, Marc Marc.Rossi@amd.com; amd-gfx@lists.freedesktop.org; stable@vger.kernel.org Subject: Re: [PATCH] drm/amd/display: Disable PSR-SU on Parade 08-01 TCON too
Hi, can this be considered again please? Still facing issues with the 660M in my Lenovo Yoga 7 14ARB7. This fixes the weird behaviour I have with black screens, back-traces and flickering.
Is this on a mainline 6.11.y or 6.12-rc3 kernel? Can you please open up a new issue with all the details? You can ping it back here.
Currently a Debian 6.11.2 kernel, but I did reproduce it with a mainline 6.10 and earlier versions in the past.
Issue link: https://gitlab.freedesktop.org/drm/amd/-/issues/3688
On 2024-02-05 16:12, Mario Limonciello wrote:
Stuart Hayhurst has found that both at bootup and fullscreen VA-API video is leading to black screens for around 1 second and kernel WARNING [1] traces when calling dmub_psr_enable() with Parade 08-01 TCON.
These symptoms all go away with PSR-SU disabled for this TCON, so disable it for now while DMUB traces [2] from the failure can be analyzed and the failure state properly root caused.
Cc: stable@vger.kernel.org Cc: Marc Rossi Marc.Rossi@amd.com Cc: Hamza Mahfooz Hamza.Mahfooz@amd.com Link: https://gitlab.freedesktop.org/drm/amd/uploads/a832dd515b571ee171b3e3b566e99... [1] Link: https://gitlab.freedesktop.org/drm/amd/uploads/8f13ff3b00963c833e23e68aa8116... [2] Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2645 Signed-off-by: Mario Limonciello mario.limonciello@amd.com
Reviewed-by: Leo Li sunpeng.li@amd.com
Thanks
drivers/gpu/drm/amd/display/modules/power/power_helpers.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c index e304e8435fb8..477289846a0a 100644 --- a/drivers/gpu/drm/amd/display/modules/power/power_helpers.c +++ b/drivers/gpu/drm/amd/display/modules/power/power_helpers.c @@ -841,6 +841,8 @@ bool is_psr_su_specific_panel(struct dc_link *link) isPSRSUSupported = false; else if (dpcd_caps->sink_dev_id_str[1] == 0x08 && dpcd_caps->sink_dev_id_str[0] == 0x03) isPSRSUSupported = false;
else if (dpcd_caps->sink_dev_id_str[1] == 0x08 && dpcd_caps->sink_dev_id_str[0] == 0x01)
}isPSRSUSupported = false; else if (dpcd_caps->psr_info.force_psrsu_cap == 0x1) isPSRSUSupported = true;
linux-stable-mirror@lists.linaro.org