On Tue, Nov 29, 2022 at 12:02:41PM -0800, Rob Clark wrote:

From: Rob Clark robdclark@chromium.org

drm_gem_shmem_mmap() doesn't own this reference!

I think the impact should be explained further.

Fixes: 2194a63a818d ("drm: Add library for shmem backed GEM objects") Cc: stable@vger.kernel.org Signed-off-by: Rob Clark robdclark@chromium.org

---

drivers/gpu/drm/drm_gem_shmem_helper.c | 1 - 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 35138f8a375c..110a9eac2af8 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -623,7 +623,6 @@ int drm_gem_shmem_mmap(struct drm_gem_shmem_object *shmem, struct vm_area_struct ret = drm_gem_shmem_get_pages(shmem); if (ret) {

• drm_gem_vm_close(vma);
  

  return ret; }

Drop the now unnecessary { }

Also, consider adding Reported-by: and possibly Suggested-by:.

Thanks, Guenter