On Fri, Feb 23, 2024 at 9:24 PM Saravana Kannan saravanak@google.com wrote:

Introduced a stupid bug in commit 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") due to a last minute incorrect edit of "index !=0" into "!index". This patch fixes it to be "index > 0" to match the comment right next to it.

Greg, this needs to land in the stable branches once Rob picks it up for the next 6.8-rc.

-Saravana

Reported-by: Luca Ceresoli luca.ceresoli@bootlin.com Link: https://lore.kernel.org/lkml/20240223171849.10f9901d@booty/ Fixes: 782bfd03c3ae ("of: property: Improve finding the supplier of a remote-endpoint property") Signed-off-by: Saravana Kannan saravanak@google.com

---

Using Link: instead of Closes: because Luca reported two separate issues.

Sorry about introducing a stupid bug in an -rcX Rob.

-Saravana

drivers/of/property.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/of/property.c b/drivers/of/property.c index b71267c6667c..fa8cd33be131 100644 --- a/drivers/of/property.c +++ b/drivers/of/property.c @@ -1304,7 +1304,7 @@ static struct device_node *parse_remote_endpoint(struct device_node *np, int index) { /* Return NULL for index > 0 to signify end of remote-endpoints. */

•   if (!index || strcmp(prop_name, "remote-endpoint"))
  

•   if (index > 0 || strcmp(prop_name, "remote-endpoint"))
            return NULL;
  
    return of_graph_get_remote_port_parent(np);
  

-- 2.44.0.rc0.258.g7320e95886-goog