The patch titled Subject: vfs: check fd has read access in kernel_read_file_from_fd() has been added to the -mm tree. Its filename is vfs-check-fd-has-read-access-in-kernel_read_file_from_fd.patch

This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/vfs-check-fd-has-read-access-in-ke... and later at https://ozlabs.org/~akpm/mmotm/broken-out/vfs-check-fd-has-read-access-in-ke...

Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/process/submit-checklist.rst when testing your code ***

The -mm tree is included into linux-next and is updated there every 3-4 working days

------------------------------------------------------ From: "Matthew Wilcox (Oracle)" willy@infradead.org Subject: vfs: check fd has read access in kernel_read_file_from_fd()

If we open a file without read access and then pass the fd to a syscall whose implementation calls kernel_read_file_from_fd(), we get a warning from __kernel_read():

if (WARN_ON_ONCE(!(file->f_mode & FMODE_READ)))

This currently affects both finit_module() and kexec_file_load(), but it could affect other syscalls in the future.

Link: https://lkml.kernel.org/r/20211007220110.600005-1-willy@infradead.org Fixes: b844f0ecbc56 ("vfs: define kernel_copy_file_from_fd()") Signed-off-by: Matthew Wilcox (Oracle) willy@infradead.org Reported-by: Hao Sun sunhao.th@gmail.com Cc: Kees Cook keescook@chromium.org Cc: Al Viro viro@zeniv.linux.org.uk Cc: Mimi Zohar zohar@linux.ibm.com Cc: stable@vger.kernel.org Signed-off-by: Andrew Morton akpm@linux-foundation.org ---

fs/kernel_read_file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/kernel_read_file.c~vfs-check-fd-has-read-access-in-kernel_read_file_from_fd +++ a/fs/kernel_read_file.c @@ -178,7 +178,7 @@ int kernel_read_file_from_fd(int fd, lof struct fd f = fdget(fd); int ret = -EBADF;

- if (!f.file) + if (!f.file || !(f.file->f_mode & FMODE_READ)) goto out;

ret = kernel_read_file(f.file, offset, buf, buf_size, file_size, id); _

Patches currently in -mm which might be from willy@infradead.org are

vfs-check-fd-has-read-access-in-kernel_read_file_from_fd.patch mm-move-kvmalloc-related-functions-to-slabh.patch mm-remove-bogus-vm_bug_on.patch mm-optimise-put_pages_list.patch kasan-fix-tag-for-large-allocations-when-using-config_slab.patch