Johan Hovold johan@kernel.org writes:
On Tue, Dec 01, 2020 at 11:03:18AM +0100, Bjørn Mork wrote:
This is a partial revert of commit 2bb70f0a4b23 ("USB: serial: option: support dynamic Quectel USB compositions")
The Quectel BG96 is different from most other modern Quectel modems, having serial functions with 3 endpoints using ff/ff/ff and ff/fe/ff class/subclass/protocol. Including it in the change to accommodate dynamic function mapping was incorrect.
Revert to interface number matching for the BG96, assuming static layout of the RMNET function on interface 4. This restores support for the serial functions on interfaces 2 and 3.
Full lsusb output for the BG96:
Cc: Sebastian Sjoholm sebastian.sjoholm@gmail.com Cc: linux-stable@vger.kernel.org Fixes: 2bb70f0a4b23 ("USB: serial: option: support dynamic Quectel USB compositions") Signed-off-by: Bjørn Mork bjorn@mork.no
Thanks, Bjørn. Now applied.
Thanks. But I see that I managed to type the stable address wrong. Sorry. Hope you can get that fixed somehow.
Patch for checkpatch next, I guess...
Bjørn
On Tue, Dec 01, 2020 at 11:21:42AM +0100, Bjørn Mork wrote:
Johan Hovold johan@kernel.org writes:
On Tue, Dec 01, 2020 at 11:03:18AM +0100, Bjørn Mork wrote:
This is a partial revert of commit 2bb70f0a4b23 ("USB: serial: option: support dynamic Quectel USB compositions")
The Quectel BG96 is different from most other modern Quectel modems, having serial functions with 3 endpoints using ff/ff/ff and ff/fe/ff class/subclass/protocol. Including it in the change to accommodate dynamic function mapping was incorrect.
Revert to interface number matching for the BG96, assuming static layout of the RMNET function on interface 4. This restores support for the serial functions on interfaces 2 and 3.
Full lsusb output for the BG96:
Cc: Sebastian Sjoholm sebastian.sjoholm@gmail.com Cc: linux-stable@vger.kernel.org Fixes: 2bb70f0a4b23 ("USB: serial: option: support dynamic Quectel USB compositions") Signed-off-by: Bjørn Mork bjorn@mork.no
Thanks, Bjørn. Now applied.
Thanks. But I see that I managed to type the stable address wrong. Sorry. Hope you can get that fixed somehow.
Yeah, I noticed when replying. Now fixed up.
Patch for checkpatch next, I guess...
Heh, a potentially useful addition for a change. ;)
Johan
On Tue, Dec 01, 2020 at 11:21:42AM +0100, Bjørn Mork wrote:
Johan Hovold johan@kernel.org writes:
On Tue, Dec 01, 2020 at 11:03:18AM +0100, Bjørn Mork wrote:
This is a partial revert of commit 2bb70f0a4b23 ("USB: serial: option: support dynamic Quectel USB compositions")
The Quectel BG96 is different from most other modern Quectel modems, having serial functions with 3 endpoints using ff/ff/ff and ff/fe/ff class/subclass/protocol. Including it in the change to accommodate dynamic function mapping was incorrect.
Revert to interface number matching for the BG96, assuming static layout of the RMNET function on interface 4. This restores support for the serial functions on interfaces 2 and 3.
Full lsusb output for the BG96:
Cc: Sebastian Sjoholm sebastian.sjoholm@gmail.com Cc: linux-stable@vger.kernel.org Fixes: 2bb70f0a4b23 ("USB: serial: option: support dynamic Quectel USB compositions") Signed-off-by: Bjørn Mork bjorn@mork.no
Thanks, Bjørn. Now applied.
Thanks. But I see that I managed to type the stable address wrong. Sorry. Hope you can get that fixed somehow.
No worries, people type it wrong all the time, my regex would have caught it when it hits Linus's tree :)
linux-stable-mirror@lists.linaro.org
-
Bjørn Mork -
Greg KH -
Johan Hovold