In 6.1/6.6 there is no BACKLIGHT_POWER_ON definition so a build error occurs due to recently backport:
CC drivers/platform/loongarch/loongson-laptop.o drivers/platform/loongarch/loongson-laptop.c: In function 'laptop_backlight_register': drivers/platform/loongarch/loongson-laptop.c:428:23: error: 'BACKLIGHT_POWER_ON' undeclared (first use in this function) 428 | props.power = BACKLIGHT_POWER_ON; | ^~~~~~~~~~~~~~~~~~
Use FB_BLANK_UNBLANK instead which has the same meaning.
Signed-off-by: Huacai Chen chenhuacai@loongson.cn --- drivers/platform/loongarch/loongson-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/platform/loongarch/loongson-laptop.c b/drivers/platform/loongarch/loongson-laptop.c index 61b18ac206c9..5fcfa3a7970b 100644 --- a/drivers/platform/loongarch/loongson-laptop.c +++ b/drivers/platform/loongarch/loongson-laptop.c @@ -425,7 +425,7 @@ static int laptop_backlight_register(void)
props.max_brightness = status; props.brightness = ec_get_brightness(); - props.power = BACKLIGHT_POWER_ON; + props.power = FB_BLANK_UNBLANK; props.type = BACKLIGHT_PLATFORM;
backlight_device_register("loongson_laptop",
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html#opti...
Rule: The upstream commit ID must be specified with a separate line above the commit text. Subject: [PATCH for 6.1/6.6] platform/loongarch: laptop: Fix build error due to backport Link: https://lore.kernel.org/stable/20250622110148.3108758-1-chenhuacai%40loongso...
Please ignore this mail if the patch is not relevant for upstream.
On Sun, Jun 22, 2025 at 07:01:48PM +0800, Huacai Chen wrote:
In 6.1/6.6 there is no BACKLIGHT_POWER_ON definition so a build error occurs due to recently backport:
CC drivers/platform/loongarch/loongson-laptop.o drivers/platform/loongarch/loongson-laptop.c: In function 'laptop_backlight_register': drivers/platform/loongarch/loongson-laptop.c:428:23: error: 'BACKLIGHT_POWER_ON' undeclared (first use in this function) 428 | props.power = BACKLIGHT_POWER_ON; | ^~~~~~~~~~~~~~~~~~
Use FB_BLANK_UNBLANK instead which has the same meaning.
Signed-off-by: Huacai Chen chenhuacai@loongson.cn
drivers/platform/loongarch/loongson-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What commit id is this fixing?
thanks,
greg k-h
On Sun, Jun 22, 2025 at 9:10 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Sun, Jun 22, 2025 at 07:01:48PM +0800, Huacai Chen wrote:
In 6.1/6.6 there is no BACKLIGHT_POWER_ON definition so a build error occurs due to recently backport:
CC drivers/platform/loongarch/loongson-laptop.o drivers/platform/loongarch/loongson-laptop.c: In function 'laptop_backlight_register': drivers/platform/loongarch/loongson-laptop.c:428:23: error: 'BACKLIGHT_POWER_ON' undeclared (first use in this function) 428 | props.power = BACKLIGHT_POWER_ON; | ^~~~~~~~~~~~~~~~~~
Use FB_BLANK_UNBLANK instead which has the same meaning.
Signed-off-by: Huacai Chen chenhuacai@loongson.cn
drivers/platform/loongarch/loongson-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What commit id is this fixing?
commit 53c762b47f726e4079a1f06f684bce2fc0d56fba upstream.
thanks,
greg k-h
On Sun, Jun 22, 2025 at 09:11:44PM +0800, Huacai Chen wrote:
On Sun, Jun 22, 2025 at 9:10 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Sun, Jun 22, 2025 at 07:01:48PM +0800, Huacai Chen wrote:
In 6.1/6.6 there is no BACKLIGHT_POWER_ON definition so a build error occurs due to recently backport:
CC drivers/platform/loongarch/loongson-laptop.o drivers/platform/loongarch/loongson-laptop.c: In function 'laptop_backlight_register': drivers/platform/loongarch/loongson-laptop.c:428:23: error: 'BACKLIGHT_POWER_ON' undeclared (first use in this function) 428 | props.power = BACKLIGHT_POWER_ON; | ^~~~~~~~~~~~~~~~~~
Use FB_BLANK_UNBLANK instead which has the same meaning.
Signed-off-by: Huacai Chen chenhuacai@loongson.cn
drivers/platform/loongarch/loongson-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What commit id is this fixing?
commit 53c762b47f726e4079a1f06f684bce2fc0d56fba upstream.
Great, can you resend this with a proper Fixes: tag so I don't have to manually add it myself?
thanks,
greg k-h
On Mon, Jun 23, 2025 at 2:28 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Sun, Jun 22, 2025 at 09:11:44PM +0800, Huacai Chen wrote:
On Sun, Jun 22, 2025 at 9:10 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Sun, Jun 22, 2025 at 07:01:48PM +0800, Huacai Chen wrote:
In 6.1/6.6 there is no BACKLIGHT_POWER_ON definition so a build error occurs due to recently backport:
CC drivers/platform/loongarch/loongson-laptop.o drivers/platform/loongarch/loongson-laptop.c: In function 'laptop_backlight_register': drivers/platform/loongarch/loongson-laptop.c:428:23: error: 'BACKLIGHT_POWER_ON' undeclared (first use in this function) 428 | props.power = BACKLIGHT_POWER_ON; | ^~~~~~~~~~~~~~~~~~
Use FB_BLANK_UNBLANK instead which has the same meaning.
Signed-off-by: Huacai Chen chenhuacai@loongson.cn
drivers/platform/loongarch/loongson-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What commit id is this fixing?
commit 53c762b47f726e4079a1f06f684bce2fc0d56fba upstream.
Great, can you resend this with a proper Fixes: tag so I don't have to manually add it myself?
Upstream kernel doesn't need to be fixed, and for 6.1/6.6, the commits need to be fixed are in linux-stable-rc.git[1][2] rather than linux-stable.git now.
I don't know your policy about stable branch maintenance, one of the alternatives is modify [1][2] directly. And if you prefer me to resend this patch, I think the commit id is not the upstream id, but the ids in [1][2]?
[1]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c... [2]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c...
Huacai
thanks,
greg k-h
On Mon, Jun 23, 2025 at 02:36:18PM +0800, Huacai Chen wrote:
On Mon, Jun 23, 2025 at 2:28 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Sun, Jun 22, 2025 at 09:11:44PM +0800, Huacai Chen wrote:
On Sun, Jun 22, 2025 at 9:10 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Sun, Jun 22, 2025 at 07:01:48PM +0800, Huacai Chen wrote:
In 6.1/6.6 there is no BACKLIGHT_POWER_ON definition so a build error occurs due to recently backport:
CC drivers/platform/loongarch/loongson-laptop.o drivers/platform/loongarch/loongson-laptop.c: In function 'laptop_backlight_register': drivers/platform/loongarch/loongson-laptop.c:428:23: error: 'BACKLIGHT_POWER_ON' undeclared (first use in this function) 428 | props.power = BACKLIGHT_POWER_ON; | ^~~~~~~~~~~~~~~~~~
Use FB_BLANK_UNBLANK instead which has the same meaning.
Signed-off-by: Huacai Chen chenhuacai@loongson.cn
drivers/platform/loongarch/loongson-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What commit id is this fixing?
commit 53c762b47f726e4079a1f06f684bce2fc0d56fba upstream.
Great, can you resend this with a proper Fixes: tag so I don't have to manually add it myself?
Upstream kernel doesn't need to be fixed, and for 6.1/6.6, the commits need to be fixed are in linux-stable-rc.git[1][2] rather than linux-stable.git now.
I don't know your policy about stable branch maintenance, one of the alternatives is modify [1][2] directly. And if you prefer me to resend this patch, I think the commit id is not the upstream id, but the ids in [1][2]?
[1]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c... [2]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c...
What we should do is just drop those patches from the 6.1.y and 6.6.y queues, I'll go do that now, and wait for you to submit a working version of this patch for those branches, so that we do not have any build breakages anywhere.
Can you submit the updated patches for that now?
thanks,
greg k-h
On Mon, Jun 23, 2025 at 4:03 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Mon, Jun 23, 2025 at 02:36:18PM +0800, Huacai Chen wrote:
On Mon, Jun 23, 2025 at 2:28 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Sun, Jun 22, 2025 at 09:11:44PM +0800, Huacai Chen wrote:
On Sun, Jun 22, 2025 at 9:10 PM Greg Kroah-Hartman gregkh@linuxfoundation.org wrote:
On Sun, Jun 22, 2025 at 07:01:48PM +0800, Huacai Chen wrote:
In 6.1/6.6 there is no BACKLIGHT_POWER_ON definition so a build error occurs due to recently backport:
CC drivers/platform/loongarch/loongson-laptop.o drivers/platform/loongarch/loongson-laptop.c: In function 'laptop_backlight_register': drivers/platform/loongarch/loongson-laptop.c:428:23: error: 'BACKLIGHT_POWER_ON' undeclared (first use in this function) 428 | props.power = BACKLIGHT_POWER_ON; | ^~~~~~~~~~~~~~~~~~
Use FB_BLANK_UNBLANK instead which has the same meaning.
Signed-off-by: Huacai Chen chenhuacai@loongson.cn
drivers/platform/loongarch/loongson-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
What commit id is this fixing?
commit 53c762b47f726e4079a1f06f684bce2fc0d56fba upstream.
Great, can you resend this with a proper Fixes: tag so I don't have to manually add it myself?
Upstream kernel doesn't need to be fixed, and for 6.1/6.6, the commits need to be fixed are in linux-stable-rc.git[1][2] rather than linux-stable.git now.
I don't know your policy about stable branch maintenance, one of the alternatives is modify [1][2] directly. And if you prefer me to resend this patch, I think the commit id is not the upstream id, but the ids in [1][2]?
[1]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c... [2]https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c...
What we should do is just drop those patches from the 6.1.y and 6.6.y queues, I'll go do that now, and wait for you to submit a working version of this patch for those branches, so that we do not have any build breakages anywhere.
Can you submit the updated patches for that now?
OK, will do.
thanks,
greg k-h
[ Sasha's backport helper bot ]
Hi,
Summary of potential issues: ⚠️ Could not find matching upstream commit
No upstream commit was identified. Using temporary commit for testing.
Results of testing on various branches:
| Branch | Patch Apply | Build Test | |---------------------------|-------------|------------| | stable/linux-6.1.y | Success | Success | | stable/linux-6.6.y | Success | Success |
linux-stable-mirror@lists.linaro.org
-
Greg Kroah-Hartman -
Huacai Chen -
Huacai Chen -
kernel test robot -
Sasha Levin