On Mon, 28 Feb 2022 07:32:57 +0100 gregkh@linuxfoundation.org wrote:

The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.

thanks,

greg k-h

This should work for 4.14 (I tested it for one machine).

-- Steve

From 302e9edd54985f584cfc180098f3554774126969 Mon Sep 17 00:00:00 2001

From: "Steven Rostedt (Google)" rostedt@goodmis.org Date: Wed, 23 Feb 2022 22:38:37 -0500 Subject: [PATCH] tracing: Have traceon and traceoff trigger honor the instance

If a trigger is set on an event to disable or enable tracing within an instance, then tracing should be disabled or enabled in the instance and not at the top level, which is confusing to users.

Link: https://lkml.kernel.org/r/20220223223837.14f94ec3@rorschach.local.home

Cc: stable@vger.kernel.org Fixes: ae63b31e4d0e2 ("tracing: Separate out trace events from global variables") Tested-by: Daniel Bristot de Oliveira bristot@kernel.org Reviewed-by: Tom Zanussi zanussi@kernel.org Signed-off-by: Steven Rostedt (Google) rostedt@goodmis.org

--- kernel/trace/trace_events_trigger.c | 52 +++++++++++++++++++++++++++++++----- 1 file changed, 46 insertions(+), 6 deletions(-)

Index: linux-test.git/kernel/trace/trace_events_trigger.c =================================================================== --- linux-test.git.orig/kernel/trace/trace_events_trigger.c 2022-04-20 12:03:32.899882747 -0400 +++ linux-test.git/kernel/trace/trace_events_trigger.c 2022-04-20 12:06:00.769445281 -0400 @@ -932,6 +932,16 @@ void set_named_trigger_data(struct event static void traceon_trigger(struct event_trigger_data *data, void *rec) { + struct trace_event_file *file = data->private_data; + + if (file) { + if (tracer_tracing_is_on(file->tr)) + return; + + tracer_tracing_on(file->tr); + return; + } + if (tracing_is_on()) return;

@@ -941,8 +951,15 @@ traceon_trigger(struct event_trigger_dat static void traceon_count_trigger(struct event_trigger_data *data, void *rec) { - if (tracing_is_on()) - return; + struct trace_event_file *file = data->private_data; + + if (file) { + if (tracer_tracing_is_on(file->tr)) + return; + } else { + if (tracing_is_on()) + return; + }

if (!data->count) return; @@ -950,12 +967,25 @@ traceon_count_trigger(struct event_trigg if (data->count != -1) (data->count)--;

- tracing_on(); + if (file) + tracer_tracing_on(file->tr); + else + tracing_on(); }

static void traceoff_trigger(struct event_trigger_data *data, void *rec) { + struct trace_event_file *file = data->private_data; + + if (file) { + if (!tracer_tracing_is_on(file->tr)) + return; + + tracer_tracing_off(file->tr); + return; + } + if (!tracing_is_on()) return;

@@ -965,8 +995,15 @@ traceoff_trigger(struct event_trigger_da static void traceoff_count_trigger(struct event_trigger_data *data, void *rec) { - if (!tracing_is_on()) - return; + struct trace_event_file *file = data->private_data; + + if (file) { + if (!tracer_tracing_is_on(file->tr)) + return; + } else { + if (!tracing_is_on()) + return; + }

if (!data->count) return; @@ -974,7 +1011,10 @@ traceoff_count_trigger(struct event_trig if (data->count != -1) (data->count)--;

- tracing_off(); + if (file) + tracer_tracing_off(file->tr); + else + tracing_off(); }

static int