From: "Jason-JH.Lin" jason-jh.lin@mediatek.com
This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
Reason for revert: 1. The commit [1] does not land on linux-5.15, so this patch does not fix anything.
2. Since the fw_device improvements series [2] does not land on linux-5.15, using device_set_fwnode() causes the panel to flash during bootup.
Incorrect link management may lead to incorrect device initialization, affecting firmware node links and consumer relationships. The fwnode setting of panel to the DSI device would cause a DSI initialization error without series[2], so this patch was reverted to avoid using the incomplete fw_devlink functionality.
[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust") [2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com --- drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 24606b632009..468a3a7cb6a5 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, return dsi; }
- device_set_node(&dsi->dev, of_fwnode_handle(info->node)); + dsi->dev.of_node = info->node; dsi->channel = info->channel; strlcpy(dsi->name, info->type, sizeof(dsi->name));
--- base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf change-id: 20241024-fixup-5-15-5fdd68dae707
Best regards,
On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4 Relay wrote:
From: "Jason-JH.Lin" jason-jh.lin@mediatek.com
This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
Reason for revert:
- The commit [1] does not land on linux-5.15, so this patch does not
fix anything.
- Since the fw_device improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash during bootup.
Incorrect link management may lead to incorrect device initialization, affecting firmware node links and consumer relationships. The fwnode setting of panel to the DSI device would cause a DSI initialization error without series[2], so this patch was reverted to avoid using the incomplete fw_devlink functionality.
[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle detection more robust") [2] Link: https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com
drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c index 24606b632009..468a3a7cb6a5 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct mipi_dsi_host *host, return dsi; }
- device_set_node(&dsi->dev, of_fwnode_handle(info->node));
- dsi->dev.of_node = info->node; dsi->channel = info->channel; strlcpy(dsi->name, info->type, sizeof(dsi->name));
base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf change-id: 20241024-fixup-5-15-5fdd68dae707
Best regards,
Jason-JH.Lin jason-jh.lin@mediatek.com
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
Hi Greg,
Thanks for your information.
On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
External email : Please do not click links or open attachments until you have verified the sender or the content. On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4 Relay wrote:
From: "Jason-JH.Lin" jason-jh.lin@mediatek.com
This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
Reason for revert:
- The commit [1] does not land on linux-5.15, so this patch does
not
fix anything.
- Since the fw_device improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash
during
bootup.
Incorrect link management may lead to incorrect device
initialization,
affecting firmware node links and consumer relationships. The fwnode setting of panel to the DSI device would cause a DSI initialization error without series[2], so this patch was reverted
to
avoid using the incomplete fw_devlink functionality.
[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
detection more robust")
[2] Link:
https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
Please don't mind me make a confirmation. I just need to add this line here and send it again, right?
Cc: stable@vger.kernel.org #5.15.169
Signed-off-by: Jason-JH.Lin jason-jh.lin@mediatek.com
Regards, Jason-JH.Lin
drivers/gpu/drm/drm_mipi_dsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_mipi_dsi.c
b/drivers/gpu/drm/drm_mipi_dsi.c
index 24606b632009..468a3a7cb6a5 100644 --- a/drivers/gpu/drm/drm_mipi_dsi.c +++ b/drivers/gpu/drm/drm_mipi_dsi.c @@ -221,7 +221,7 @@ mipi_dsi_device_register_full(struct
mipi_dsi_host *host,
return dsi; } -device_set_node(&dsi->dev, of_fwnode_handle(info->node)); +dsi->dev.of_node = info->node; dsi->channel = info->channel; strlcpy(dsi->name, info->type, sizeof(dsi->name));
base-commit: 74cdd62cb4706515b454ce5bacb73b566c1d1bcf change-id: 20241024-fixup-5-15-5fdd68dae707
Best regards,
Jason-JH.Lin jason-jh.lin@mediatek.com
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
On Thu, Oct 24, 2024 at 10:16:05AM +0000, Jason-JH Lin (林睿祥) wrote:
Hi Greg,
Thanks for your information.
On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
External email : Please do not click links or open attachments until you have verified the sender or the content. On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4 Relay wrote:
From: "Jason-JH.Lin" jason-jh.lin@mediatek.com
This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
Reason for revert:
- The commit [1] does not land on linux-5.15, so this patch does
not
fix anything.
- Since the fw_device improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash
during
bootup.
Incorrect link management may lead to incorrect device
initialization,
affecting firmware node links and consumer relationships. The fwnode setting of panel to the DSI device would cause a DSI initialization error without series[2], so this patch was reverted
to
avoid using the incomplete fw_devlink functionality.
[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
detection more robust")
[2] Link:
https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
Please don't mind me make a confirmation. I just need to add this line here and send it again, right?
Cc: stable@vger.kernel.org #5.15.169
Yes.
On Thu, 2024-10-24 at 12:23 +0200, gregkh@linuxfoundation.org wrote:
External email : Please do not click links or open attachments until you have verified the sender or the content. On Thu, Oct 24, 2024 at 10:16:05AM +0000, Jason-JH Lin (林睿祥) wrote:
Hi Greg,
Thanks for your information.
On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
External email : Please do not click links or open attachments
until
you have verified the sender or the content. On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4
Relay
wrote:
From: "Jason-JH.Lin" jason-jh.lin@mediatek.com
This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
Reason for revert:
- The commit [1] does not land on linux-5.15, so this patch
does
not
fix anything.
- Since the fw_device improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash
during
bootup.
Incorrect link management may lead to incorrect device
initialization,
affecting firmware node links and consumer relationships. The fwnode setting of panel to the DSI device would cause a DSI initialization error without series[2], so this patch was
reverted
to
avoid using the incomplete fw_devlink functionality.
[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
detection more robust")
[2] Link:
https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
Please don't mind me make a confirmation. I just need to add this line here and send it again, right?
Cc: stable@vger.kernel.org #5.15.169
Yes.
Hi Greg,
Thanks for your confirmation!
I've sent the patch again without adding `v2` after the [PATCH]: https://lore.kernel.org/all/20241024-fixup-5-15-v1-1-62f21a32b5a5@mediatek.c... Would that be fine with you?
Regards, Jason-JH.Lin
On Mon, Oct 28, 2024 at 02:38:49AM +0000, Jason-JH Lin (林睿祥) wrote:
On Thu, 2024-10-24 at 12:23 +0200, gregkh@linuxfoundation.org wrote:
External email : Please do not click links or open attachments until you have verified the sender or the content. On Thu, Oct 24, 2024 at 10:16:05AM +0000, Jason-JH Lin (林睿祥) wrote:
Hi Greg,
Thanks for your information.
On Thu, 2024-10-24 at 11:47 +0200, Greg KH wrote:
External email : Please do not click links or open attachments
until
you have verified the sender or the content. On Thu, Oct 24, 2024 at 05:37:13PM +0800, Jason-JH.Lin via B4
Relay
wrote:
From: "Jason-JH.Lin" jason-jh.lin@mediatek.com
This reverts commit ac88a1f41f93499df6f50fd18ea835e6ff4f3200.
Reason for revert:
- The commit [1] does not land on linux-5.15, so this patch
does
not
fix anything.
- Since the fw_device improvements series [2] does not land on
linux-5.15, using device_set_fwnode() causes the panel to flash
during
bootup.
Incorrect link management may lead to incorrect device
initialization,
affecting firmware node links and consumer relationships. The fwnode setting of panel to the DSI device would cause a DSI initialization error without series[2], so this patch was
reverted
to
avoid using the incomplete fw_devlink functionality.
[1] commit 3fb16866b51d ("driver core: fw_devlink: Make cycle
detection more robust")
[2] Link:
https://lore.kernel.org/all/20230207014207.1678715-1-saravanak@google.com
Please don't mind me make a confirmation. I just need to add this line here and send it again, right?
Cc: stable@vger.kernel.org #5.15.169
Yes.
Hi Greg,
Thanks for your confirmation!
I've sent the patch again without adding `v2` after the [PATCH]: https://lore.kernel.org/all/20241024-fixup-5-15-v1-1-62f21a32b5a5@mediatek.c... Would that be fine with you?
But it is a v2 patch, why not mark it as such?
[snip]
Please don't mind me make a confirmation. I just need to add this line here and send it again, right?
Cc: stable@vger.kernel.org #5.15.169
Yes.
Hi Greg,
Thanks for your confirmation!
I've sent the patch again without adding `v2` after the [PATCH]:
https://lore.kernel.org/all/20241024-fixup-5-15-v1-1-62f21a32b5a5@mediatek.c...
Would that be fine with you?
But it is a v2 patch, why not mark it as such?
I thought correcting format is not changing commit message or modification, so I didn't increase the version number.
Anyway, I've sent the v2 again:
https://lore.kernel.org/all/20241028-fixup-5-15-v2-1-40216f0fe383@mediatek.c...
Regards, Jason-JH.Lin
linux-stable-mirror@lists.linaro.org
-
Greg KH -
gregkh＠linuxfoundation.org
-
Jason-JH Lin (林睿祥) -
Jason-JH.Lin via B4 Relay