Hi Greg, Sasha,
Please consider commit ba1b40ed0e34 ("drm: nova: depend on CONFIG_64BIT") for 6.18.y. It should cherry-pick cleanly.
Without this commit, one can create a config where `CONFIG_DRM_NOVA` selects `CONFIG_NOVA_CORE` without satisfying its `CONFIG_64BIT` dependency.
In turn, this means arm32 builds can fail -- Kconfig warns:
WARNING: unmet direct dependencies detected for NOVA_CORE Depends on [n]: HAS_IOMEM [=y] && 64BIT && PCI [=y] && RUST [=y] && RUST_FW_LOADER_ABSTRACTIONS [=y] Selected by [y]: - DRM_NOVA [=y] && HAS_IOMEM [=y] && DRM [=y]=y [=y] && PCI [=y] && RUST [=y]
And then the build fails with (among others, see the related commit 5c5a41a75452 ("gpu: nova-core: depend on CONFIG_64BIT") for more):
error[E0308]: mismatched types --> drivers/gpu/nova-core/fb.rs:50:59 | 50 | hal::fb_hal(chipset).write_sysmem_flush_page(bar, page.dma_handle())?; | ----------------------- ^^^^^^^^^^^^^^^^^ expected `u64`, found `u32` | | | arguments to this method are incorrect |
Cc'ing Danilo and Alexandre so that they can confirm they agree.
Thanks!
Cheers, Miguel
linux-stable-mirror@lists.linaro.org