MT7981,7986 and 7988 all supports 32768 PPE entries, and MT7621/MT7620 supports 16384 PPE entries, but only set to 8192 entries in driver. So incrase max entries to 16384 instead.
Cc: stable@vger.kernel.org Signed-off-by: Elad Yifee eladwf@gmail.com Signed-off-by: Shengyu Qu wiagn233@outlook.com Fixes: ba37b7caf1ed ("net: ethernet: mtk_eth_soc: add support for initializing the PPE") --- Changes since V1: - Reduced max entries from 32768 to 16384 to keep compatible with MT7620/21 devices. - Add fixes tag --- drivers/net/ethernet/mediatek/mtk_ppe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mediatek/mtk_ppe.h b/drivers/net/ethernet/mediatek/mtk_ppe.h index 691806bca372..223f709e2704 100644 --- a/drivers/net/ethernet/mediatek/mtk_ppe.h +++ b/drivers/net/ethernet/mediatek/mtk_ppe.h @@ -8,7 +8,7 @@ #include <linux/bitfield.h> #include <linux/rhashtable.h>
-#define MTK_PPE_ENTRIES_SHIFT 3 +#define MTK_PPE_ENTRIES_SHIFT 4 #define MTK_PPE_ENTRIES (1024 << MTK_PPE_ENTRIES_SHIFT) #define MTK_PPE_HASH_MASK (MTK_PPE_ENTRIES - 1) #define MTK_PPE_WAIT_TIMEOUT_US 1000000
On Tue, 2024-06-25 at 19:16 +0800, Shengyu Qu wrote:
MT7981,7986 and 7988 all supports 32768 PPE entries, and MT7621/MT7620 supports 16384 PPE entries, but only set to 8192 entries in driver. So incrase max entries to 16384 instead.
Cc: stable@vger.kernel.org Signed-off-by: Elad Yifee eladwf@gmail.com Signed-off-by: Shengyu Qu wiagn233@outlook.com Fixes: ba37b7caf1ed ("net: ethernet: mtk_eth_soc: add support for initializing the PPE")
Changes since V1:
- Reduced max entries from 32768 to 16384 to keep compatible with MT7620/21 devices.
- Add fixes tag
@Sean, @Mark, @Lorenzo or @Felix, can any of you actually test this?
Thanks!
Paolo
On Tue, 25 Jun 2024 19:16:54 +0800 Shengyu Qu wrote:
MT7981,7986 and 7988 all supports 32768 PPE entries, and MT7621/MT7620 supports 16384 PPE entries, but only set to 8192 entries in driver. So incrase max entries to 16384 instead.
Cc: stable@vger.kernel.org Signed-off-by: Elad Yifee eladwf@gmail.com Signed-off-by: Shengyu Qu wiagn233@outlook.com Fixes: ba37b7caf1ed ("net: ethernet: mtk_eth_soc: add support for initializing the PPE")
nit: Fixes tag usually goes before the sign-offs
This doesn't strike me as a bug fix, tho. What's the user-visible impact? We can't utilize HW to its full abilities?
linux-stable-mirror@lists.linaro.org