Smatch warning: io_fixup_rw_res() warn: unsigned 'res' is never less than zero.
Change type of 'res' from unsigned to long.
Fixes: 788d0824269b ("io_uring: import 5.15-stable io_uring") Signed-off-by: Harshit Mogalapalli harshit.m.mogalapalli@oracle.com --- Note: The Fixes commit is a 5.15 to 5.10 backport, the commit which this patch actually Fixes in 5.15 is d6b7efc722a2 --- io_uring/io_uring.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io_uring/io_uring.c b/io_uring/io_uring.c index 945faf036ad0..0c4d16afb9ef 100644 --- a/io_uring/io_uring.c +++ b/io_uring/io_uring.c @@ -2702,7 +2702,7 @@ static bool __io_complete_rw_common(struct io_kiocb *req, long res) return false; }
-static inline int io_fixup_rw_res(struct io_kiocb *req, unsigned res) +static inline int io_fixup_rw_res(struct io_kiocb *req, long res) { struct io_async_rw *io = req->async_data;
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
Rule: 'Cc: stable@vger.kernel.org' or 'commit <sha1> upstream.' Subject: [PATCH 5.10.y] io_uring: Fix unsigned 'res' comparison with zero in io_fixup_rw_res() Link: https://lore.kernel.org/stable/20230110164044.755234-1-harshit.m.mogalapalli...
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
linux-stable-mirror@lists.linaro.org