From: Sasha Finkelstein fnkl.kernel@gmail.com
This patch fixes an incorrect loop exit condition in code that replaces '/' symbols in the board name. There might also be a memory corruption issue here, but it is unlikely to be a real problem.
Signed-off-by: Sasha Finkelstein fnkl.kernel@gmail.com --- drivers/bluetooth/btbcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c index 3006e2a0f37e..43e98a598bd9 100644 --- a/drivers/bluetooth/btbcm.c +++ b/drivers/bluetooth/btbcm.c @@ -511,7 +511,7 @@ static const char *btbcm_get_board_name(struct device *dev) len = strlen(tmp) + 1; board_type = devm_kzalloc(dev, len, GFP_KERNEL); strscpy(board_type, tmp, len); - for (i = 0; i < board_type[i]; i++) { + for (i = 0; i < len; i++) { if (board_type[i] == '/') board_type[i] = '-'; }
--- base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c change-id: 20230224-btbcm-wtf-ff32fed3e930
Best regards,
Hi,
Thanks for your patch.
FYI: kernel test robot notices the stable kernel rule is not satisfied.
Rule: 'Cc: stable@vger.kernel.org' or 'commit <sha1> upstream.' Subject: [PATCH RESEND] bluetooth: btbcm: Fix logic error in forming the board name. Link: https://lore.kernel.org/stable/20230224-btbcm-wtf-v1-1-d2dbd7ca7ae4%40gmail....
The check is based on https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
On Fri, Mar 10, 2023 at 09:07:33AM +0100, Sasha Finkelstein via B4 Relay wrote:
From: Sasha Finkelstein fnkl.kernel@gmail.com
This patch fixes an incorrect loop exit condition in code that replaces '/' symbols in the board name. There might also be a memory corruption issue here, but it is unlikely to be a real problem.
Signed-off-by: Sasha Finkelstein fnkl.kernel@gmail.com
drivers/bluetooth/btbcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
Sorry about that, let's just skip the stable tree part for now then.
On Fri, Mar 10, 2023 at 10:41:28AM +0100, Sasha Finkelstein wrote:
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
Sorry about that, let's just skip the stable tree part for now then.
That's not how to solve the problem, if it's a bug that needs to be fixed in stable kernels, submit it properly and it will automatically be propagated there as the documentation states.
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Greg KH -
kernel test robot -
Sasha Finkelstein -
Sasha Finkelstein via B4 Relay