FAILED: patch "[PATCH] ASoC: sta32x: set ->component pointer in private struct" failed to apply to 4.14-stable tree
The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
thanks,
greg k-h
------------------ original commit in Linus's tree ------------------
From 747df19747bc9752cd40b9cce761e17a033aa5c2 Mon Sep 17 00:00:00 2001
From: Daniel Mack daniel@zonque.org Date: Thu, 11 Oct 2018 20:32:05 +0200 Subject: [PATCH] ASoC: sta32x: set ->component pointer in private struct
The ESD watchdog code in sta32x_watchdog() dereferences the pointer which is never assigned.
This is a regression from a1be4cead9b950 ("ASoC: sta32x: Convert to direct regmap API usage.") which went unnoticed since nobody seems to use that ESD workaround.
Fixes: a1be4cead9b950 ("ASoC: sta32x: Convert to direct regmap API usage.") Signed-off-by: Daniel Mack daniel@zonque.org Signed-off-by: Mark Brown broonie@kernel.org Cc: stable@vger.kernel.org
diff --git a/sound/soc/codecs/sta32x.c b/sound/soc/codecs/sta32x.c index d5035f2f2b2b..ce508b4cc85c 100644 --- a/sound/soc/codecs/sta32x.c +++ b/sound/soc/codecs/sta32x.c @@ -879,6 +879,9 @@ static int sta32x_probe(struct snd_soc_component *component) struct sta32x_priv *sta32x = snd_soc_component_get_drvdata(component); struct sta32x_platform_data *pdata = sta32x->pdata; int i, ret = 0, thermal = 0; + + sta32x->component = component; + ret = regulator_bulk_enable(ARRAY_SIZE(sta32x->supplies), sta32x->supplies); if (ret != 0) {
On Sun, Nov 11, 2018 at 06:29:26AM -0800, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
The attached backported patch will apply to 4.14-stable tree. But I will prefer to wait for Mark or Daniel to confirm that I have not done something foolish.
-- Regards Sudip
On Thu, Dec 20, 2018 at 09:48:09PM +0000, Sudip Mukherjee wrote:
On Sun, Nov 11, 2018 at 06:29:26AM -0800, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
The attached backported patch will apply to 4.14-stable tree. But I will prefer to wait for Mark or Daniel to confirm that I have not done something foolish.
Should be fine from a quick scan.
On 20/12/2018 10:48 PM, Sudip Mukherjee wrote:
On Sun, Nov 11, 2018 at 06:29:26AM -0800, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
The attached backported patch will apply to 4.14-stable tree. But I will prefer to wait for Mark or Daniel to confirm that I have not done something foolish.
Yes, LGTM.
Thanks! Daniel
On Fri, Dec 21, 2018 at 02:10:39PM +0100, Daniel Mack wrote:
On 20/12/2018 10:48 PM, Sudip Mukherjee wrote:
On Sun, Nov 11, 2018 at 06:29:26AM -0800, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
The attached backported patch will apply to 4.14-stable tree. But I will prefer to wait for Mark or Daniel to confirm that I have not done something foolish.
Yes, LGTM.
Queued for all but 3.18, thanks all.
-- Thanks, Sasha
On Fri, Dec 21, 2018 at 06:24:58PM -0500, Sasha Levin wrote:
On Fri, Dec 21, 2018 at 02:10:39PM +0100, Daniel Mack wrote:
On 20/12/2018 10:48 PM, Sudip Mukherjee wrote:
On Sun, Nov 11, 2018 at 06:29:26AM -0800, gregkh@linuxfoundation.org wrote:
The patch below does not apply to the 4.14-stable tree. If someone wants it applied there, or to any other stable or longterm tree, then please email the backport, including the original git commit id to stable@vger.kernel.org.
The attached backported patch will apply to 4.14-stable tree. But I will prefer to wait for Mark or Daniel to confirm that I have not done something foolish.
Yes, LGTM.
Queued for all but 3.18, thanks all.
It breaks the build on 4.4 and 4.9, so I've dropped it from there :(
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Daniel Mack -
Greg KH -
gregkh＠linuxfoundation.org
-
Mark Brown -
Sasha Levin -
Sudip Mukherjee