Hans,

Thank you for the fix. Reviewed-by: Bingbu Cao bingbu.cao@intel.com

On 10/15/25 1:40 AM, Hans de Goede wrote:

When the test-pattern control gets set to 0 (Disabled) 0 should be written to the test-pattern register, rather then doing nothing.

Fixes: 0827b58dabff ("media: i2c: add ov01a10 image sensor driver") Cc: stable@vger.kernel.org Signed-off-by: Hans de Goede hansg@kernel.org

---

drivers/media/i2c/ov01a10.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/media/i2c/ov01a10.c b/drivers/media/i2c/ov01a10.c index 0405ec7c75fd..733e5bf0180c 100644 --- a/drivers/media/i2c/ov01a10.c +++ b/drivers/media/i2c/ov01a10.c @@ -406,10 +406,8 @@ static int ov01a10_update_digital_gain(struct ov01a10 *ov01a10, u32 d_gain) static int ov01a10_test_pattern(struct ov01a10 *ov01a10, u32 pattern) {

• if (!pattern)

• return 0;
  

• pattern = (pattern - 1) | OV01A10_TEST_PATTERN_ENABLE;

• if (pattern)

• pattern = (pattern - 1) | OV01A10_TEST_PATTERN_ENABLE;
  

return ov01a10_write_reg(ov01a10, OV01A10_REG_TEST_PATTERN, 1, pattern); }