The port count of the PX-257 Rev3 is actually 2, not 4.
Fixes: ef5a03a26c87 ("tty: 8250: Add support for Brainboxes PX cards.") Cc: stable@vger.kernel.org Signed-off-by: Cameron Williams cang1@live.co.uk --- For stable: This patch is only applicable to 5.15 LTS and up, other LTS kernels dont have PX card support.
v3 - v4: Split patch v3 part 5 into multiple Fixes patches and an Additions patch. Add Fixes: and Cc: tag.
v2 - v3: Alter commit message a little to make the additions/fixes cleaner Re-submit patch series using git send-email to make threading work.
v1 - v2: This is a resubmission series for the patch series below. That series was lots of changes sent to lots of maintainers, this series is just for the tty/serial/8250 subsystem.
[1] https://lore.kernel.org/all/DU0PR02MB789950E64D808DB57E9D7312C4F8A@DU0PR02MB... [2] https://lore.kernel.org/all/DU0PR02MB7899DE53DFC900EFB50E53F2C4F8A@DU0PR02MB... [3] https://lore.kernel.org/all/DU0PR02MB7899033E7E81EAF3694BC20AC4F8A@DU0PR02MB... [4] https://lore.kernel.org/all/DU0PR02MB7899EABA8C3DCAC94DCC79D4C4F8A@DU0PR02MB...
drivers/tty/serial/8250/8250_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c index b0a632415d8e..59074a709254 100644 --- a/drivers/tty/serial/8250/8250_pci.c +++ b/drivers/tty/serial/8250/8250_pci.c @@ -5180,7 +5180,7 @@ static const struct pci_device_id serial_pci_tbl[] = { { PCI_VENDOR_ID_INTASHIELD, 0x4015, PCI_ANY_ID, PCI_ANY_ID, 0, 0, - pbn_oxsemi_4_15625000 }, + pbn_oxsemi_2_15625000 }, /* * Brainboxes PX-260/PX-701 */
On Fri, 20 Oct 2023, Cameron Williams wrote:
The port count of the PX-257 Rev3 is actually 2, not 4.
Fixes: ef5a03a26c87 ("tty: 8250: Add support for Brainboxes PX cards.") Cc: stable@vger.kernel.org Signed-off-by: Cameron Williams cang1@live.co.uk
Please arrange your series such that the patches with Fixes are first, not in the middle of your series.
On Tue, Oct 24, 2023 at 12:42:28PM +0300, Ilpo Järvinen wrote:
On Fri, 20 Oct 2023, Cameron Williams wrote:
The port count of the PX-257 Rev3 is actually 2, not 4.
Fixes: ef5a03a26c87 ("tty: 8250: Add support for Brainboxes PX cards.") Cc: stable@vger.kernel.org Signed-off-by: Cameron Williams cang1@live.co.uk
Please arrange your series such that the patches with Fixes are first, not in the middle of your series.
Almost all of these are going to stable, so this was ok.
thanks,
greg k-h
On Tue, Oct 24, 2023 at 11:50:05AM +0200, Greg Kroah-Hartman wrote:
On Tue, Oct 24, 2023 at 12:42:28PM +0300, Ilpo Järvinen wrote:
On Fri, 20 Oct 2023, Cameron Williams wrote:
The port count of the PX-257 Rev3 is actually 2, not 4.
Fixes: ef5a03a26c87 ("tty: 8250: Add support for Brainboxes PX cards.") Cc: stable@vger.kernel.org Signed-off-by: Cameron Williams cang1@live.co.uk
Please arrange your series such that the patches with Fixes are first, not in the middle of your series.
My apologies, when I was working on this patch series I was going by device product line then fixes and additions. I will keep that in mind for next time.
Almost all of these are going to stable, so this was ok.
Thank you Greg, I was sure that device IDs/quirks were OK to go into the stable kernel as per the documentation online.
thanks,
greg k-h
linux-stable-mirror@lists.linaro.org
-
Cameron Williams -
Greg Kroah-Hartman -
Ilpo Järvinen