On Sun, Apr 16, 2023 at 03:22:18PM +0800, cuigaosheng wrote:
On 2023/4/15 23:07, Greg KH wrote:
On Sat, Apr 15, 2023 at 06:11:55PM +0800, Gaosheng Cui wrote:
From: Herbert Xu herbert@gondor.apana.org.au
When complex algorithms that depend on other algorithms are built into the kernel, the order of registration must be done such that the underlying algorithms are ready before the ones on top are registered. As otherwise they would fail during the self-test which is required during registration.
In the past we have used subsystem initialisation ordering to guarantee this. The number of such precedence levels are limited and they may cause ripple effects in other subsystems.
This patch solves this problem by delaying all self-tests during boot-up for built-in algorithms. They will be tested either when something else in the kernel requests for them, or when we have finished registering all built-in algorithms, whichever comes earlier.
Reported-by: Vladis Dronov vdronov@redhat.com Signed-off-by: Herbert Xu herbert@gondor.apana.org.au Signed-off-by: Gaosheng Cui cuigaosheng1@huawei.com
crypto/algapi.c | 73 +++++++++++++++++++++++++++++++++-------------- crypto/api.c | 52 +++++++++++++++++++++++++++++---- crypto/internal.h | 10 +++++++ 3 files changed, 108 insertions(+), 27 deletions(-)
What is the git commit id of this, and the other 3 patches, in Linus's tree? That is required to have here, as you know.
thanks,
greg k-h .
Thanks for taking time to review these patch.
These patches are in Linus's tree, reference as follows: Reference 1: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... Reference 2: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... Reference 3: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... Reference 4: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
Please resend the patches with the git commit id in the changelog somewhere, as is normally done (there are thousands of examples on the mailing list.)
Also be sure that you are also backporting the patches to newer kernel releases so that someone does not upgrade and have a regression (i.e. if a patch is also needed in 5.15.y send a backport for that too.)
Thanks,
greg k-h
On 2023/4/18 17:28, Greg KH wrote:
On Sun, Apr 16, 2023 at 03:22:18PM +0800, cuigaosheng wrote:
On 2023/4/15 23:07, Greg KH wrote:
On Sat, Apr 15, 2023 at 06:11:55PM +0800, Gaosheng Cui wrote:
From: Herbert Xu herbert@gondor.apana.org.au
When complex algorithms that depend on other algorithms are built into the kernel, the order of registration must be done such that the underlying algorithms are ready before the ones on top are registered. As otherwise they would fail during the self-test which is required during registration.
In the past we have used subsystem initialisation ordering to guarantee this. The number of such precedence levels are limited and they may cause ripple effects in other subsystems.
This patch solves this problem by delaying all self-tests during boot-up for built-in algorithms. They will be tested either when something else in the kernel requests for them, or when we have finished registering all built-in algorithms, whichever comes earlier.
Reported-by: Vladis Dronov vdronov@redhat.com Signed-off-by: Herbert Xu herbert@gondor.apana.org.au Signed-off-by: Gaosheng Cui cuigaosheng1@huawei.com
crypto/algapi.c | 73 +++++++++++++++++++++++++++++++++-------------- crypto/api.c | 52 +++++++++++++++++++++++++++++---- crypto/internal.h | 10 +++++++ 3 files changed, 108 insertions(+), 27 deletions(-)
What is the git commit id of this, and the other 3 patches, in Linus's tree? That is required to have here, as you know.
thanks,
greg k-h .
Thanks for taking time to review these patch.
These patches are in Linus's tree, reference as follows: Reference 1: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... Reference 2: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... Reference 3: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i... Reference 4: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?i...
Please resend the patches with the git commit id in the changelog somewhere, as is normally done (there are thousands of examples on the mailing list.)
Also be sure that you are also backporting the patches to newer kernel releases so that someone does not upgrade and have a regression (i.e. if a patch is also needed in 5.15.y send a backport for that too.)
Thanks,
greg k-h .
As I did more testing, I found that the patch set conflicted with SIMD, so we needed a more appropriate solution to fix it, please ignore this patch set, thanks.
Thanks for your time again!
linux-stable-mirror@lists.linaro.org
-
cuigaosheng -
Greg KH