Re: [REGRESSION 6.1.70] system calls with CIFS mounts failing with "Resource temporarily unavailable"
It looks like both 5.15.146 and 5.10.206 are impacted by this regression as they both have the bad commit 33eae65c6f (smb: client: fix OOB in SMB2_query_info_init()). We tried to apply the proposed fix eb3e28c1e89b ("smb3: Replace smb2pdu 1-element arrays with flex-arrays”) but there are a lot of dependencies required to do the backport. Is it possible to consider the simple fix that Paulo proposed as a solution for 5.10 and 5.15. We were lucky with 5.4 as it doesn’t have the bad commit because of merge conflict reported in https://lore.kernel.org/all/2023122857-doubling-crazed-27f4@gregkh/T/#m3aa00...
diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c index 05ff8a457a3d..aed5067661de 100644 --- a/fs/smb/client/smb2pdu.c +++ b/fs/smb/client/smb2pdu.c @@ -3556,7 +3556,7 @@ SMB2_query_info_init(struct cifs_tcon *tcon, struct TCP_Server_Info *server, iov[0].iov_base = (char *)req; /* 1 for Buffer */ - iov[0].iov_len = len; + iov[0].iov_len = len - 1; return 0; }
Hazem
To be clear here we have already tested 5.10.206 and 5.15.146 with the proposed fix and we no longer see the reported CIFS mounting failure.
Hazem
On 15/01/2024, 14:23, "Mohamed Abuelfotoh, Hazem" <abuehaze@amazon.com mailto:abuehaze@amazon.com> wrote:
It looks like both 5.15.146 and 5.10.206 are impacted by this regression as they both have the bad commit 33eae65c6f (smb: client: fix OOB in SMB2_query_info_init()). We tried to apply the proposed fix eb3e28c1e89b ("smb3: Replace smb2pdu 1-element arrays with flex-arrays”) but there are a lot of dependencies required to do the backport. Is it possible to consider the simple fix that Paulo proposed as a solution for 5.10 and 5.15. We were lucky with 5.4 as it doesn’t have the bad commit because of merge conflict reported in https://lore.kernel.org/all/2023122857-doubling-crazed-27f4@gregkh/T/#m3aa00... https://lore.kernel.org/all/2023122857-doubling-crazed-27f4@gregkh/T/#m3aa009c332999268f71361237ace6ded9110f0d0
diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c index 05ff8a457a3d..aed5067661de 100644 --- a/fs/smb/client/smb2pdu.c +++ b/fs/smb/client/smb2pdu.c @@ -3556,7 +3556,7 @@ SMB2_query_info_init(struct cifs_tcon *tcon, struct TCP_Server_Info *server,
iov[0].iov_base = (char *)req; /* 1 for Buffer */ - iov[0].iov_len = len; + iov[0].iov_len = len - 1; return 0; }
Hazem
On Mon, Jan 15, 2024 at 02:28:45PM +0000, Mohamed Abuelfotoh, Hazem wrote:
To be clear here we have already tested 5.10.206 and 5.15.146 with the proposed fix and we no longer see the reported CIFS mounting failure.
Please don't top-post :(
Anyway, please submit this in a form that it can be applied in, as-is, there's nothing I can do with this...
thanks,
greg k-h
Thanks Greg, I will submit separate patch inclusion requests for fixing this on 5.15 and 5.10.
Hazem
On 15/01/2024, 15:17, "gregkh@linuxfoundation.org mailto:gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org mailto:gregkh@linuxfoundation.org> wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
On Mon, Jan 15, 2024 at 02:28:45PM +0000, Mohamed Abuelfotoh, Hazem wrote:
To be clear here we have already tested 5.10.206 and 5.15.146 with the proposed fix and we no longer see the reported CIFS mounting failure.
Please don't top-post :(
Anyway, please submit this in a form that it can be applied in, as-is, there's nothing I can do with this...
thanks,
greg k-h
Hi,
On Mon, Jan 15, 2024 at 03:30:46PM +0000, Mohamed Abuelfotoh, Hazem wrote:
Thanks Greg, I will submit separate patch inclusion requests for fixing this on 5.15 and 5.10.
Note, my reply in the secondary thread: https://lore.kernel.org/stable/Zbl881W5S-nL7iof@eldamar.lan/T/#mb9a9a012adde...
Now https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c... was applied, but equally the backport https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c... https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c...
So I guess https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c... should be dropped again.
Regards, Salvatore
Salvatore Bonaccorso carnil@debian.org writes:
Hi,
On Mon, Jan 15, 2024 at 03:30:46PM +0000, Mohamed Abuelfotoh, Hazem wrote:
Thanks Greg, I will submit separate patch inclusion requests for fixing this on 5.15 and 5.10.
Note, my reply in the secondary thread: https://lore.kernel.org/stable/Zbl881W5S-nL7iof@eldamar.lan/T/#mb9a9a012adde...
Now https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c... was applied, but equally the backport https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c... https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c...
So I guess https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/c... should be dropped again.
Agreed.
Greg, could you please drop
b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()")
from v5.10.y as suggested by Salvatore?
Thanks.
On 31/01/2024 17:19, Paulo Alcantara wrote:
Greg, could you please drop
b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()")from v5.10.y as suggested by Salvatore?
Thanks.
Are we dropping b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()") from v5.10.y while keeping it on v5.15.y? if we are dropping it from v5.15.y as well then we should backport 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays to v5.15.y I remember trying to backport this patch on v5.15.y but there were some merge conflicts there.
06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays
Thank you.
Hazem
Hi,
On Thu, Feb 01, 2024 at 12:58:28PM +0000, Mohamed Abuelfotoh, Hazem wrote:
On 31/01/2024 17:19, Paulo Alcantara wrote:
Greg, could you please drop
b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()")from v5.10.y as suggested by Salvatore?
Thanks.
Are we dropping b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()") from v5.10.y while keeping it on v5.15.y? if we are dropping it from v5.15.y as well then we should backport 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays to v5.15.y I remember trying to backport this patch on v5.15.y but there were some merge conflicts there.
06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays
While I'm not eligible to say what should be done, my understading is that Greg probably would prefer to have the "backport 06aa6eff7b" version. What we know is that having now both commits in the stable-rc/linux-5.10.y queue breaks cifs and the backport variants seens to work fine (Paulo Alcantara probably though can comment best).
As 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays was backportable to 5.10.y it should now work as well for the upper one 5.15.y.
Regards, Salvatore
Hi Salvatore,
Adding kovalev here(who backported it to 5.10.y)
On 03/02/24 9:09 pm, Salvatore Bonaccorso wrote:
Hi,
On Thu, Feb 01, 2024 at 12:58:28PM +0000, Mohamed Abuelfotoh, Hazem wrote:
On 31/01/2024 17:19, Paulo Alcantara wrote:
Greg, could you please drop
b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()")from v5.10.y as suggested by Salvatore?
Thanks.
Are we dropping b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()") from v5.10.y while keeping it on v5.15.y? if we are dropping it from v5.15.y as well then we should backport 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays to v5.15.y I remember trying to backport this patch on v5.15.y but there were some merge conflicts there.
06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays
While I'm not eligible to say what should be done, my understading is that Greg probably would prefer to have the "backport 06aa6eff7b" version. What we know is that having now both commits in the stable-rc/linux-5.10.y queue breaks cifs and the backport variants seens to work fine (Paulo Alcantara probably though can comment best).
Having both one-liner fix that I have sent and the above commit isn't correct.
As 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays was backportable to 5.10.y it should now work as well for the upper one 5.15.y.
Correct, I agree. I had to send one-liner fix as we have the backport("06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays") missing in 5.15.y and when I tried backporting it to 5.15.y I saw many conflicts.
If we have backport for 5.15.y similar to 5.10.y we could ask greg to remove one liner fix from both 5.10.y and 5.15.y: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree...
Thanks, Harshit
Regards, Salvatore
Hello everyone,
06.02.2024 10:46, Harshit Mogalapalli wrote:
Adding kovalev here(who backported it to 5.10.y)
I adapted the commit "smb3: Replace smb2pdu 1-element arrays with flex-arrays" for 5.15.y and sent patch[1].
[1] https://lore.kernel.org/lkml/20240206161111.454699-1-kovalev@altlinux.org/T/...
On Tue, Feb 06, 2024 at 01:16:01PM +0530, Harshit Mogalapalli wrote:
Hi Salvatore,
Adding kovalev here(who backported it to 5.10.y)
On 03/02/24 9:09 pm, Salvatore Bonaccorso wrote:
Hi,
On Thu, Feb 01, 2024 at 12:58:28PM +0000, Mohamed Abuelfotoh, Hazem wrote:
On 31/01/2024 17:19, Paulo Alcantara wrote:
Greg, could you please drop
b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()")from v5.10.y as suggested by Salvatore?
Thanks.
Are we dropping b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()") from v5.10.y while keeping it on v5.15.y? if we are dropping it from v5.15.y as well then we should backport 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays to v5.15.y I remember trying to backport this patch on v5.15.y but there were some merge conflicts there.
06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays
While I'm not eligible to say what should be done, my understading is that Greg probably would prefer to have the "backport 06aa6eff7b" version. What we know is that having now both commits in the stable-rc/linux-5.10.y queue breaks cifs and the backport variants seens to work fine (Paulo Alcantara probably though can comment best).
Having both one-liner fix that I have sent and the above commit isn't correct.
As 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays was backportable to 5.10.y it should now work as well for the upper one 5.15.y.
Correct, I agree. I had to send one-liner fix as we have the backport("06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays") missing in 5.15.y and when I tried backporting it to 5.15.y I saw many conflicts.
If we have backport for 5.15.y similar to 5.10.y we could ask greg to remove one liner fix from both 5.10.y and 5.15.y: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree...
Someone needs to tell me what to do, as I'm lost.
thanks,
greg k-h
Hi Greg,
On 21/02/24 01:58, gregkh@linuxfoundation.org wrote:
On Tue, Feb 06, 2024 at 01:16:01PM +0530, Harshit Mogalapalli wrote:
Hi Salvatore,
Adding kovalev here(who backported it to 5.10.y)
On 03/02/24 9:09 pm, Salvatore Bonaccorso wrote:
Hi,
On Thu, Feb 01, 2024 at 12:58:28PM +0000, Mohamed Abuelfotoh, Hazem wrote:
On 31/01/2024 17:19, Paulo Alcantara wrote:
Greg, could you please drop
b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()")from v5.10.y as suggested by Salvatore?
Thanks.
Are we dropping b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()") from v5.10.y while keeping it on v5.15.y? if we are dropping it from v5.15.y as well then we should backport 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays to v5.15.y I remember trying to backport this patch on v5.15.y but there were some merge conflicts there.
06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays
While I'm not eligible to say what should be done, my understading is that Greg probably would prefer to have the "backport 06aa6eff7b" version. What we know is that having now both commits in the stable-rc/linux-5.10.y queue breaks cifs and the backport variants seens to work fine (Paulo Alcantara probably though can comment best).
Having both one-liner fix that I have sent and the above commit isn't correct.
As 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays was backportable to 5.10.y it should now work as well for the upper one 5.15.y.
Correct, I agree. I had to send one-liner fix as we have the backport("06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays") missing in 5.15.y and when I tried backporting it to 5.15.y I saw many conflicts.
If we have backport for 5.15.y similar to 5.10.y we could ask greg to remove one liner fix from both 5.10.y and 5.15.y: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree...
Someone needs to tell me what to do, as I'm lost.
For 5.15.y:
1. Remove this patch from the queue: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree... 2. Add this patch(kovalev's backport) to queue: https://lore.kernel.org/lkml/20240206161111.454699-1-kovalev@altlinux.org/T/...
For 5.10.y:
1. Remove this patch from the queue: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree...
(kovalev's backport is already in queue[1], so nothing to add here like '2' in 5.15.y)
Reason for the above:
For 5.10.y and 5.15.y: I have sent a diverged patch(one liner) which is present in the queue now and have to be removed because kovalev sent a backport of upstream commit by resolving conflicts. Given that both of us were working on same problem there should only be one fix there, so we are going with Kovalev's backport and removing my one liner fix. Kovalev's backport for 5.10.y was already added to queue but not in 5.15.y. So remove my one liner fix from both queues and queuing up Kovalev's 5.15.y backport will solve the problems. Please let me know if any of this is unclear, I can share more details.
Ref: [1]: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree...
Thanks, Harshit
thanks,
greg k-h
On Wed, Feb 21, 2024 at 07:56:01AM +0530, Harshit Mogalapalli wrote:
Hi Greg,
On 21/02/24 01:58, gregkh@linuxfoundation.org wrote:
On Tue, Feb 06, 2024 at 01:16:01PM +0530, Harshit Mogalapalli wrote:
Hi Salvatore,
Adding kovalev here(who backported it to 5.10.y)
On 03/02/24 9:09 pm, Salvatore Bonaccorso wrote:
Hi,
On Thu, Feb 01, 2024 at 12:58:28PM +0000, Mohamed Abuelfotoh, Hazem wrote:
On 31/01/2024 17:19, Paulo Alcantara wrote:
Greg, could you please drop
b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()")from v5.10.y as suggested by Salvatore?
Thanks.
Are we dropping b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()") from v5.10.y while keeping it on v5.15.y? if we are dropping it from v5.15.y as well then we should backport 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays to v5.15.y I remember trying to backport this patch on v5.15.y but there were some merge conflicts there.
06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays
While I'm not eligible to say what should be done, my understading is that Greg probably would prefer to have the "backport 06aa6eff7b" version. What we know is that having now both commits in the stable-rc/linux-5.10.y queue breaks cifs and the backport variants seens to work fine (Paulo Alcantara probably though can comment best).
Having both one-liner fix that I have sent and the above commit isn't correct.
As 06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays was backportable to 5.10.y it should now work as well for the upper one 5.15.y.
Correct, I agree. I had to send one-liner fix as we have the backport("06aa6eff7b smb3: Replace smb2pdu 1-element arrays with flex-arrays") missing in 5.15.y and when I tried backporting it to 5.15.y I saw many conflicts.
If we have backport for 5.15.y similar to 5.10.y we could ask greg to remove one liner fix from both 5.10.y and 5.15.y: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree...
Someone needs to tell me what to do, as I'm lost.
For 5.15.y:
- Remove this patch from the queue:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree... 2. Add this patch(kovalev's backport) to queue: https://lore.kernel.org/lkml/20240206161111.454699-1-kovalev@altlinux.org/T/...
Now done.
For 5.10.y:
- Remove this patch from the queue:
https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree...
(kovalev's backport is already in queue[1], so nothing to add here like '2' in 5.15.y)
Now done.
Ok, I think we are good. I'll push out -rc kernels soon for people to test with.
thanks,
greg k-h
Hi,
On 15/01/24 7:52 pm, Mohamed Abuelfotoh, Hazem wrote:
It looks like both 5.15.146 and 5.10.206 are impacted by this regression as they both have the bad commit 33eae65c6f (smb: client: fix OOB in SMB2_query_info_init()). We tried to apply the proposed fix eb3e28c1e89b ("smb3: Replace smb2pdu 1-element arrays with flex-arrays”) but there are a lot of dependencies required to do the backport. Is it possible to consider the simple fix that Paulo proposed as a solution for 5.10 and 5.15. We were lucky with 5.4 as it doesn’t have the bad commit because of merge conflict reported in https://lore.kernel.org/all/2023122857-doubling-crazed-27f4@gregkh/T/#m3aa00...
I think we are also seeing the same error on running xfstests with cifs.
[root@vm xfstests-dev]# ./check -g quick -s smb3 TEST_DEV=//<SERVER_IP>/TEST is mounted but not a type cifs filesystem
This is with 5.15.147 stable kernel.
I started seeing this since 5.15.146 and on bisection it points to the same commit:
commit bfd18c0f570e ("smb: client: fix OOB in SMB2_query_info_init()"), reverting that commit fixed the issue and also when I applied the below diff provided in this thread, the tests run fine.
[root@vm xfstests-dev]# ./check -g quick -s smb3 cifs/001 SECTION -- smb3 FSTYP -- cifs PLATFORM -- Linux/x86_64 vm 5.15.147-master.el9.v5.x86_64 #1 SMP Mon Jan 15 22:39:33 PST 2024 MKFS_OPTIONS -- //<SERVER_IP>/SCRATCH MOUNT_OPTIONS -- -ousername=root,password=PASSWORD,noperm,mfsymlinks,actimeo=0 //<SERVER_IP>/SCRATCH /mnt/scratch
cifs/001 1s ... 1s generic/001 16s ...
Thanks, Harshit
diff --git a/fs/smb/client/smb2pdu.c b/fs/smb/client/smb2pdu.c index 05ff8a457a3d..aed5067661de 100644 --- a/fs/smb/client/smb2pdu.c +++ b/fs/smb/client/smb2pdu.c @@ -3556,7 +3556,7 @@ SMB2_query_info_init(struct cifs_tcon *tcon, struct TCP_Server_Info *server, iov[0].iov_base = (char *)req; /* 1 for Buffer */
- iov[0].iov_len = len;
- iov[0].iov_len = len - 1; return 0;
}Hazem
On Mon, 15 Jan 2024 14:22:39 +0000 "Mohamed Abuelfotoh, Hazem" abuehaze@amazon.com wrote:
It looks like both 5.15.146 and 5.10.206 are impacted by this regression as they both have the bad commit 33eae65c6f (smb: client: fix OOB in SMB2_query_info_init()).
Let me try to tell this to the regression tracking bot, following the doc[1]. This is my first time using #regzbot, so please feel free to correct me if I'm doing something wrong.
#regzbot introduced: 33eae65c6f
[1] https://docs.kernel.org/admin-guide/reporting-regressions.html#how-do-i-repo...
Thanks, SJ
[...]
On 26.01.24 20:13, SeongJae Park wrote:
On Mon, 15 Jan 2024 14:22:39 +0000 "Mohamed Abuelfotoh, Hazem" abuehaze@amazon.com wrote:
It looks like both 5.15.146 and 5.10.206 are impacted by this regression as they both have the bad commit 33eae65c6f (smb: client: fix OOB in SMB2_query_info_init()).
Let me try to tell this to the regression tracking bot, following the doc[1]. This is my first time using #regzbot, so please feel free to correct me if I'm doing something wrong.
#regzbot introduced: 33eae65c6f
Thx. Took a while (among others because the stable team worked a bit slower that usual), but from what Paulo Alcantara and Salvatore Bonaccorso recently said everything is afaics now fixed or on track to be fixed in all affected stable/longterm branches: https://lore.kernel.org/all/ZdgyEfNsev8WGIl5@eldamar.lan/
If I got this wrong and that's not the case, please holler.
#regzbot resolve: apparently fixed in all affected stable/longterm branches with various commits #regzbot ignore-activity
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr That page also explains what to do if mails like this annoy you.
On 23/02/2024 06:14, Linux regression tracking #update (Thorsten Leemhuis) wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
Thx. Took a while (among others because the stable team worked a bit slower that usual), but from what Paulo Alcantara and Salvatore Bonaccorso recently said everything is afaics now fixed or on track to be fixed in all affected stable/longterm branches: https://lore.kernel.org/all/ZdgyEfNsev8WGIl5@eldamar.lan/
If I got this wrong and that's not the case, please holler.
#regzbot resolve: apparently fixed in all affected stable/longterm branches with various commits #regzbot ignore-activity
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr That page also explains what to do if mails like this annoy you.
We are seeing CIFS mount failures after upgrading from v5.15.148 to v5.15.149, I have reverted eb3e28c1e8 ("smb3: Replace smb2pdu 1-element arrays with flex-arrays") and I no longer see the regression. It looks like the issue is also impacting v5.10.y as the mentioned reverted patch has also been merged to v5.10.210. I am currently running the CIFS mount test manually and will update the thread with the exact mount failure error. I think we should revert eb3e28c1e8 ("smb3: Replace smb2pdu 1-element arrays with flex-arrays") from both v5.15.y & v5.10.y until we come up with a proper fix on this versions, please note that if we will take this path then we will need to re-introduce. b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()") which has been removed from latest v5.10.y and v5.15.y releases.
[CCing a few people that afaics were involved in trying to fix the CIFS problems on 5.15/5.10 (to be honest I lost a bit track of that situation; sorry if I added too many people; at the same time I hope I did not forget anyone...)]
Anyway: it seems 5.15.149 created a new CIFS problem, see the quoted mail below for details. Ciao, Thorsten
On 26.02.24 15:28, Mohamed Abuelfotoh, Hazem wrote:
On 23/02/2024 06:14, Linux regression tracking #update (Thorsten Leemhuis) wrote:
Thx. Took a while (among others because the stable team worked a bit slower that usual), but from what Paulo Alcantara and Salvatore Bonaccorso recently said everything is afaics now fixed or on track to be fixed in all affected stable/longterm branches: https://lore.kernel.org/all/ZdgyEfNsev8WGIl5@eldamar.lan/
If I got this wrong and that's not the case, please holler.
We are seeing CIFS mount failures after upgrading from v5.15.148 to v5.15.149, I have reverted eb3e28c1e8 ("smb3: Replace smb2pdu 1-element arrays with flex-arrays") and I no longer see the regression. It looks like the issue is also impacting v5.10.y as the mentioned reverted patch has also been merged to v5.10.210. I am currently running the CIFS mount test manually and will update the thread with the exact mount failure error. I think we should revert eb3e28c1e8 ("smb3: Replace smb2pdu 1-element arrays with flex-arrays") from both v5.15.y & v5.10.y until we come up with a proper fix on this versions, please note that if we will take this path then we will need to re-introduce. b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()") which has been removed from latest v5.10.y and v5.15.y releases.
On Mon, Feb 26, 2024 at 02:28:41PM +0000, Mohamed Abuelfotoh, Hazem wrote:
On 23/02/2024 06:14, Linux regression tracking #update (Thorsten Leemhuis) wrote:
CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
Thx. Took a while (among others because the stable team worked a bit slower that usual), but from what Paulo Alcantara and Salvatore Bonaccorso recently said everything is afaics now fixed or on track to be fixed in all affected stable/longterm branches: https://lore.kernel.org/all/ZdgyEfNsev8WGIl5@eldamar.lan/
If I got this wrong and that's not the case, please holler.
#regzbot resolve: apparently fixed in all affected stable/longterm branches with various commits #regzbot ignore-activity
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr That page also explains what to do if mails like this annoy you.
We are seeing CIFS mount failures after upgrading from v5.15.148 to v5.15.149, I have reverted eb3e28c1e8 ("smb3: Replace smb2pdu 1-element arrays with flex-arrays") and I no longer see the regression. It looks like the issue is also impacting v5.10.y as the mentioned reverted patch has also been merged to v5.10.210. I am currently running the CIFS mount test manually and will update the thread with the exact mount failure error. I think we should revert eb3e28c1e8 ("smb3: Replace smb2pdu 1-element arrays with flex-arrays") from both v5.15.y & v5.10.y until we come up with a proper fix on this versions, please note that if we will take this path then we will need to re-introduce. b3632baa5045 ("cifs: fix off-by-one in SMB2_query_info_init()") which has been removed from latest v5.10.y and v5.15.y releases.
Please send this as a patch series, in a new thread, so we can properly track this, we have too many different threads here (and the subject line is wrong...)
thanks,
greg k-h
On 26/02/2024 14:55, gregkh@linuxfoundation.org wrote:
Please send this as a patch series, in a new thread, so we can properly track this, we have too many different threads here (and the subject line is wrong...)
thanks,
greg k-h
Thanks Greg and apologize for the noise, I figured out that this has something to do with our test environment setup. I have redone the test manually and a looks good so I'd say we can close this thread for now :)
Hazem
linux-stable-mirror@lists.linaro.org
-
gregkh＠linuxfoundation.org -
Harshit Mogalapalli -
kovalev＠altlinux.org -
Linux regression tracking #update (Thorsten Leemhuis) -
Linux regression tracking (Thorsten Leemhuis)
-
Mohamed Abuelfotoh, Hazem -
Paulo Alcantara -
Salvatore Bonaccorso -
SeongJae Park