From: Mohammad Athari Bin Ismail mohammad.athari.ismail@intel.com
Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE workqueue during suspend. So, in suspend mode, there will be no FPE workqueue available. Without this fix, new additional FPE workqueue will be created in every suspend->resume cycle.
Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure") Signed-off-by: Mohammad Athari Bin Ismail mohammad.athari.ismail@intel.com --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index c87202cbd3d6..796ad594543d 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -7170,6 +7170,7 @@ int stmmac_suspend(struct device *dev) priv->plat->rx_queues_to_use, false);
stmmac_fpe_handshake(priv, false); + stmmac_fpe_stop_wq(priv); }
priv->speed = SPEED_UNKNOWN;
On Wed, Jun 30, 2021 at 05:17:54PM +0800, mohammad.athari.ismail@intel.com wrote:
From: Mohammad Athari Bin Ismail mohammad.athari.ismail@intel.com
Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE workqueue during suspend. So, in suspend mode, there will be no FPE workqueue available. Without this fix, new additional FPE workqueue will be created in every suspend->resume cycle.
Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure") Signed-off-by: Mohammad Athari Bin Ismail mohammad.athari.ismail@intel.com
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1 file changed, 1 insertion(+)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
-----Original Message----- From: Greg KH gregkh@linuxfoundation.org Sent: Wednesday, June 30, 2021 5:32 PM To: Ismail, Mohammad Athari mohammad.athari.ismail@intel.com Cc: Alexandre Torgue alexandre.torgue@st.com; Jose Abreu joabreu@synopsys.com; David S . Miller davem@davemloft.net; Jakub Kicinski kuba@kernel.org; Giuseppe Cavallaro peppe.cavallaro@st.com; Maxime Coquelin mcoquelin.stm32@gmail.com; Ong, Boon Leong boon.leong.ong@intel.com; Voon, Weifeng weifeng.voon@intel.com; Tan, Tee Min tee.min.tan@intel.com; netdev@vger.kernel.org; linux- kernel@vger.kernel.org; stable@vger.kernel.org Subject: Re: [PATCH net] net: stmmac: Terminate FPE workqueue in suspend
On Wed, Jun 30, 2021 at 05:17:54PM +0800, mohammad.athari.ismail@intel.com wrote:
From: Mohammad Athari Bin Ismail mohammad.athari.ismail@intel.com
Add stmmac_fpe_stop_wq() in stmmac_suspend() to terminate FPE workqueue during suspend. So, in suspend mode, there will be no FPE workqueue available. Without this fix, new additional FPE workqueue will be created in every suspend->resume cycle.
Fixes: 5a5586112b92 ("net: stmmac: support FPE link partner hand-shaking procedure") Signed-off-by: Mohammad Athari Bin Ismail
mohammad.athari.ismail@intel.com
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 1 + 1 file changed, 1 insertion(+)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
I'm sorry. Will follow the correct process. Thank you for the advice.
-Athari-
linux-stable-mirror@lists.linaro.org
-
Greg KH -
Ismail, Mohammad Athari -
mohammad.athari.ismail＠intel.com