Hi,
Please include commit be80e9cdbca8 ("libbpf: Rename DECLARE_LIBBPF_OPTS into LIBBPF_OPTS") to the 5.15 stable branch.
Commit 3eefb2fbf4ec ("selftests/bpf: Test tail call counting with bpf2bpf and data on stack") introduced in v5.15.39 is dependent on it, and now building selftests fails with:
... linux/tools/testing/selftests/bpf/prog_tests/tailcalls.c: In function ‘test_tailcall_bpf2bpf_6’: linux/tools/testing/selftests/bpf/prog_tests/tailcalls.c:822:9: warning: implicit declaration of function ‘LIBBPF_OPTS’; did you mean ‘LIBBPF_API’? [-Wimplicit-function-declaration] 822 | LIBBPF_OPTS(bpf_test_run_opts, topts, | ^~~~~~~~~~~ | LIBBPF_API linux/tools/testing/selftests/bpf/prog_tests/tailcalls.c:822:21: error: ‘bpf_test_run_opts’ undeclared (first use in this function) 822 | LIBBPF_OPTS(bpf_test_run_opts, topts, | ^~~~~~~~~~~~~~~~~ linux/tools/testing/selftests/bpf/prog_tests/tailcalls.c:822:21: note: each undeclared identifier is reported only once for each function it appears in linux/tools/testing/selftests/bpf/prog_tests/tailcalls.c:822:40: error: ‘topts’ undeclared (first use in this function) 822 | LIBBPF_OPTS(bpf_test_run_opts, topts, | ^~~~~ tools/testing/selftests/bpf/prog_tests/tailcalls.c:823:17: error: expected expression before ‘.’ token 823 | .data_in = &pkt_v4, | ^ ...
Thanks in advance, Roxana
On Thu, Feb 22, 2024 at 05:02:19PM +0100, Roxana Nicolescu wrote:
Hi,
Please include commit be80e9cdbca8 ("libbpf: Rename DECLARE_LIBBPF_OPTS into LIBBPF_OPTS") to the 5.15 stable branch.
Commit 3eefb2fbf4ec ("selftests/bpf: Test tail call counting with bpf2bpf and data on stack") introduced in v5.15.39 is dependent on it, and now building selftests fails with:
Does 5.15.149 still need this? We fixed up something like this in that release.
If not, let us know and I'll add this.
thanks,
greg k-h
On 23/02/2024 14:03, Greg KH wrote:
On Thu, Feb 22, 2024 at 05:02:19PM +0100, Roxana Nicolescu wrote:
Hi,
Please include commit be80e9cdbca8 ("libbpf: Rename DECLARE_LIBBPF_OPTS into LIBBPF_OPTS") to the 5.15 stable branch.
Commit 3eefb2fbf4ec ("selftests/bpf: Test tail call counting with bpf2bpf and data on stack") introduced in v5.15.39 is dependent on it, and now building selftests fails with:
Does 5.15.149 still need this? We fixed up something like this in that release.
If not, let us know and I'll add this.
thanks,
greg k-h
Hi,
The test was reverted in 149. I did not see that. All good!
Thanks, Roxana
linux-stable-mirror@lists.linaro.org