Since 'bcs->Residue' has the data type '__le32', we must convert it to the correct byte order of the CPU using this driver when assigning it to the local variable 'residue'.
Cc: stable@vger.kernel.org Fixes: 50a6cb932d5c ("USB: usb_storage: add ums-realtek driver") Suggested-by: Alan Stern stern@rowland.harvard.edu Signed-off-by: Thorsten Blum thorsten.blum@linux.dev --- drivers/usb/storage/realtek_cr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index 8a4d7c0f2662..758258a569a6 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -253,7 +253,7 @@ static int rts51x_bulk_transport(struct us_data *us, u8 lun, return USB_STOR_TRANSPORT_ERROR; }
- residue = bcs->Residue; + residue = le32_to_cpu(bcs->Residue); if (bcs->Tag != us->tag) return USB_STOR_TRANSPORT_ERROR;
On Wed, Aug 13, 2025 at 12:12:51PM +0200, Thorsten Blum wrote:
Since 'bcs->Residue' has the data type '__le32', we must convert it to the correct byte order of the CPU using this driver when assigning it to the local variable 'residue'.
Cc: stable@vger.kernel.org Fixes: 50a6cb932d5c ("USB: usb_storage: add ums-realtek driver") Suggested-by: Alan Stern stern@rowland.harvard.edu Signed-off-by: Thorsten Blum thorsten.blum@linux.dev
drivers/usb/storage/realtek_cr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/storage/realtek_cr.c b/drivers/usb/storage/realtek_cr.c index 8a4d7c0f2662..758258a569a6 100644 --- a/drivers/usb/storage/realtek_cr.c +++ b/drivers/usb/storage/realtek_cr.c @@ -253,7 +253,7 @@ static int rts51x_bulk_transport(struct us_data *us, u8 lun, return USB_STOR_TRANSPORT_ERROR; }
- residue = bcs->Residue;
- residue = le32_to_cpu(bcs->Residue); if (bcs->Tag != us->tag) return USB_STOR_TRANSPORT_ERROR;
Acked-by: Alan Stern stern@rowland.harvard.edu
On Wed, Aug 13, 2025 at 12:12:51PM +0200, Thorsten Blum wrote:
Since 'bcs->Residue' has the data type '__le32', we must convert it to the correct byte order of the CPU using this driver when assigning it to the local variable 'residue'.
Cc: stable@vger.kernel.org
When you have a bugfix, don't put it last in the patch series, as that doesn't make much sense if you want to backport it anywhere, like you are asking to do here.
Please just send this as a separate patch, and do the cleanups in a different series.
thanks,
greg k-h
On 13. Aug 2025, at 16:39, Greg Kroah-Hartman wrote:
On Wed, Aug 13, 2025 at 12:12:51PM +0200, Thorsten Blum wrote:
Since 'bcs->Residue' has the data type '__le32', we must convert it to the correct byte order of the CPU using this driver when assigning it to the local variable 'residue'.
Cc: stable@vger.kernel.org
When you have a bugfix, don't put it last in the patch series, as that doesn't make much sense if you want to backport it anywhere, like you are asking to do here.
Please just send this as a separate patch, and do the cleanups in a different series.
Ok, you can find it here:
https://lore.kernel.org/lkml/20250813145247.184717-3-thorsten.blum@linux.dev...
Thanks, Thorsten
linux-stable-mirror@lists.linaro.org
-
Alan Stern -
Greg Kroah-Hartman -
Thorsten Blum