From: Pawel Laszczak pawell@cadence.com
For delayed status phase, the usb_gadget->state was set to USB_STATE_ADDRESS and it has never been updated to USB_STATE_CONFIGURED. Patch updates the gadget state to correct USB_STATE_CONFIGURED. As a result of this bug the controller was not able to enter to Test Mode while using MSC function.
Cc: stable@vger.kernel.org Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") Signed-off-by: Pawel Laszczak pawell@cadence.com --- drivers/usb/cdns3/cdns3-ep0.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/usb/cdns3/cdns3-ep0.c b/drivers/usb/cdns3/cdns3-ep0.c index 9a17802275d5..ec5bfd8944c3 100644 --- a/drivers/usb/cdns3/cdns3-ep0.c +++ b/drivers/usb/cdns3/cdns3-ep0.c @@ -731,6 +731,7 @@ static int cdns3_gadget_ep0_queue(struct usb_ep *ep, request->actual = 0; priv_dev->status_completion_no_call = true; priv_dev->pending_status_request = request; + usb_gadget_set_state(&priv_dev->gadget, USB_STATE_CONFIGURED); spin_unlock_irqrestore(&priv_dev->lock, flags);
/*
On Wed, Jun 23, 2021 at 08:54:26AM +0200, Pawel Laszczak wrote:
From: Pawel Laszczak pawell@cadence.com
For delayed status phase, the usb_gadget->state was set to USB_STATE_ADDRESS and it has never been updated to USB_STATE_CONFIGURED. Patch updates the gadget state to correct USB_STATE_CONFIGURED. As a result of this bug the controller was not able to enter to Test Mode while using MSC function.
Cc: stable@vger.kernel.org Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") Signed-off-by: Pawel Laszczak pawell@cadence.com
drivers/usb/cdns3/cdns3-ep0.c | 1 + 1 file changed, 1 insertion(+)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly.
</formletter>
On Wed, Jun 23, 2021 at 08:54:26AM +0200, Pawel Laszczak wrote:
From: Pawel Laszczak pawell@cadence.com
For delayed status phase, the usb_gadget->state was set to USB_STATE_ADDRESS and it has never been updated to USB_STATE_CONFIGURED. Patch updates the gadget state to correct USB_STATE_CONFIGURED. As a result of this bug the controller was not able to enter to Test Mode while using MSC function.
Cc: stable@vger.kernel.org Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver") Signed-off-by: Pawel Laszczak pawell@cadence.com
drivers/usb/cdns3/cdns3-ep0.c | 1 + 1 file changed, 1 insertion(+)
<formletter>
This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://urldefense.com/v3/__https://www.kernel.org/doc/html/latest/process/s... rules.html__;!!EHscmS1ygiU1lA!XxaV_glFP_ZgaIhiOKJKx4mZ-8nVVerjwA9heaOgDrhVCXF7fwUSsF9nMg8B8Q$ for how to do this properly.
</formletter>
Yes, I know, sorry about that. Patch has been sent again in correct way.
Regards, Pawel
linux-stable-mirror@lists.linaro.org