Linaro-acpi

linaro-acpi@lists.linaro.org

820 discussions

leg-kernel tag leg-20160201.0 released

by Graeme Gregory

The leg-kernel release has been made and tagged as leg-201600201.0 This is based on mainline kernel v4.4 Repository : http://git.linaro.org/leg/acpi/leg-kernel.git Direct Link: http://git.linaro.org/leg/acpi/leg-kernel.git/commit/adca6ee4e1e1581ff1612e… Topic Branches :- http://git.linaro.org/leg/acpi/acpi.git - topic-pci [topic-pci-20160122.0] - topic-numa [topic-numa-20160122.0] - topic-amba-probing [topic-amba-probing-20160122.0] - topic-acpi-console [topic-acpi-console-20160201.0] - topic-gtdt-wakeup-timer [topic-gtdt-wakeup-timer-20160201.0] - topic-fvp [topic-fvp-20160122.0] - topic-kvm-acpi [topic-kvm-acpi-20160122.0] - topic-sbsa-watchdog [topic-acpi-watchdog-20160122.0] - topic-apei [topic-apei-20160122.0] http://git.linaro.org/leg/acpi/leg-kernel.git - leg-configs [leg-configs-20160122.0] NOTES:-

8 years, 8 months

topic-pci branch on Mustang

by Itaru Kitayama

Hi, Has anyone successfully brought up the topic-pci branch kernel with acpi=force on Mustang? The boot is stalled in the middle of it. [ 0.000000] Booting Linux on physical CPU 0x0 [ 0.000000] Initializing cgroup subsys cpuset [ 0.000000] Initializing cgroup subsys cpu [ 0.000000] Initializing cgroup subsys cpuacct [ 0.000000] Linux version 4.4.0-rc1+ (itaru.kitayama(a)localhost.localdomain) (gcc version 5.3.1 20151207 (Red Hat 5.3.1-2) (GCC) ) #1 SMP Sun Jan 24 19:22:32 CST 2016 [ 0.000000] Boot CPU: AArch64 Processor [500f0001] [ 0.000000] earlycon: Early serial console at MMIO32 0x1c020000 (options '') [ 0.000000] bootconsole [uart0] enabled [ 0.000000] efi: Getting EFI parameters from FDT: [ 0.000000] EFI v2.40 by X-Gene Mustang Board EFI Nov 24 2015 13:22:41 [ 0.000000] efi: ACPI=0x47fa869000 ACPI 2.0=0x47fa869014 SMBIOS 3.0=0x47fa867000 [ 0.000000] cma: Reserved 512 MiB at 0x00000040e0000000 [ 0.000000] ACPI: Early table checksum verification disabled [ 0.000000] ACPI: RSDP 0x00000047FA869014 000024 (v02 APM ) [ 0.000000] ACPI: XSDT 0x00000047FA8680E8 00006C (v01 APM XGENE 00000003 01000013) [ 0.000000] ACPI: FACP 0x00000047FA85F000 00010C (v05 APM XGENE 00000003 INTL 20140724) [ 0.000000] ACPI: DSDT 0x00000047FA860000 00495F (v05 APM APM88xxx 00000001 INTL 20140724) [ 0.000000] ACPI: DBG2 0x00000047FA865000 0000AA (v00 APMC0D XGENEDBG 00000000 INTL 20140724) [ 0.000000] ACPI: GTDT 0x00000047FA85D000 0000E0 (v02 APM XGENE 00000001 INTL 20140724) [ 0.000000] ACPI: MCFG 0x00000047FA85C000 00003C (v01 APM XGENE 00000002 INTL 20140724) [ 0.000000] ACPI: SPCR 0x00000047FA85B000 000050 (v02 APMC0D XGENESPC 00000000 INTL 20140724) [ 0.000000] ACPI: SSDT 0x00000047FA85A000 00002D (v02 APM XGENE 00000001 INTL 20140724) [ 0.000000] ACPI: APIC 0x00000047FA859000 0002A4 (v03 APM XGENE 00000003 01000013) [ 0.000000] ACPI: SSDT 0x00000047FA858000 000078 (v02 REDHAT MACADDRS 00000001 01000013) [ 0.000000] ACPI: SSDT 0x00000047FA857000 000032 (v02 REDHAT UARTCLKS 00000001 01000013) [ 0.000000] psci: is not implemented in ACPI. [ 0.000000] Unsupported ACPI enable-method [ 0.000000] Unsupported ACPI enable-method [ 0.000000] Unsupported ACPI enable-method [ 0.000000] Unsupported ACPI enable-method [ 0.000000] Unsupported ACPI enable-method [ 0.000000] Unsupported ACPI enable-method [ 0.000000] Unsupported ACPI enable-method [ 0.000000] Unsupported ACPI enable-method [ 0.000000] PERCPU: Embedded 2 pages/cpu @fffffe07fff90000 s90496 r8192 d32384 u131072 [ 0.000000] Detected PIPT I-cache on CPU0 [ 0.000000] Built 1 zonelists in Zone order, mobility grouping on. Total pages: 523776 [ 0.000000] Kernel command line: BOOT_IMAGE=/vmlinuz-4.4.0-rc1+ root=UUID=0e305934-49d5-4f66-b10b-23ec6029fab9 ro acpi=force earlycon=uart8250,mmio32,0x1c020000 console=ttyS0,115200 [ 0.000000] PID hash table entries: 4096 (order: -1, 32768 bytes) [ 0.000000] Dentry cache hash table entries: 4194304 (order: 9, 33554432 bytes) [ 0.000000] Inode-cache hash table entries: 2097152 (order: 8, 16777216 bytes) [ 0.000000] software IO TLB [mem 0x40dbff0000-0x40dfff0000] (64MB) mapped at [fffffe00dbff0000-fffffe00dffeffff] [ 0.000000] Memory: 32851584K/33554432K available (7946K kernel code, 1243K rwdata, 5056K rodata, 832K init, 1460K bss, 178560K reserved, 524288K cma-reserved) [ 0.000000] Virtual kernel memory layout: [ 0.000000] vmalloc : 0xfffffc0000000000 - 0xfffffdfedfff0000 ( 2043 GB) [ 0.000000] vmemmap : 0xfffffdfee0000000 - 0xfffffdffe0000000 ( 4 GB maximum) [ 0.000000] 0xfffffdfef0000000 - 0xfffffdfef2000000 ( 32 MB actual) [ 0.000000] fixed : 0xfffffdfffa7d0000 - 0xfffffdfffac00000 ( 4288 KB) [ 0.000000] PCI I/O : 0xfffffdfffae00000 - 0xfffffdfffbe00000 ( 16 MB) [ 0.000000] modules : 0xfffffdfffc000000 - 0xfffffe0000000000 ( 64 MB) [ 0.000000] memory : 0xfffffe0000000000 - 0xfffffe0800000000 ( 32768 MB) [ 0.000000] .init : 0xfffffe0000d50000 - 0xfffffe0000e20000 ( 832 KB) [ 0.000000] .text : 0xfffffe0000080000 - 0xfffffe0000d42bf4 ( 13067 KB) [ 0.000000] .data : 0xfffffe0000e30000 - 0xfffffe0000f66c00 ( 1243 KB) [ 0.000000] SLUB: HWalign=64, Order=0-3, MinObjects=0, CPUs=1, Nodes=1 [ 0.000000] Hierarchical RCU implementation. [ 0.000000] Build-time adjustment of leaf fanout to 64. [ 0.000000] RCU restricting CPUs from NR_CPUS=8 to nr_cpu_ids=1. [ 0.000000] RCU: Adjusting geometry for rcu_fanout_leaf=64, nr_cpu_ids=1 [ 0.000000] NR_IRQS:64 nr_irqs:64 0 [ 0.000000] GIC: Using split EOI/Deactivate mode [ 0.000000] Architected cp15 timer(s) running at 50.00MHz (phys). [ 0.000000] clocksource: arch_sys_counter: mask: 0xffffffffffffff max_cycles: 0xb8812736b, max_idle_ns: 440795202655 ns [ 0.000002] sched_clock: 56 bits at 50MHz, resolution 20ns, wraps every 4398046511100ns [ 0.008541] Console: colour dummy device 80x25 [ 0.013235] Calibrating delay loop (skipped), value calculated using timer frequency.. 100.00 BogoMIPS (lpj=200000) [ 0.024283] pid_max: default: 32768 minimum: 301 [ 0.029180] ACPI: Core revision 20150930 [ 0.040671] ACPI: 4 ACPI AML tables successfully acquired and loaded [ 0.047439] Security Framework initialized [ 0.051756] Yama: becoming mindful. [ 0.055437] SELinux: Initializing. [ 0.059198] Mount-cache hash table entries: 65536 (order: 3, 524288 bytes) [ 0.066486] Mountpoint-cache hash table entries: 65536 (order: 3, 524288 bytes) [ 0.074654] Initializing cgroup subsys io [ 0.078888] Initializing cgroup subsys memory [ 0.083485] Initializing cgroup subsys devices [ 0.088190] Initializing cgroup subsys freezer [ 0.092885] Initializing cgroup subsys net_cls [ 0.097589] Initializing cgroup subsys perf_event [ 0.102552] Initializing cgroup subsys net_prio [ 0.107366] ftrace: allocating 27761 entries in 7 pages [ 0.132043] Remapping and enabling EFI services. [ 0.136940] EFI remap 0x0000000010510000 => 0000000040000000 [ 0.143127] EFI remap 0x0000000010548000 => 0000000040018000 [ 0.149290] EFI remap 0x0000000017000000 => 0000000040020000 [ 0.155453] EFI remap 0x000000001c025000 => 0000000040035000 [ 0.161616] EFI remap 0x000000007c0c0000 => 0000000040040000 [ 0.167779] EFI remap 0x000000007c1c0000 => 0000000040050000 [ 0.173942] EFI remap 0x000000007c2c0000 => 0000000040060000 [ 0.180104] EFI remap 0x000000007c3c0000 => 0000000040070000 [ 0.186266] EFI remap 0x000000007c4c0000 => 0000000040080000 [ 0.192438] EFI remap 0x000000007c5c0000 => 0000000040090000 [ 0.198600] EFI remap 0x000000007c6c0000 => 00000000400a0000 [ 0.204781] EFI remap 0x000000007c7c0000 => 00000000400b0000 [ 0.210961] EFI remap 0x00000047fa856000 => 00000000400c6000 [ 0.217141] EFI remap 0x00000047fa86a000 => 00000000400da000 [ 0.223314] EFI remap 0x00000047ffa12000 => 00000000402c2000 [ 0.229477] EFI remap 0x00000047ffa26000 => 00000000402d6000 [ 0.235646] ASID allocator initialised with 65536 entries [ 0.241999] Brought up 1 CPUs [ 0.245123] SMP: Total of 1 processors activated. [ 0.250087] CPU: All CPU(s) started at EL2 [ 0.254729] devtmpfs: initialized [ 0.258522] SMBIOS 3.0.0 present. [ 0.262069] clocksource: jiffies: mask: 0xffffffff max_cycles: 0xffffffff, max_idle_ns: 7645041785100000 ns [ 0.272746] atomic64_test: passed [ 0.276444] NET: Registered protocol family 16 [ 0.281343] PCCT header not found. [ 0.284973] vdso: 2 pages (1 code @ fffffe0000e50000, 1 data @ fffffe0000e40000) [ 0.292807] hw-breakpoint: found 4 breakpoint and 4 watchpoint registers. [ 0.300274] DMA: preallocated 256 KiB pool for atomic allocations [ 0.306735] ACPI: bus type PCI registered [ 0.310955] acpiphp: ACPI Hot Plug PCI Controller Driver version: 0.5 [ 0.317819] Serial: AMBA PL011 UART driver [ 0.324731] ACPI: Added _OSI(Module Device) [ 0.329151] ACPI: Added _OSI(Processor Device) [ 0.333845] ACPI: Added _OSI(3.0 _SCP Extensions) [ 0.338825] ACPI: Added _OSI(Processor Aggregator Device) [ 0.354649] ACPI: Interpreter enabled [ 0.358516] ACPI: Using GIC for interrupt routing [ 0.366406] ACPI: Power Resource [SCVR] (off) [ 0.379267] ACPI: PCI Root Bridge [PCI0] (domain 0000 [bus 00-ff]) [ 0.385823] acpi PNP0A08:00: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI] [ 0.394877] acpi PNP0A08:00: _OSC: OS now controls [PCIeHotplug PME AER PCIeCapability] [ 0.403349] acpi PNP0A08:00: Bus 0000:00 not present in PCI namespace [ 0.410745] vgaarb: loaded [ 0.413725] SCSI subsystem initialized [ 0.417770] ACPI: bus type USB registered [ 0.422021] usbcore: registered new interface driver usbfs [ 0.427843] usbcore: registered new interface driver hub [ 0.433491] usbcore: registered new device driver usb [ 0.439181] NetLabel: Initializing [ 0.442753] NetLabel: domain hash size = 128 [ 0.447352] NetLabel: protocols = UNLABELED CIPSOv4 [ 0.452606] NetLabel: unlabeled traffic allowed by default [ 0.458590] clocksource: Switched to clocksource arch_sys_counter [ 0.481347] pnp: PnP ACPI init [ 0.485318] pnp: PnP ACPI: found 0 devices [ 0.492409] NET: Registered protocol family 2 [ 0.497199] TCP established hash table entries: 262144 (order: 5, 2097152 bytes) [ 0.505681] TCP bind hash table entries: 65536 (order: 4, 1048576 bytes) [ 0.513141] TCP: Hash tables configured (established 262144 bind 65536) [ 0.520153] UDP hash table entries: 16384 (order: 3, 524288 bytes) [ 0.526945] UDP-Lite hash table entries: 16384 (order: 3, 524288 bytes) [ 0.534305] NET: Registered protocol family 1 [ 0.539050] RPC: Registered named UNIX socket transport module. [ 0.545309] RPC: Registered udp transport module. [ 0.550288] RPC: Registered tcp transport module. [ 0.555267] RPC: Registered tcp NFSv4.1 backchannel transport module. [ 0.562172] Unpacking initramfs... [ 0.801177] Freeing initrd memory: 10368K (fffffe07f8bf0000 - fffffe07f9610000) [ 0.809067] kvm [1]: error: no compatible GIC node found [ 0.814743] kvm [1]: error initializing Hyp mode: -19 [ 0.820381] futex hash table entries: 256 (order: -1, 32768 bytes) [ 0.826932] audit: initializing netlink subsys (disabled) [ 0.832659] audit: type=2000 audit(0.004:1): initialized [ 0.838583] HugeTLB registered 512 MB page size, pre-allocated 0 pages [ 0.848211] zbud: loaded [ 0.851033] VFS: Disk quotas dquot_6.6.0 [ 0.855250] VFS: Dquot-cache hash table entries: 8192 (order 0, 65536 bytes) [ 0.863482] NFS: Registering the id_resolver key type [ 0.868844] Key type id_resolver registered [ 0.873261] Key type id_legacy registered [ 0.877503] nfs4filelayout_init: NFSv4 File Layout Driver Registering... [ 0.884797] Key type big_key registered [ 0.892586] NET: Registered protocol family 38 [ 0.897363] Block layer SCSI generic (bsg) driver version 0.4 loaded (major 252) [ 0.905217] io scheduler noop registered [ 0.909351] io scheduler deadline registered [ 0.913910] io scheduler cfq registered (default) [ 0.919094] pci_hotplug: PCI Hot Plug PCI Core version: 0.5 [ 0.924982] pciehp: PCI Express Hot Plug Controller Driver version: 0.4 [ 0.932276] Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled

8 years, 8 months

leg-kernel tag leg-20160122.0 released

by Graeme Gregory

The leg-kernel release has been made and tagged as leg-20160122.0 This is based on mainline kernel v4.4 Repository : http://git.linaro.org/leg/acpi/leg-kernel.git Direct Link: http://git.linaro.org/leg/acpi/leg-kernel.git/commit/adca6ee4e1e1581ff1612e… Topic Branches :- http://git.linaro.org/leg/acpi/acpi.git - topic-pci [topic-pci-20160122.0] - topic-numa [topic-numa-20160122.0] - topic-amba-probing [topic-amba-probing-20160122.0] - topic-acpi-console [topic-acpi-console-20160122.0] - topic-gtdt-wakeup-timer [topic-gtdt-wakeup-timer-20160122.0] - topic-fvp [topic-fvp-20160122.0] - topic-kvm-acpi [topic-kvm-acpi-20160122.0] - topic-sbsa-watchdog [topic-acpi-watchdog-20160122.0] - topic-apei [topic-apei-20160122.0] http://git.linaro.org/leg/acpi/leg-kernel.git - leg-configs [leg-configs-20160122.0] NOTES:-

8 years, 8 months

[PATCH 0/5] Update ACPI RSDP tests to be specification compliant

by Al Stone

Add in several tests that extend the testing done on the RSDP. If these tests are all passed, the RSDP being examined should be compliant with the ACPI 6.0 spec. As part of that, when creating a dummy RSDP to substitute for one that cannot be read or found, use either RsdtAddress or XsdtAddress as described in the spec. For non-arm64, either can be used, but for arm64, only the XsdtAddress is to be used. Finally, update the regression tests for RSDP. Al Stone (5): RSDP: minor cleanups to rsdp.c for checkpatch issues utilities: add a helper function for printing out architecture names ACPI tables: when bodging up an RSDP, do the right thing for the arch ACPI RSDP: flesh out the tests to check for full spec compliance. Update regression test rsdp-0001/test-0001.sh fwts-test/rsdp-0001/rsdp.log | 16 ++++- src/acpi/rsdp/rsdp.c | 139 ++++++++++++++++++++++++++++++++++++----- src/lib/include/fwts_arch.h | 1 + src/lib/src/fwts_acpi_tables.c | 19 +++--- src/lib/src/fwts_arch.c | 18 ++++++ 5 files changed, 169 insertions(+), 24 deletions(-) -- 2.5.0

8 years, 8 months

[PATCH 0/7] Update several regression tests

by Al Stone

I should have added these earlier, but I did not. So, here they are: the updates to the regression tests affected by adding the --arch parameter, and by updating the MADT tests. Al Stone (7): Update the regression test arg-help-0001/test-0001.sh Update regression test for arg-help-0001/test-0002.sh Update regression test for arg-show-tests-0001/test-0001.sh Update regression test arg-show-tests-full-0001/test-0001.sh Update the regression test arg-table-path-0001/test-0001.sh Update the regression test madt-0001/test-0001.sh Update the regression test madt-0001/test-0002.sh fwts-test/arg-help-0001/arg-help-0001.log | 4 + fwts-test/arg-help-0001/arg-help-0002.log | 4 + .../arg-show-tests-0001/arg-show-tests-0001.log | 8 +- .../arg-show-tests-full-0001.log | 26 +- fwts-test/arg-table-path-0001/acpidump-0001.log | 741 +++++++++------------ fwts-test/madt-0001/madt-0001.log | 10 +- fwts-test/madt-0001/madt-0002.log | 33 +- 7 files changed, 344 insertions(+), 482 deletions(-) -- 2.5.0

8 years, 8 months

[PATCH v3 0/6] ACPI compliance testing for MADT and its subtables

by Al Stone

This patch series adds in specific ACPI compliance testing for the MADT and all of its various subtables (16, currently). The first three patches add in the idea of host and target architectures -- host being the arch that FWTS is running on, and target the arch whose firmware is being tested. This is needed later in the MADT tests since what is proper changes based on the architecture the firmware supports. The fourth patch adds the detailed tests for the MADT and all but one of the subtables currently defined in ACPI 6.0. The last two patches add in the relatively new GIC ITS subtable and compliance tests for it. There are still multiple TODOs in the compliance checks; these will be added as clarification of the spec becomes available. Changes for v3: -- Add in support for the --arch=<name> parameter to specify the arch for the target firmware (default is that host == target). -- Add in the fwts_architecture typedef plus some helper functions so that tests in the future can adapt their behavior as needed, and so that the MADT tests can set themselves up properly. -- Instead of creating a new sourc file src/acpi/compliance/madt.c, replace the existing src/acpi/madt/madt.c tests since we're providing a superset. -- Various minor style and syntax corrections (from Ian Colin King) Changes for v2: -- Clean up the white space problems -- Fix errors found by checkpatch (minor syntax things) -- Fix one logic error: while MADT and FADT table revisions *should* be in sync, they seldom are, so report this as a test failure and continue to test as much as possible instead of aborting completely, in some of those cases. Al Stone (6): Start defining FWTS architectures as variables Define some utility functions for using the fwts_architecture enum Add mechanism to tell FWTS what architecture is being tested ACPI: MADT: add in compliance tests for the MADT and subtables ACPI: Add in MADT subtable description for GIC ITS subtable ACPI: MADT: add in compliance checks for the GIC ITS subtable src/acpi/madt/madt.c | 1551 +++++++++++++++++++++++++++++++------- src/lib/include/fwts.h | 1 + src/lib/include/fwts_acpi.h | 10 + src/lib/include/fwts_arch.h | 41 + src/lib/include/fwts_framework.h | 3 + src/lib/src/Makefile.am | 1 + src/lib/src/fwts_arch.c | 88 +++ src/lib/src/fwts_framework.c | 25 + 8 files changed, 1460 insertions(+), 260 deletions(-) create mode 100644 src/lib/include/fwts_arch.h create mode 100644 src/lib/src/fwts_arch.c -- 2.5.0

8 years, 8 months

[PATCH 0/4] acpi: cppc optimization patches

by Prashanth Prakash

This series introduces changes to reduce the time required to send a frequency transition requests to the platform while using the cppc-cpufreq driver. With these changes we see significant improvement in the average time to send freq. transition request to the platform. Profiling on an ARM platform showed that the average transaction time per request reduced from 200us to under 20us. Ashwin Chaugule (1): ACPI / CPPC: Optimize PCC Read Write operations Prashanth Prakash (3): acpi: cppc: optimized cpc_read and cpc_write mailbox: pcc: optimized pcc_send_data acpi: cppc: replace writeX/readX to PCC with relaxed version drivers/acpi/cppc_acpi.c | 184 +++++++++++++++++++++++++++++++++++------------ drivers/mailbox/pcc.c | 110 ++++++++++++++++++++++++++-- 2 files changed, 241 insertions(+), 53 deletions(-) -- Qualcomm Technologies, Inc. on behalf of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.

8 years, 8 months

[PATCH 0/2] fwts man page updates

by Al Stone

Update the fwts man page to include some new parameters. Al Stone (2): Documentation: add --acpicompliance to man page Documentation: add --arch to the man page doc/fwts.1 | 11 +++++++++++ 1 file changed, 11 insertions(+) -- 2.5.0

8 years, 8 months

[PATCH v5] acpi, apei: add Boot Error Record Table (BERT) support

by fu.wei＠linaro.org

From: Huang Ying <ying.huang(a)intel.com> ACPI/APEI is designed to verifiy/report H/W errors, like Corrected Error(CE) and Uncorrected Error(UC). It contains four tables: HEST, ERST, EINJ and BERT. The first three tables have been merged for a long time, but because of lacking BIOS support for BERT, the support for BERT is pending until now. Recently on ARM 64 platform it is has been supported. So here we come. Under normal circumstances, when a hardware error occurs, kernel will be notified via NMI, MCE or some other method, then kernel will process the error condition, report it, and recover it if possible. But sometime, the situation is so bad, so that firmware may choose to reset directly without notifying Linux kernel. Linux kernel can use the Boot Error Record Table (BERT) to get the un-notified hardware errors that occurred in a previous boot. In this patch, the error information is reported via printk. For more information about BERT, please refer to ACPI Specification version 6.0, section 18.3.1: http://www.uefi.org/sites/default/files/resources/ACPI_6.0.pdf The following log is a BERT record after system reboot because of hitting a fatal memory error: BERT: Error records from previous boot: [Hardware Error]: It has been corrected by h/w and requires no further action [Hardware Error]: event severity: corrected [Hardware Error]: Error 0, type: recoverable [Hardware Error]: section_type: memory error [Hardware Error]: error_status: 0x0000000000000400 [Hardware Error]: physical_address: 0xffffffffffffffff [Hardware Error]: card: 1 module: 2 bank: 3 row: 1 column: 2 bit_position: 5 [Hardware Error]: error_type: 2, single-bit ECC [Tomasz Nowicki: Clear error status at the end of error handling] [Tony: Applied some cleanups suggested by Fu Wei] [Fu Wei: delete EXPORT_SYMBOL_GPL(bert_disable), improve the code] Signed-off-by: Huang Ying <ying.huang(a)intel.com> Signed-off-by: Tomasz Nowicki <tomasz.nowicki(a)linaro.org> Signed-off-by: Chen, Gong <gong.chen(a)linux.intel.com> Tested-by: Jonathan (Zhixiong) Zhang <zjzhang(a)codeaurora.org> Signed-off-by: Tony Luck <tony.luck(a)intel.com> Signed-off-by: Fu Wei <fu.wei(a)linaro.org> Tested-by: Tyler Baicar <tbaicar(a)codeaurora.org> --- Changelog: v5: Drop some superfluous comments. Use the introduce of BERT in ACPI Specification instead of original one at the head of bert.c. Fix typo in apei-internal.h Simplify the introduce of bert_disable. v4: https://lkml.org/lkml/2016/1/8/382 Fix the "#undef" bug Improve the instruction of "bert_disable", Delete the useless declaration in include/acpi/apei.h. v3: https://lkml.org/lkml/2016/1/7/214 Merge the two patches Do some improvements according to Borislav's suggestion. v2: https://lkml.org/lkml/2015/8/18/336 Delete EXPORT_SYMBOL_GPL(bert_disable), because "bert_disable" is only used in bert.c for now. Do some code-style cleanups. v1: The first upstream version submitted in linux-acpi mailing list: http://www.spinics.net/lists/linux-acpi/msg57384.html Documentation/kernel-parameters.txt | 3 + drivers/acpi/apei/Makefile | 2 +- drivers/acpi/apei/apei-internal.h | 2 +- drivers/acpi/apei/bert.c | 150 ++++++++++++++++++++++++++++++++++++ 4 files changed, 155 insertions(+), 2 deletions(-) diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 3ea869d..acb772e 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -564,6 +564,9 @@ bytes respectively. Such letter suffixes can also be entirely omitted. bootmem_debug [KNL] Enable bootmem allocator debug messages. + bert_disable [ACPI] + Disable BERT OS support on buggy BIOSes. + bttv.card= [HW,V4L] bttv (bt848 + bt878 based grabber cards) bttv.radio= Most important insmod options are available as kernel args too. diff --git a/drivers/acpi/apei/Makefile b/drivers/acpi/apei/Makefile index 5d575a9..e50573d 100644 --- a/drivers/acpi/apei/Makefile +++ b/drivers/acpi/apei/Makefile @@ -3,4 +3,4 @@ obj-$(CONFIG_ACPI_APEI_GHES) += ghes.o obj-$(CONFIG_ACPI_APEI_EINJ) += einj.o obj-$(CONFIG_ACPI_APEI_ERST_DEBUG) += erst-dbg.o -apei-y := apei-base.o hest.o erst.o +apei-y := apei-base.o hest.o erst.o bert.o diff --git a/drivers/acpi/apei/apei-internal.h b/drivers/acpi/apei/apei-internal.h index 16129c7..6e9f14c 100644 --- a/drivers/acpi/apei/apei-internal.h +++ b/drivers/acpi/apei/apei-internal.h @@ -1,6 +1,6 @@ /* * apei-internal.h - ACPI Platform Error Interface internal - * definations. + * definitions. */ #ifndef APEI_INTERNAL_H diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c new file mode 100644 index 0000000..a05b5c0 --- /dev/null +++ b/drivers/acpi/apei/bert.c @@ -0,0 +1,150 @@ +/* + * APEI Boot Error Record Table (BERT) support + * + * Copyright 2011 Intel Corp. + * Author: Huang Ying <ying.huang(a)intel.com> + * + * Under normal circumstances, when a hardware error occurs, the error + * handler receives control and processes the error. This gives OSPM a + * chance to process the error condition, report it, and optionally attempt + * recovery. In some cases, the system is unable to process an error. + * For example, system firmware or a management controller may choose to + * reset the system or the system might experience an uncontrolled crash + * or reset.The boot error source is used to report unhandled errors that + * occurred in a previous boot. This mechanism is described in the BERT + * table. + * + * For more information about BERT, please refer to ACPI Specification + * version 4.0, section 17.3.1 + * + * This file is licensed under GPLv2. + * + */ + +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/init.h> +#include <linux/acpi.h> +#include <linux/io.h> + +#include "apei-internal.h" + +#undef pr_fmt +#define pr_fmt(fmt) "BERT: " fmt + +static int bert_disable; + +static void __init bert_print_all(struct acpi_bert_region *region, + unsigned int region_len) +{ + struct acpi_hest_generic_status *estatus = + (struct acpi_hest_generic_status *)region; + int remain = region_len; + u32 estatus_len; + + if (!estatus->block_status) + return; + + while (remain > sizeof(struct acpi_bert_region)) { + if (cper_estatus_check(estatus)) { + pr_err(FW_BUG "Invalid error record.\n"); + return; + } + + estatus_len = cper_estatus_len(estatus); + if (remain < estatus_len) { + pr_err(FW_BUG "Truncated status block (length: %u).\n", + estatus_len); + return; + } + + pr_info_once("Error records from previous boot:\n"); + + cper_estatus_print(KERN_INFO HW_ERR, estatus); + + /* + * Because the boot error source is "one-time polled" type, + * clear Block Status of current Generic Error Status Block, + * once it's printed. + */ + estatus->block_status = 0; + + estatus = (void *)estatus + estatus_len; + /* No more error records. */ + if (!estatus->block_status) + return; + + remain -= estatus_len; + } +} + +static int __init setup_bert_disable(char *str) +{ + bert_disable = 1; + + return 0; +} +__setup("bert_disable", setup_bert_disable); + +static int __init bert_check_table(struct acpi_table_bert *bert_tab) +{ + if (bert_tab->header.length < sizeof(struct acpi_table_bert) || + bert_tab->region_length < sizeof(struct acpi_bert_region)) + return -EINVAL; + + return 0; +} + +static int __init bert_init(void) +{ + struct acpi_bert_region *boot_error_region; + struct acpi_table_bert *bert_tab; + unsigned int region_len; + acpi_status status; + int rc = 0; + + if (acpi_disabled) + return 0; + + if (bert_disable) { + pr_info("Boot Error Record Table support is disabled.\n"); + return 0; + } + + status = acpi_get_table(ACPI_SIG_BERT, 0, (struct acpi_table_header **)&bert_tab); + if (status == AE_NOT_FOUND) + return 0; + + if (ACPI_FAILURE(status)) { + pr_err("get table failed, %s.\n", acpi_format_exception(status)); + return -EINVAL; + } + + rc = bert_check_table(bert_tab); + if (rc) { + pr_err(FW_BUG "table invalid.\n"); + return rc; + } + + region_len = bert_tab->region_length; + if (!request_mem_region(bert_tab->address, region_len, "APEI BERT")) { + pr_err("Can't request iomem region <%016llx-%016llx>.\n", + (unsigned long long)bert_tab->address, + (unsigned long long)bert_tab->address + region_len - 1); + return -EIO; + } + + boot_error_region = ioremap_cache(bert_tab->address, region_len); + if (boot_error_region) { + bert_print_all(boot_error_region, region_len); + iounmap(boot_error_region); + } else { + rc = -ENOMEM; + } + + release_mem_region(bert_tab->address, region_len); + + return rc; +} + +late_initcall(bert_init); -- 2.5.0

8 years, 8 months

[PATCH v4] acpi, apei: add Boot Error Record Table (BERT) support

by fu.wei＠linaro.org

From: Huang Ying <ying.huang(a)intel.com> ACPI/APEI is designed to verifiy/report H/W errors, like Corrected Error(CE) and Uncorrected Error(UC). It contains four tables: HEST, ERST, EINJ and BERT. The first three tables have been merged for a long time, but because of lacking BIOS support for BERT, the support for BERT is pending until now. Recently on ARM 64 platform it is has been supported. So here we come. Under normal circumstances, when a hardware error occurs, kernel will be notified via NMI, MCE or some other method, then kernel will process the error condition, report it, and recover it if possible. But sometime, the situation is so bad, so that firmware may choose to reset directly without notifying Linux kernel. Linux kernel can use the Boot Error Record Table (BERT) to get the un-notified hardware errors that occurred in a previous boot. In this patch, the error information is reported via printk. For more information about BERT, please refer to ACPI Specification version 6.0, section 18.3.1: http://www.uefi.org/sites/default/files/resources/ACPI_6.0.pdf The following log is a BERT record after system reboot because of hitting a fatal memory error: BERT: Error records from previous boot: [Hardware Error]: It has been corrected by h/w and requires no further action [Hardware Error]: event severity: corrected [Hardware Error]: Error 0, type: recoverable [Hardware Error]: section_type: memory error [Hardware Error]: error_status: 0x0000000000000400 [Hardware Error]: physical_address: 0xffffffffffffffff [Hardware Error]: card: 1 module: 2 bank: 3 row: 1 column: 2 bit_position: 5 [Hardware Error]: error_type: 2, single-bit ECC [Tomasz Nowicki: Clear error status at the end of error handling] [Tony: Applied some cleanups suggested by Fu Wei] [Fu Wei: delete EXPORT_SYMBOL_GPL(bert_disable), improve the code] Signed-off-by: Huang Ying <ying.huang(a)intel.com> Signed-off-by: Tomasz Nowicki <tomasz.nowicki(a)linaro.org> Signed-off-by: Chen, Gong <gong.chen(a)linux.intel.com> Tested-by: Jonathan (Zhixiong) Zhang <zjzhang(a)codeaurora.org> Signed-off-by: Tony Luck <tony.luck(a)intel.com> Signed-off-by: Fu Wei <fu.wei(a)linaro.org> Tested-by: Tyler Baicar <tbaicar(a)codeaurora.org> --- Changelog: v4: fix the "#undef" bug Improve the instruction of "bert_disable", delete the useless declaration in include/acpi/apei.h. v3: https://lkml.org/lkml/2016/1/7/214 Merge the two patches Do some improvements according to Borislav's suggestion. v2: https://lkml.org/lkml/2015/8/18/336 Delete EXPORT_SYMBOL_GPL(bert_disable), because "bert_disable" is only used in bert.c for now. Do some code-style cleanups. v1: The first upstream version submitted in linux-acpi mailing list: http://www.spinics.net/lists/linux-acpi/msg57384.html Documentation/kernel-parameters.txt | 6 ++ drivers/acpi/apei/Makefile | 2 +- drivers/acpi/apei/bert.c | 158 ++++++++++++++++++++++++++++++++++++ include/acpi/apei.h | 1 + 4 files changed, 166 insertions(+), 1 deletion(-) create mode 100644 drivers/acpi/apei/bert.c diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt index 742f69d..2c527a9 100644 --- a/Documentation/kernel-parameters.txt +++ b/Documentation/kernel-parameters.txt @@ -555,6 +555,12 @@ bytes respectively. Such letter suffixes can also be entirely omitted. bootmem_debug [KNL] Enable bootmem allocator debug messages. + bert_disable [ACPI] + Disable Boot Error Record Table (BERT) support. + Use this if to workaround buggy firmware which produces + the malformed BERT table or incorrect error status + block. + bttv.card= [HW,V4L] bttv (bt848 + bt878 based grabber cards) bttv.radio= Most important insmod options are available as kernel args too. diff --git a/drivers/acpi/apei/Makefile b/drivers/acpi/apei/Makefile index 5d575a9..e50573d 100644 --- a/drivers/acpi/apei/Makefile +++ b/drivers/acpi/apei/Makefile @@ -3,4 +3,4 @@ obj-$(CONFIG_ACPI_APEI_GHES) += ghes.o obj-$(CONFIG_ACPI_APEI_EINJ) += einj.o obj-$(CONFIG_ACPI_APEI_ERST_DEBUG) += erst-dbg.o -apei-y := apei-base.o hest.o erst.o +apei-y := apei-base.o hest.o erst.o bert.o diff --git a/drivers/acpi/apei/bert.c b/drivers/acpi/apei/bert.c new file mode 100644 index 0000000..ffcbf4b --- /dev/null +++ b/drivers/acpi/apei/bert.c @@ -0,0 +1,158 @@ +/* + * APEI Boot Error Record Table (BERT) support + * + * Copyright 2011 Intel Corp. + * Author: Huang Ying <ying.huang(a)intel.com> + * + * Under normal circumstances, when a hardware error occurs, kernel + * will be notified via NMI, MCE or some other method, then kernel + * will process the error condition, report it, and recover it if + * possible. But sometime, the situation is so bad, so that firmware + * may choose to reset directly without notifying Linux kernel. + * + * Linux kernel can use the Boot Error Record Table (BERT) to get the + * un-notified hardware errors that occurred in a previous boot. + * + * For more information about BERT, please refer to ACPI Specification + * version 4.0, section 17.3.1 + * + * This file is licensed under GPLv2. + * + */ + +#include <linux/kernel.h> +#include <linux/module.h> +#include <linux/init.h> +#include <linux/acpi.h> +#include <linux/io.h> + +#include "apei-internal.h" + +#undef pr_fmt +#define pr_fmt(fmt) "BERT: " fmt + +static int bert_disable; + +static void __init bert_print_all(struct acpi_bert_region *region, + unsigned int region_len) +{ + /* + * We use cper_estatus_* which uses struct acpi_hest_generic_status, + * struct acpi_hest_generic_status and acpi_bert_region are the same + * (Generic Error Status Block), so we declare the "estatus" here. + */ + struct acpi_hest_generic_status *estatus = + (struct acpi_hest_generic_status *)region; + int remain = region_len; + u32 estatus_len; + + /* The records have been polled*/ + if (!estatus->block_status) + return; + + while (remain > sizeof(struct acpi_bert_region)) { + /* + * Test Generic Error Status Block first, + * if the data(Offset, Length) is invalid, we just return, + * because we can't trust the length data from this block. + */ + if (cper_estatus_check(estatus)) { + pr_err(FW_BUG "Invalid error record\n"); + return; + } + + estatus_len = cper_estatus_len(estatus); + if (remain < estatus_len) { + pr_err(FW_BUG "Invalid status block length (%u)\n", + estatus_len); + return; + } + + pr_info_once("Error records from previous boot:\n"); + + cper_estatus_print(KERN_INFO HW_ERR, estatus); + + /* + * Because the boot error source is "one-time polled" type, + * clear Block Status of current Generic Error Status Block, + * once it's printed. + */ + estatus->block_status = 0; + + estatus = (void *)estatus + estatus_len; + if (!estatus->block_status) + return; /* No more error records */ + + remain -= estatus_len; + } +} + +static int __init setup_bert_disable(char *str) +{ + bert_disable = 1; + + return 0; +} +__setup("bert_disable", setup_bert_disable); + +static int __init bert_check_table(struct acpi_table_bert *bert_tab) +{ + if (bert_tab->header.length < sizeof(struct acpi_table_bert) || + bert_tab->region_length < sizeof(struct acpi_bert_region)) + return -EINVAL; + + return 0; +} + +static int __init bert_init(void) +{ + struct acpi_bert_region *boot_error_region; + struct acpi_table_bert *bert_tab; + unsigned int region_len; + acpi_status status; + int rc = 0; + + if (acpi_disabled) + return 0; + + if (bert_disable) { + pr_info("Boot Error Record Table support is disabled\n"); + return 0; + } + + status = acpi_get_table(ACPI_SIG_BERT, 0, (struct acpi_table_header **)&bert_tab); + if (status == AE_NOT_FOUND) + return 0; + if (ACPI_FAILURE(status)) { + pr_err("get table failed, %s\n", acpi_format_exception(status)); + return -EINVAL; + } + + rc = bert_check_table(bert_tab); + if (rc) { + pr_err(FW_BUG "table invalid\n"); + return rc; + } + + region_len = bert_tab->region_length; + if (!request_mem_region(bert_tab->address, region_len, "APEI BERT")) { + pr_err("Can't request iomem region <%016llx-%016llx>\n", + (unsigned long long)bert_tab->address, + (unsigned long long)bert_tab->address + region_len - 1); + return -EIO; + } + + boot_error_region = ioremap_cache(bert_tab->address, region_len); + if (boot_error_region) { + bert_print_all(boot_error_region, region_len); + iounmap(boot_error_region); + } else { + rc = -ENOMEM; + } + + release_mem_region(bert_tab->address, region_len); + + return rc; +} + +late_initcall(bert_init); -- 2.5.0

8 years, 8 months

← Newer
1
...
11
12
13
14
15
16
17
...
82
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

Linaro-acpi