linaro-kernel December 2013

linaro-kernel@lists.linaro.org

83 participants
265 discussions

arm-soc boot: 32 pass, 0 fail (v3.13-rc4-420-g759811a)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: arm-soc Git describe: v3.13-rc4-420-g759811a Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 27.8 sec omap3-beagle-xm PASS: 0 min 51.6 sec am335x-bone PASS: 0 min 26.6 sec omap4-panda PASS: 1 min 6.6 sec omap4-panda-es PASS: 1 min 5.1 sec omap3-tobi,3730storm PASS: 0 min 24.1 sec omap3-tobi,3530overo PASS: 0 min 21.8 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.0 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 17.1 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.2 sec imx6q-wandboard PASS: 0 min 16.5 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.1 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 20.2 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 28.8 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 29.3 sec tegra30-beaver PASS: 0 min 14.2 sec am335x-boneblack PASS: 0 min 24.7 sec omap3-beagle-xm PASS: 0 min 50.3 sec sun7i-a20-cubieboard2 PASS: 0 min 13.0 sec armada-370-mirabox PASS: 0 min 20.5 sec omap4-panda PASS: 0 min 59.8 sec omap4-panda-es PASS: 1 min 0.6 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.6 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.6 sec am335x-bone PASS: 0 min 23.5 sec imx6q-wandboard PASS: 0 min 16.9 sec omap3-tobi,3730storm PASS: 0 min 22.7 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.8 sec omap3-tobi,3530overo PASS: 0 min 20.3 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 30.7 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.4 sec

11 years

queue boot: 13 pass, 2 fail (v3.10.25)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: queue Git describe: v3.10.25 Failed boot tests (console logs at the end) =========================================== armada-xp-openblocks-ax3-4: FAIL: multi_v7_defconfig armada-370-mirabox: FAIL: multi_v7_defconfig Full Report =========== omap2plus_defconfig ------------------- omap3-beagle-xm PASS: 0 min 52.5 sec am335x-bone PASS: 0 min 26.4 sec omap4-panda PASS: 1 min 2.8 sec omap4-panda-es PASS: 1 min 3.0 sec omap3-tobi,3730storm PASS: 0 min 36.2 sec omap3-tobi,3530overo PASS: 0 min 33.6 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.4 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.6 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.5 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.3 sec armada-370-mirabox PASS: 0 min 19.6 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 28.6 sec multi_v7_defconfig ------------------ armada-xp-openblocks-ax3-4 FAIL: 0 min 19.9 sec armada-370-mirabox FAIL: 0 min 18.0 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 16.4 sec Console logs for failures ========================= multi_v7_defconfig ------------------ armada-xp-openblocks-ax3-4: FAIL: last 24 lines of boot log: ------------------------------------------------------------ [<c0013bec>] (unwind_backtrace+0x0/0xf4) from [<c00114b0>] (show_stack+0x10/0x14) [<c00114b0>] (show_stack+0x10/0x14) from [<c0275ca0>] (panic+0xa0/0x1e8) [<c0275ca0>] (panic+0xa0/0x1e8) from [<c0329110>] (mount_block_root+0x294/0x298) [<c0329110>] (mount_block_root+0x294/0x298) from [<c03292c4>] (prepare_namespace+0x14c/0x184) [<c03292c4>] (prepare_namespace+0x14c/0x184) from [<c0328d60>] (kernel_init_freeable+0x1c8/0x1d8) [<c0328d60>] (kernel_init_freeable+0x1c8/0x1d8) from [<c02719fc>] (kernel_init+0x8/0x158) [<c02719fc>] (kernel_init+0x8/0x158) from [<c000df18>] (ret_from_fork+0x14/0x3c) CPU0: stopping CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.10.25 #1 [<c0013bec>] (unwind_backtrace+0x0/0xf4) from [<c00114b0>] (show_stack+0x10/0x14) [<c00114b0>] (show_stack+0x10/0x14) from [<c001236c>] (handle_IPI+0x108/0x130) [<c001236c>] (handle_IPI+0x108/0x130) from [<c000851c>] (armada_370_xp_handle_irq+0x90/0xa8) [<c000851c>] (armada_370_xp_handle_irq+0x90/0xa8) from [<c000dac0>] (__irq_svc+0x40/0x50) Exception stack(0xc0359f70 to 0xc0359fb8) 9f60: c1d5b6d8 00000000 000000ba 000000ba 9f80: c03604a8 c0358000 c036045c c0383b6c c027deb0 c0358000 c0383b6c c0358000 9fa0: 0000001f c0359fb8 c000f070 c004f968 60000113 ffffffff [<c000dac0>] (__irq_svc+0x40/0x50) from [<c004f968>] (cpu_startup_entry+0xfc/0x140) [<c004f968>] (cpu_startup_entry+0xfc/0x140) from [<c0328a3c>] (start_kernel+0x2c4/0x2d0) [<c0328a3c>] (start_kernel+0x2c4/0x2d0) from [<00008074>] (0x8074) ~$off # PYBOOT: Exception: kernel: ERROR: failed to boot: Kernel panic # PYBOOT: Time: 19.92 seconds. # PYBOOT: Result: FAIL armada-370-mirabox: FAIL: last 24 lines of boot log: ---------------------------------------------------- mousedev: PS/2 mouse device common for all mice sdhci: Secure Digital Host Controller Interface driver sdhci: Copyright(c) Pierre Ossman sdhci-pltfm: SDHCI platform and OF driver helper usbcore: registered new interface driver usbhid usbhid: USB HID core driver VFP support v0.3: implementor 56 architecture 2 part 20 variant 9 rev 6 Registering SWP/SWPB emulation handler /home/build/work/batch/drivers/rtc/hctosys.c: unable to open rtc device (rtc0) List of all partitions: No filesystem could mount root, tried: Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,0) CPU: 0 PID: 1 Comm: swapper/0 Not tainted 3.10.25 #1 [<c0013bec>] (unwind_backtrace+0x0/0xf4) from [<c00114b0>] (show_stack+0x10/0x14) [<c00114b0>] (show_stack+0x10/0x14) from [<c0275ca0>] (panic+0xa0/0x1e8) [<c0275ca0>] (panic+0xa0/0x1e8) from [<c0329110>] (mount_block_root+0x294/0x298) [<c0329110>] (mount_block_root+0x294/0x298) from [<c03292c4>] (prepare_namespace+0x14c/0x184) [<c03292c4>] (prepare_namespace+0x14c/0x184) from [<c0328d60>] (kernel_init_freeable+0x1c8/0x1d8) [<c0328d60>] (kernel_init_freeable+0x1c8/0x1d8) from [<c02719fc>] (kernel_init+0x8/0x158) [<c02719fc>] (kernel_init+0x8/0x158) from [<c000df18>] (ret_from_fork+0x14/0x3c) ~$off # PYBOOT: Exception: kernel: ERROR: failed to boot: Kernel panic # PYBOOT: Time: 17.97 seconds. # PYBOOT: Result: FAIL

11 years

[RFC part1 PATCH 0/7] Make ACPI core running on ARM64

by Hanjun Guo

This is the first part of making ACPI core running on ARM. PCI is optional on ARM64 but ACPI is dependent on PCI now, so in the first patch we try to make ACPI can be running without PCI. _PDC is requred for ACPI processor_core.c, but its related code is a little bit x86/ia64 dependent, so I rework _PDC related staff to make it more arch independent, and then introduce the skeleton of _PDC related for ARM64, it should be fully implemented after ACPI spec is ready for processor idle control. After that, arm-core.c is introduced so we can get ACPI table from UEFI, then we can parsed for SMP initialisation, GIC initialisation and for ACPI drivers. This patch set is based on: git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git origin/linux-next branch and plus Al Stone's v2 reduced hardware profile patch. Hanjun Guo (7): ACPI: Make ACPI core running without PCI on ARM64 ARM64 : Add dummy asm/cpu.h ACPI / processor_core: Rework _PDC related stuff to make it more arch-independent ARM64 / ACPI: Introduce the skeleton of _PDC related for ARM64 ARM64 / ACPI: Introduce arm_core.c and its related head file ARM64 / ACPI: Introduce lowlevel suspend function ARM64 / ACPI: Enable ARM64 in Kconfig arch/arm64/Kconfig | 2 + arch/arm64/include/asm/acpi.h | 93 +++++++++++++++ arch/arm64/include/asm/cpu.h | 25 ++++ arch/arm64/include/asm/processor.h | 11 ++ arch/arm64/kernel/process.c | 5 + arch/arm64/kernel/setup.c | 8 ++ drivers/acpi/Kconfig | 12 +- drivers/acpi/Makefile | 4 +- drivers/acpi/internal.h | 5 + drivers/acpi/osl.c | 16 +++ drivers/acpi/plat/Makefile | 1 + drivers/acpi/plat/arm-core.c | 226 ++++++++++++++++++++++++++++++++++++ drivers/acpi/processor_core.c | 27 ++--- drivers/acpi/reboot.c | 47 +++++--- drivers/pnp/pnpacpi/rsparser.c | 2 + 15 files changed, 452 insertions(+), 32 deletions(-) create mode 100644 arch/arm64/include/asm/acpi.h create mode 100644 arch/arm64/include/asm/cpu.h create mode 100644 drivers/acpi/plat/Makefile create mode 100644 drivers/acpi/plat/arm-core.c -- 1.7.9.5

11 years

arm-soc boot: 31 pass, 1 fail (v3.13-rc4-301-g4429e94)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: arm-soc Git describe: v3.13-rc4-301-g4429e94 Failed boot tests (console logs at the end) =========================================== sama5d35ek: FAIL: sama5_defconfig Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 27.9 sec omap3-beagle-xm PASS: 0 min 50.1 sec am335x-bone PASS: 0 min 27.5 sec omap4-panda PASS: 1 min 10.8 sec omap4-panda-es PASS: 1 min 5.5 sec omap3-tobi,3730storm PASS: 0 min 24.3 sec omap3-tobi,3530overo PASS: 0 min 21.7 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.1 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.1 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.3 sec imx6q-wandboard PASS: 0 min 16.4 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.1 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 20.3 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.8 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 29.8 sec tegra30-beaver PASS: 0 min 14.3 sec am335x-boneblack PASS: 0 min 24.8 sec omap3-beagle-xm PASS: 0 min 49.2 sec sun7i-a20-cubieboard2 PASS: 0 min 13.0 sec armada-370-mirabox PASS: 0 min 20.7 sec omap4-panda PASS: 1 min 5.1 sec omap4-panda-es PASS: 1 min 1.5 sec armada-xp-openblocks-ax3-4 PASS: 0 min 23.0 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.5 sec am335x-bone PASS: 0 min 23.4 sec imx6q-wandboard PASS: 0 min 17.0 sec omap3-tobi,3730storm PASS: 0 min 22.6 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.8 sec omap3-tobi,3530overo PASS: 0 min 20.0 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 28.0 sec sama5_defconfig --------------- sama5d35ek FAIL: 2 min 23.8 sec Console logs for failures ========================= sama5_defconfig --------------- sama5d35ek: FAIL: last 24 lines of boot log: -------------------------------------------- Abort U-Boot> tftp 0x22000000 tmp/sama5-erDiMN/tmpgD3FI8-uImage tftp 0x22000000 tmp/sama5-erDiMN/tmpgD3FI8-uImage macb0: PHY present at 0 macb0: link up, 100Mbps full-duplex (lpa: 0x45e1) Using macb0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.182 Filename 'tmp/sama5-erDiMN/tmpgD3FI8-uImage'. Load address: 0x22000000 Loading: *############T ###T #############T ###########T ########################## #T ######### Abort U-Boot> tftp 0x22000000 tmp/sama5-erDiMN/tmpgD3FI8-uImage tftp 0x22000000 tmp/sama5-erDiMN/tmpgD3FI8-uImage macb0: PHY present at 0 macb0: link up, 100Mbps full-duplex (lpa: 0x45e1) Using macb0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.182 Filename 'tmp/sama5-erDiMN/tmpgD3FI8-uImage'. Load address: 0x22000000 Loading: *#T T #T ##T T #T #~$off # PYBOOT: Exception: ERROR: Timeout loading tmp/sama5-erDiMN/tmpgD3FI8-uImage. Giving up. # PYBOOT: Time: 143.83 seconds. # PYBOOT: Result: FAIL

11 years

queue boot: 30 pass, 1 fail (v3.12.6)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: queue Git describe: v3.12.6 Failed boot tests (console logs at the end) =========================================== sama5d35ek: FAIL: sama5_defconfig Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 28.1 sec omap3-beagle-xm PASS: 0 min 53.3 sec am335x-bone PASS: 0 min 26.2 sec omap4-panda PASS: 1 min 1.9 sec omap4-panda-es PASS: 1 min 4.8 sec omap3-tobi,3730storm PASS: 0 min 23.7 sec omap3-tobi,3530overo PASS: 0 min 21.6 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.1 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 16.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.1 sec imx6q-wandboard PASS: 0 min 14.9 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.0 sec armada-370-mirabox PASS: 0 min 20.1 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 28.9 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 28.3 sec tegra30-beaver PASS: 0 min 16.6 sec am335x-boneblack PASS: 0 min 34.6 sec omap3-beagle-xm PASS: 0 min 51.5 sec sun7i-a20-cubieboard2 PASS: 0 min 13.0 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 0.6 sec omap4-panda-es PASS: 1 min 1.7 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.9 sec imx6dl-wandboard,wand-solo PASS: 0 min 16.4 sec am335x-bone PASS: 0 min 33.3 sec imx6q-wandboard PASS: 0 min 15.7 sec omap3-tobi,3730storm PASS: 0 min 22.7 sec imx6dl-wandboard,wand-dual PASS: 0 min 16.7 sec omap3-tobi,3530overo PASS: 0 min 22.6 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 37.0 sec sama5_defconfig --------------- sama5d35ek FAIL: 2 min 16.8 sec Console logs for failures ========================= sama5_defconfig --------------- sama5d35ek: FAIL: last 24 lines of boot log: -------------------------------------------- Loading: *T T #T T T T # Abort U-Boot> tftp 0x22000000 tmp/sama5-G1iOpn/tmpAPzPL9-uImage tftp 0x22000000 tmp/sama5-G1iOpn/tmpAPzPL9-uImage macb0: PHY present at 0 macb0: link up, 100Mbps full-duplex (lpa: 0x45e1) Using macb0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.182 Filename 'tmp/sama5-G1iOpn/tmpAPzPL9-uImage'. Load address: 0x22000000 Loading: *T T #T T T T # Abort U-Boot> tftp 0x22000000 tmp/sama5-G1iOpn/tmpAPzPL9-uImage tftp 0x22000000 tmp/sama5-G1iOpn/tmpAPzPL9-uImage macb0: PHY present at 0 macb0: link up, 100Mbps full-duplex (lpa: 0x45e1) Using macb0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.182 Filename 'tmp/sama5-G1iOpn/tmpAPzPL9-uImage'. Load address: 0x22000000 Loading: *##T #T T #T ##T ##T #~$off # PYBOOT: Exception: ERROR: Timeout loading tmp/sama5-G1iOpn/tmpAPzPL9-uImage. Giving up. # PYBOOT: Time: 136.82 seconds. # PYBOOT: Result: FAIL

11 years

[PATCH 1/2] arm64: dts: Add a virtio disk to the RTSM motherboard

by Mark Brown

From: Mark Hambleton <mahamble(a)broadcom.com> Describe the virtio device so we can mount disk images in the simulator. [Reduced the size of the region based on feedback from review -- broonie] Signed-off-by: Mark Hambleton <mahamble(a)broadcom.com> Signed-off-by: Mark Brown <broonie(a)linaro.org> Acked-by: Will Deacon <will.deacon(a)arm.com> --- arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi index b45e5f39f577..2f2ecd217363 100644 --- a/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi +++ b/arch/arm64/boot/dts/rtsm_ve-motherboard.dtsi @@ -183,6 +183,12 @@ clocks = <&v2m_oscclk1>, <&v2m_clk24mhz>; clock-names = "clcdclk", "apb_pclk"; }; + + virtio_block@0130000 { + compatible = "virtio,mmio"; + reg = <0x130000 0x200>; + interrupts = <42>; + }; }; v2m_fixed_3v3: fixedregulator@0 { -- 1.8.5.2

11 years

[PATCH] arm64: cmpxchg: update macros to prevent warnings

by Mark Brown

From: Mark Hambleton <mahamble(a)broadcom.com> Make sure the value we are going to return is referenced in order to avoid warnings from newer GCCs such as: arch/arm64/include/asm/cmpxchg.h:162:3: warning: value computed is not used [-Wunused-value] ((__typeof__(*(ptr)))__cmpxchg_mb((ptr), \ ^ net/netfilter/nf_conntrack_core.c:674:2: note: in expansion of macro ‘cmpxchg’ cmpxchg(&nf_conntrack_hash_rnd, 0, rand); [Modified to use the current underlying implementation as current mainline for both cmpxchg() and cmpxchg_local() does -- broonie] Signed-off-by: Mark Hambleton <mahamble(a)broadcom.com> Signed-off-by: Mark Brown <broonie(a)linaro.org> --- arch/arm64/include/asm/cmpxchg.h | 28 +++++++++++++++++----------- 1 file changed, 17 insertions(+), 11 deletions(-) diff --git a/arch/arm64/include/asm/cmpxchg.h b/arch/arm64/include/asm/cmpxchg.h index 3914c0dcd09c..c558da59989e 100644 --- a/arch/arm64/include/asm/cmpxchg.h +++ b/arch/arm64/include/asm/cmpxchg.h @@ -158,17 +158,23 @@ static inline unsigned long __cmpxchg_mb(volatile void *ptr, unsigned long old, return ret; } -#define cmpxchg(ptr,o,n) \ - ((__typeof__(*(ptr)))__cmpxchg_mb((ptr), \ - (unsigned long)(o), \ - (unsigned long)(n), \ - sizeof(*(ptr)))) - -#define cmpxchg_local(ptr,o,n) \ - ((__typeof__(*(ptr)))__cmpxchg((ptr), \ - (unsigned long)(o), \ - (unsigned long)(n), \ - sizeof(*(ptr)))) +#define cmpxchg(ptr, o, n) \ +({ \ + __typeof__(*(ptr)) __ret; \ + __ret = (__typeof__(*(ptr))) \ + __cmpxchg_mb((ptr), (unsigned long)(o), (unsigned long)(n), \ + sizeof(*(ptr))); \ + __ret; \ +}) + +#define cmpxchg_local(ptr, o, n) \ +({ \ + __typeof__(*(ptr)) __ret; \ + __ret = (__typeof__(*(ptr))) \ + __cmpxchg((ptr), (unsigned long)(o), \ + (unsigned long)(n), sizeof(*(ptr))); \ + __ret; \ +}) #define cmpxchg64(ptr,o,n) cmpxchg((ptr),(o),(n)) #define cmpxchg64_local(ptr,o,n) cmpxchg_local((ptr),(o),(n)) -- 1.8.5.2

11 years

[PATCH] cpufreq: remove sysfs files for CPU which failed to come back after resume

by Viresh Kumar

There are cases where cpufreq_add_dev() may fail for some CPUs during resume. With the current code we will still have sysfs cpufreq files for such CPUs, and struct cpufreq_policy would be already freed for them. Hence any operation on those sysfs files would result in kernel warnings. To fix this, lets remove those sysfs files or put the associated kobject in case of such errors. Also, to make it simple lets remove the sysfs links from all the CPUs (except policy->cpu) during suspend as that operation wouldn't result with a loss of sysfs file permissions. And so we will create those links during resume as well. Reported-and-tested-by: Bjørn Mork <bjorn(a)mork.no> Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- drivers/cpufreq/cpufreq.c | 61 ++++++++++++++++++++++++----------------------- 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 02d534d..cea96c9 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -845,8 +845,7 @@ static void cpufreq_init_policy(struct cpufreq_policy *policy) #ifdef CONFIG_HOTPLUG_CPU static int cpufreq_add_policy_cpu(struct cpufreq_policy *policy, - unsigned int cpu, struct device *dev, - bool frozen) + unsigned int cpu, struct device *dev) { int ret = 0; unsigned long flags; @@ -877,9 +876,7 @@ static int cpufreq_add_policy_cpu(struct cpufreq_policy *policy, } } - /* Don't touch sysfs links during light-weight init */ - if (!frozen) - ret = sysfs_create_link(&dev->kobj, &policy->kobj, "cpufreq"); + ret = sysfs_create_link(&dev->kobj, &policy->kobj, "cpufreq"); return ret; } @@ -926,6 +923,27 @@ err_free_policy: return NULL; } +static void cpufreq_policy_put_kobj(struct cpufreq_policy *policy) +{ + struct kobject *kobj; + struct completion *cmp; + + down_read(&policy->rwsem); + kobj = &policy->kobj; + cmp = &policy->kobj_unregister; + up_read(&policy->rwsem); + kobject_put(kobj); + + /* + * We need to make sure that the underlying kobj is + * actually not referenced anymore by anybody before we + * proceed with unloading. + */ + pr_debug("waiting for dropping of refcount\n"); + wait_for_completion(cmp); + pr_debug("wait complete\n"); +} + static void cpufreq_policy_free(struct cpufreq_policy *policy) { free_cpumask_var(policy->related_cpus); @@ -986,7 +1004,7 @@ static int __cpufreq_add_dev(struct device *dev, struct subsys_interface *sif, list_for_each_entry(tpolicy, &cpufreq_policy_list, policy_list) { if (cpumask_test_cpu(cpu, tpolicy->related_cpus)) { read_unlock_irqrestore(&cpufreq_driver_lock, flags); - ret = cpufreq_add_policy_cpu(tpolicy, cpu, dev, frozen); + ret = cpufreq_add_policy_cpu(tpolicy, cpu, dev); up_read(&cpufreq_rwsem); return ret; } @@ -1096,7 +1114,10 @@ err_get_freq: if (cpufreq_driver->exit) cpufreq_driver->exit(policy); err_set_policy_cpu: + if (frozen) + cpufreq_policy_put_kobj(policy); cpufreq_policy_free(policy); + nomem_out: up_read(&cpufreq_rwsem); @@ -1118,7 +1139,7 @@ static int cpufreq_add_dev(struct device *dev, struct subsys_interface *sif) } static int cpufreq_nominate_new_policy_cpu(struct cpufreq_policy *policy, - unsigned int old_cpu, bool frozen) + unsigned int old_cpu) { struct device *cpu_dev; int ret; @@ -1126,10 +1147,6 @@ static int cpufreq_nominate_new_policy_cpu(struct cpufreq_policy *policy, /* first sibling now owns the new sysfs dir */ cpu_dev = get_cpu_device(cpumask_any_but(policy->cpus, old_cpu)); - /* Don't touch sysfs files during light-weight tear-down */ - if (frozen) - return cpu_dev->id; - sysfs_remove_link(&cpu_dev->kobj, "cpufreq"); ret = kobject_move(&policy->kobj, &cpu_dev->kobj); if (ret) { @@ -1196,7 +1213,7 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, if (!frozen) sysfs_remove_link(&dev->kobj, "cpufreq"); } else if (cpus > 1) { - new_cpu = cpufreq_nominate_new_policy_cpu(policy, cpu, frozen); + new_cpu = cpufreq_nominate_new_policy_cpu(policy, cpu); if (new_cpu >= 0) { update_policy_cpu(policy, new_cpu); @@ -1218,8 +1235,6 @@ static int __cpufreq_remove_dev_finish(struct device *dev, int ret; unsigned long flags; struct cpufreq_policy *policy; - struct kobject *kobj; - struct completion *cmp; read_lock_irqsave(&cpufreq_driver_lock, flags); policy = per_cpu(cpufreq_cpu_data, cpu); @@ -1249,22 +1264,8 @@ static int __cpufreq_remove_dev_finish(struct device *dev, } } - if (!frozen) { - down_read(&policy->rwsem); - kobj = &policy->kobj; - cmp = &policy->kobj_unregister; - up_read(&policy->rwsem); - kobject_put(kobj); - - /* - * We need to make sure that the underlying kobj is - * actually not referenced anymore by anybody before we - * proceed with unloading. - */ - pr_debug("waiting for dropping of refcount\n"); - wait_for_completion(cmp); - pr_debug("wait complete\n"); - } + if (!frozen) + cpufreq_policy_put_kobj(policy); /* * Perform the ->exit() even during light-weight tear-down, -- 1.7.12.rc2.18.g61b472e

11 years

[PATCH Resend] cpufreq: remove sysfs files for CPU which failed to come back after resume

by Viresh Kumar

There are cases where cpufreq_add_dev() may fail for some CPUs during resume. With the current code we will still have sysfs cpufreq files for such CPUs, and struct cpufreq_policy would be already freed for them. Hence any operation on those sysfs files would result in kernel warnings. To fix this, lets remove those sysfs files or put the associated kobject in case of such errors. Also, to make it simple lets remove the sysfs links from all the CPUs (except policy->cpu) during suspend as that operation wouldn't result with a loss of sysfs file permissions. And so we will create those links during resume as well. Reported-and-tested-by: Bjørn Mork <bjorn(a)mork.no> Signed-off-by: Viresh Kumar <viresh.kumar(a)linaro.org> --- drivers/cpufreq/cpufreq.c | 63 +++++++++++++++++++++++------------------------ 1 file changed, 31 insertions(+), 32 deletions(-) diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c index 02d534d..fab042e 100644 --- a/drivers/cpufreq/cpufreq.c +++ b/drivers/cpufreq/cpufreq.c @@ -845,8 +845,7 @@ static void cpufreq_init_policy(struct cpufreq_policy *policy) #ifdef CONFIG_HOTPLUG_CPU static int cpufreq_add_policy_cpu(struct cpufreq_policy *policy, - unsigned int cpu, struct device *dev, - bool frozen) + unsigned int cpu, struct device *dev) { int ret = 0; unsigned long flags; @@ -877,11 +876,7 @@ static int cpufreq_add_policy_cpu(struct cpufreq_policy *policy, } } - /* Don't touch sysfs links during light-weight init */ - if (!frozen) - ret = sysfs_create_link(&dev->kobj, &policy->kobj, "cpufreq"); - - return ret; + return sysfs_create_link(&dev->kobj, &policy->kobj, "cpufreq"); } #endif @@ -926,6 +921,27 @@ err_free_policy: return NULL; } +static void cpufreq_policy_put_kobj(struct cpufreq_policy *policy) +{ + struct kobject *kobj; + struct completion *cmp; + + down_read(&policy->rwsem); + kobj = &policy->kobj; + cmp = &policy->kobj_unregister; + up_read(&policy->rwsem); + kobject_put(kobj); + + /* + * We need to make sure that the underlying kobj is + * actually not referenced anymore by anybody before we + * proceed with unloading. + */ + pr_debug("waiting for dropping of refcount\n"); + wait_for_completion(cmp); + pr_debug("wait complete\n"); +} + static void cpufreq_policy_free(struct cpufreq_policy *policy) { free_cpumask_var(policy->related_cpus); @@ -986,7 +1002,7 @@ static int __cpufreq_add_dev(struct device *dev, struct subsys_interface *sif, list_for_each_entry(tpolicy, &cpufreq_policy_list, policy_list) { if (cpumask_test_cpu(cpu, tpolicy->related_cpus)) { read_unlock_irqrestore(&cpufreq_driver_lock, flags); - ret = cpufreq_add_policy_cpu(tpolicy, cpu, dev, frozen); + ret = cpufreq_add_policy_cpu(tpolicy, cpu, dev); up_read(&cpufreq_rwsem); return ret; } @@ -1096,7 +1112,10 @@ err_get_freq: if (cpufreq_driver->exit) cpufreq_driver->exit(policy); err_set_policy_cpu: + if (frozen) + cpufreq_policy_put_kobj(policy); cpufreq_policy_free(policy); + nomem_out: up_read(&cpufreq_rwsem); @@ -1118,7 +1137,7 @@ static int cpufreq_add_dev(struct device *dev, struct subsys_interface *sif) } static int cpufreq_nominate_new_policy_cpu(struct cpufreq_policy *policy, - unsigned int old_cpu, bool frozen) + unsigned int old_cpu) { struct device *cpu_dev; int ret; @@ -1126,10 +1145,6 @@ static int cpufreq_nominate_new_policy_cpu(struct cpufreq_policy *policy, /* first sibling now owns the new sysfs dir */ cpu_dev = get_cpu_device(cpumask_any_but(policy->cpus, old_cpu)); - /* Don't touch sysfs files during light-weight tear-down */ - if (frozen) - return cpu_dev->id; - sysfs_remove_link(&cpu_dev->kobj, "cpufreq"); ret = kobject_move(&policy->kobj, &cpu_dev->kobj); if (ret) { @@ -1196,7 +1211,7 @@ static int __cpufreq_remove_dev_prepare(struct device *dev, if (!frozen) sysfs_remove_link(&dev->kobj, "cpufreq"); } else if (cpus > 1) { - new_cpu = cpufreq_nominate_new_policy_cpu(policy, cpu, frozen); + new_cpu = cpufreq_nominate_new_policy_cpu(policy, cpu); if (new_cpu >= 0) { update_policy_cpu(policy, new_cpu); @@ -1218,8 +1233,6 @@ static int __cpufreq_remove_dev_finish(struct device *dev, int ret; unsigned long flags; struct cpufreq_policy *policy; - struct kobject *kobj; - struct completion *cmp; read_lock_irqsave(&cpufreq_driver_lock, flags); policy = per_cpu(cpufreq_cpu_data, cpu); @@ -1249,22 +1262,8 @@ static int __cpufreq_remove_dev_finish(struct device *dev, } } - if (!frozen) { - down_read(&policy->rwsem); - kobj = &policy->kobj; - cmp = &policy->kobj_unregister; - up_read(&policy->rwsem); - kobject_put(kobj); - - /* - * We need to make sure that the underlying kobj is - * actually not referenced anymore by anybody before we - * proceed with unloading. - */ - pr_debug("waiting for dropping of refcount\n"); - wait_for_completion(cmp); - pr_debug("wait complete\n"); - } + if (!frozen) + cpufreq_policy_put_kobj(policy); /* * Perform the ->exit() even during light-weight tear-down, -- 1.7.12.rc2.18.g61b472e

11 years

arm-soc boot: 30 pass, 2 fail (v3.13-rc4-297-g76d53c6)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: arm-soc Git describe: v3.13-rc4-297-g76d53c6 Failed boot tests (console logs at the end) =========================================== exynos5250-arndale: FAIL: exynos_defconfig sama5d35ek: FAIL: sama5_defconfig Full Report =========== omap2plus_defconfig ------------------- am335x-boneblack PASS: 0 min 27.8 sec omap3-beagle-xm PASS: 0 min 52.3 sec am335x-bone PASS: 0 min 26.6 sec omap4-panda PASS: 1 min 4.2 sec omap4-panda-es PASS: 1 min 8.5 sec omap3-tobi,3730storm PASS: 0 min 21.0 sec omap3-tobi,3530overo PASS: 0 min 22.0 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.0 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 17.0 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.3 sec imx6q-wandboard PASS: 0 min 16.5 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.0 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.0 sec armada-370-mirabox PASS: 0 min 20.1 sec exynos_defconfig ---------------- exynos5250-arndale FAIL: 0 min 31.4 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 29.1 sec tegra30-beaver PASS: 0 min 17.2 sec am335x-boneblack PASS: 0 min 24.7 sec omap3-beagle-xm PASS: 0 min 50.7 sec sun7i-a20-cubieboard2 PASS: 0 min 13.0 sec armada-370-mirabox PASS: 0 min 20.7 sec omap4-panda PASS: 1 min 1.9 sec omap4-panda-es PASS: 1 min 2.7 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.9 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.6 sec am335x-bone PASS: 0 min 23.4 sec imx6q-wandboard PASS: 0 min 15.8 sec omap3-tobi,3730storm PASS: 0 min 22.6 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.8 sec omap3-tobi,3530overo PASS: 0 min 20.1 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 31.0 sec sama5_defconfig --------------- sama5d35ek FAIL: 2 min 4.8 sec Console logs for failures ========================= exynos_defconfig ---------------- exynos5250-arndale: FAIL: last 24 lines of boot log: ---------------------------------------------------- Connected to arndale console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(arndale console)> hardreset (user:khilman) Reboot arndale Reboot: arndale ; phidget 2 0 : off, sleep, on ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.39 seconds. # PYBOOT: Result: FAIL sama5_defconfig --------------- sama5d35ek: FAIL: last 24 lines of boot log: -------------------------------------------- Loading: *#T #T T #T ####T ####### Abort U-Boot> tftp 0x22000000 tmp/sama5-bgiDxM/tmpPFv5Cf-uImage tftp 0x22000000 tmp/sama5-bgiDxM/tmpPFv5Cf-uImage macb0: PHY present at 0 macb0: link up, 100Mbps full-duplex (lpa: 0x45e1) Using macb0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.182 Filename 'tmp/sama5-bgiDxM/tmpPFv5Cf-uImage'. Load address: 0x22000000 Loading: *T #T T T #T #T Abort U-Boot> tftp 0x22000000 tmp/sama5-bgiDxM/tmpPFv5Cf-uImage tftp 0x22000000 tmp/sama5-bgiDxM/tmpPFv5Cf-uImage macb0: PHY present at 0 macb0: link up, 100Mbps full-duplex (lpa: 0x45e1) Using macb0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.182 Filename 'tmp/sama5-bgiDxM/tmpPFv5Cf-uImage'. Load address: 0x22000000 Loading: *##################T ################T ####T ######T #T ##########T #####~$off # PYBOOT: Exception: ERROR: Timeout loading tmp/sama5-bgiDxM/tmpPFv5Cf-uImage. Giving up. # PYBOOT: Time: 124.85 seconds. # PYBOOT: Result: FAIL

11 years

← Newer
1
...
6
7
8
9
10
11
12
...
27
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel December 2013