linaro-kernel March 2014

linaro-kernel@lists.linaro.org

86 participants
221 discussions

[PATCH V4 1/5] idle/cpuidle: Split cpuidle_idle_call main function into smaller functions

by Daniel Lezcano

In order to allow better integration between the cpuidle framework and the scheduler, reducing the distance between these two sub-components will facilitate this integration by moving part of the cpuidle code in the idle task file and, because idle.c is in the sched directory, we have access to the scheduler's private structures. This patch splits the cpuidle_idle_call main entry function into 3 calls to a newly added API: 1. select the idle state 2. enter the idle state 3. reflect the idle state The cpuidle_idle_call calls these three functions to implement the main idle entry function. Signed-off-by: Daniel Lezcano <daniel.lezcano(a)linaro.org> Acked-by: Nicolas Pitre <nico(a)linaro.org> --- ChangeLog: V4: * rebased on top of tip/master V3: * moved broadcast timer outside of cpuidle_enter() as suggested by Preeti U Murthy : https://lkml.org/lkml/2014/2/24/601 V2: * splitted cpuidle_select error check into 'cpuidle_enabled' function --- drivers/cpuidle/cpuidle.c | 96 +++++++++++++++++++++++++++++++++++----------- include/linux/cpuidle.h | 19 +++++++++ 2 files changed, 94 insertions(+), 21 deletions(-) Index: cpuidle-next/drivers/cpuidle/cpuidle.c =================================================================== --- cpuidle-next.orig/drivers/cpuidle/cpuidle.c +++ cpuidle-next/drivers/cpuidle/cpuidle.c @@ -65,6 +65,26 @@ int cpuidle_play_dead(void) } /** + * cpuidle_enabled - check if the cpuidle framework is ready + * @dev: cpuidle device for this cpu + * @drv: cpuidle driver for this cpu + * + * Return 0 on success, otherwise: + * -NODEV : the cpuidle framework is not available + * -EBUSY : the cpuidle framework is not initialized + */ +int cpuidle_enabled(struct cpuidle_driver *drv, struct cpuidle_device *dev) +{ + if (off || !initialized) + return -ENODEV; + + if (!drv || !dev || !dev->enabled) + return -EBUSY; + + return 0; +} + +/** * cpuidle_enter_state - enter the state and update stats * @dev: cpuidle device for this cpu * @drv: cpuidle driver for this cpu @@ -108,6 +128,51 @@ int cpuidle_enter_state(struct cpuidle_d } /** + * cpuidle_select - ask the cpuidle framework to choose an idle state + * + * @drv: the cpuidle driver + * @dev: the cpuidle device + * + * Returns the index of the idle state. + */ +int cpuidle_select(struct cpuidle_driver *drv, struct cpuidle_device *dev) +{ + return cpuidle_curr_governor->select(drv, dev); +} + +/** + * cpuidle_enter - enter into the specified idle state + * + * @drv: the cpuidle driver tied with the cpu + * @dev: the cpuidle device + * @index: the index in the idle state table + * + * Returns the index in the idle state, < 0 in case of error. + * The error code depends on the backend driver + */ +int cpuidle_enter(struct cpuidle_driver *drv, struct cpuidle_device *dev, + int index) +{ + if (cpuidle_state_is_coupled(dev, drv, index)) + return cpuidle_enter_state_coupled(dev, drv, index); + return cpuidle_enter_state(dev, drv, index); +} + +/** + * cpuidle_reflect - tell the underlying governor what was the state + * we were in + * + * @dev : the cpuidle device + * @index: the index in the idle state table + * + */ +void cpuidle_reflect(struct cpuidle_device *dev, int index) +{ + if (cpuidle_curr_governor->reflect) + cpuidle_curr_governor->reflect(dev, index); +} + +/** * cpuidle_idle_call - the main idle loop * * NOTE: no locks or semaphores should be used here @@ -116,26 +181,21 @@ int cpuidle_enter_state(struct cpuidle_d int cpuidle_idle_call(void) { struct cpuidle_device *dev = __this_cpu_read(cpuidle_devices); - struct cpuidle_driver *drv; - int next_state, entered_state; + struct cpuidle_driver *drv = cpuidle_get_cpu_driver(dev); + int next_state, entered_state, ret; bool broadcast; - if (off || !initialized) - return -ENODEV; - - /* check if the device is ready */ - if (!dev || !dev->enabled) - return -EBUSY; - - drv = cpuidle_get_cpu_driver(dev); + ret = cpuidle_enabled(drv, dev); + if (ret < 0) + return ret; /* ask the governor for the next state */ - next_state = cpuidle_curr_governor->select(drv, dev); + next_state = cpuidle_select(drv, dev); + if (need_resched()) { dev->last_residency = 0; /* give the governor an opportunity to reflect on the outcome */ - if (cpuidle_curr_governor->reflect) - cpuidle_curr_governor->reflect(dev, next_state); + cpuidle_reflect(dev, next_state); local_irq_enable(); return 0; } @@ -146,14 +206,9 @@ int cpuidle_idle_call(void) clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_ENTER, &dev->cpu)) return -EBUSY; - trace_cpu_idle_rcuidle(next_state, dev->cpu); - if (cpuidle_state_is_coupled(dev, drv, next_state)) - entered_state = cpuidle_enter_state_coupled(dev, drv, - next_state); - else - entered_state = cpuidle_enter_state(dev, drv, next_state); + entered_state = cpuidle_enter(drv, dev, next_state); trace_cpu_idle_rcuidle(PWR_EVENT_EXIT, dev->cpu); @@ -161,8 +216,7 @@ int cpuidle_idle_call(void) clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &dev->cpu); /* give the governor an opportunity to reflect on the outcome */ - if (cpuidle_curr_governor->reflect) - cpuidle_curr_governor->reflect(dev, entered_state); + cpuidle_reflect(dev, entered_state); return 0; } Index: cpuidle-next/include/linux/cpuidle.h =================================================================== --- cpuidle-next.orig/include/linux/cpuidle.h +++ cpuidle-next/include/linux/cpuidle.h @@ -119,6 +119,15 @@ struct cpuidle_driver { #ifdef CONFIG_CPU_IDLE extern void disable_cpuidle(void); + +extern int cpuidle_enabled(struct cpuidle_driver *drv, + struct cpuidle_device *dev); +extern int cpuidle_select(struct cpuidle_driver *drv, + struct cpuidle_device *dev); +extern int cpuidle_enter(struct cpuidle_driver *drv, + struct cpuidle_device *dev, int index); +extern void cpuidle_reflect(struct cpuidle_device *dev, int index); + extern int cpuidle_idle_call(void); extern int cpuidle_register_driver(struct cpuidle_driver *drv); extern struct cpuidle_driver *cpuidle_get_driver(void); @@ -141,6 +150,16 @@ extern int cpuidle_play_dead(void); extern struct cpuidle_driver *cpuidle_get_cpu_driver(struct cpuidle_device *dev); #else static inline void disable_cpuidle(void) { } +static inline int cpuidle_enabled(struct cpuidle_driver *drv, + struct cpuidle_device *dev) +{return -ENODEV; } +static inline int cpuidle_select(struct cpuidle_driver *drv, + struct cpuidle_device *dev) +{return -ENODEV; } +static inline int cpuidle_enter(struct cpuidle_driver *drv, + struct cpuidle_device *dev, int index) +{return -ENODEV; } +static inline void cpuidle_reflect(struct cpuidle_device *dev, int index) { } static inline int cpuidle_idle_call(void) { return -ENODEV; } static inline int cpuidle_register_driver(struct cpuidle_driver *drv) {return -ENODEV; }

10 years, 4 months

mainline boot: 46 pass, 1 fail (v3.14-rc5)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.14-rc5 Failed boot tests (console logs at the end) =========================================== omap5-uevm: FAIL: multi_v7_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.2 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 49.6 sec am335x-boneblack PASS: 0 min 25.5 sec omap3-beagle-xm PASS: 1 min 1.1 sec legacy,3530beagle PASS: 2 min 5.1 sec omap4-panda PASS: 1 min 7.5 sec omap3-overo-tobi PASS: 0 min 22.4 sec am335x-bone PASS: 0 min 27.3 sec omap3-overo-storm-tobi PASS: 0 min 25.2 sec omap5-uevm PASS: 0 min 55.0 sec omap4-panda-es PASS: 1 min 10.2 sec legacy,3730storm PASS: 0 min 23.4 sec legacy,3530overo PASS: 0 min 21.1 sec multi_lpae_defconfig -------------------- omap5-uevm PASS: 1 min 47.4 sec sun7i-a20-cubieboard2 PASS: 0 min 14.2 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 16.9 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.1 sec imx6q-wandboard PASS: 0 min 17.0 sec msm_defconfig ------------- qcom-apq8074-dragonboard PASS: 1 min 9.2 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 58.8 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.6 sec sun4i-a10-cubieboard PASS: 0 min 17.1 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 38.2 sec multi_v7_defconfig ------------------ ste-snowball PASS: 1 min 18.0 sec tegra30-beaver PASS: 0 min 16.9 sec am335x-boneblack PASS: 0 min 23.2 sec omap3-beagle-xm PASS: 0 min 48.5 sec sun7i-a20-cubieboard2 PASS: 0 min 14.1 sec armada-370-mirabox PASS: 0 min 22.3 sec omap4-panda PASS: 0 min 56.6 sec armada-xp-openblocks-ax3-4 PASS: 0 min 24.9 sec sun4i-a10-cubieboard PASS: 0 min 18.2 sec bcm28155-ap PASS: 1 min 4.1 sec omap3-overo-tobi PASS: 0 min 24.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.6 sec am335x-bone PASS: 0 min 25.8 sec omap3-overo-storm-tobi PASS: 0 min 21.1 sec omap5-uevm FAIL: 0 min 31.4 sec imx6q-wandboard PASS: 0 min 17.1 sec omap4-panda-es PASS: 0 min 54.2 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.9 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 33.8 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.0 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.4 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 20.2 sec Console logs for failures ========================= multi_v7_defconfig ------------------ omap5-uevm: FAIL: last 80 lines of boot log: -------------------------------------------- Connected to omap5uevm console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(omap5uevm console)> hardreset (user:khilman) Reboot omap5uevm Reboot: omap5uevm ; phidget 1 2 : off, sleep, on 0 U-Boot# found: 002/088 2 ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.38 seconds. # PYBOOT: Result: FAIL

10 years, 4 months

queue boot: 17 pass, 1 fail (v3.10.32-43-gcfb827b)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: queue Git describe: v3.10.32-43-gcfb827b Failed boot tests (console logs at the end) =========================================== imx6dl-wandboard,wand-solo: FAIL: imx_v6_v7_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 14.6 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 48.1 sec omap3-beagle-xm PASS: 1 min 0.2 sec legacy,3530beagle PASS: 0 min 35.5 sec omap4-panda PASS: 1 min 3.4 sec omap3-tobi PASS: 0 min 33.5 sec am335x-bone PASS: 0 min 26.3 sec omap4-panda-es PASS: 1 min 6.6 sec legacy,3730storm PASS: 0 min 20.2 sec legacy,3530overo PASS: 0 min 20.9 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.6 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 17.1 sec imx6dl-wandboard,wand-solo FAIL: 0 min 31.4 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.5 sec armada-370-mirabox PASS: 0 min 19.5 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 28.9 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 16.3 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.1 sec Console logs for failures ========================= imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-solo: FAIL: last 80 lines of boot log: ------------------------------------------------------------ Connected to wand-solo console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(wand-solo console)> hardreset (user:khilman) Reboot wand-solo Reboot: wand-solo ; phidget 2 2 : off, sleep, on U-Boot 2013.04-00012-g0b44183-dirty (May 15 2013 - 16:16:11) CPU: Freescale i.MX6SOLO rev1.1 at 792 MHz Reset cause: POR Board: Wandboard DRAM: 512 MiB WARNING: Caches not enabled MMC: FSL_SDHC: 0 *** Warning - bad CRC, using default env 0 => ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.38 seconds. # PYBOOT: Result: FAIL

10 years, 4 months

mainline boot: 46 pass, 1 fail (v3.14-rc4-185-gc59224d)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.14-rc4-185-gc59224d Failed boot tests (console logs at the end) =========================================== omap5-uevm: FAIL: multi_lpae_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.2 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 51.9 sec am335x-boneblack PASS: 0 min 25.6 sec omap3-beagle-xm PASS: 1 min 0.7 sec legacy,3530beagle PASS: 0 min 36.3 sec omap4-panda PASS: 1 min 8.1 sec omap3-overo-tobi PASS: 0 min 22.7 sec am335x-bone PASS: 0 min 27.3 sec omap3-overo-storm-tobi PASS: 0 min 25.6 sec omap5-uevm PASS: 1 min 1.9 sec omap4-panda-es PASS: 1 min 10.5 sec legacy,3730storm PASS: 0 min 23.3 sec legacy,3530overo PASS: 0 min 24.4 sec multi_lpae_defconfig -------------------- omap5-uevm FAIL: 0 min 31.4 sec sun7i-a20-cubieboard2 PASS: 0 min 14.1 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.0 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.5 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.3 sec imx6q-wandboard PASS: 0 min 17.1 sec msm_defconfig ------------- qcom-apq8074-dragonboard PASS: 0 min 58.8 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 58.9 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 11.7 sec sun4i-a10-cubieboard PASS: 0 min 16.9 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.2 sec multi_v7_defconfig ------------------ ste-snowball PASS: 1 min 17.5 sec tegra30-beaver PASS: 0 min 19.9 sec am335x-boneblack PASS: 0 min 23.2 sec omap3-beagle-xm PASS: 0 min 53.4 sec sun7i-a20-cubieboard2 PASS: 0 min 14.2 sec armada-370-mirabox PASS: 0 min 22.3 sec omap4-panda PASS: 1 min 1.1 sec armada-xp-openblocks-ax3-4 PASS: 0 min 24.8 sec sun4i-a10-cubieboard PASS: 0 min 14.0 sec bcm28155-ap PASS: 1 min 9.4 sec omap3-overo-tobi PASS: 0 min 21.5 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.9 sec am335x-bone PASS: 0 min 30.9 sec omap3-overo-storm-tobi PASS: 0 min 21.2 sec omap5-uevm PASS: 1 min 48.5 sec imx6q-wandboard PASS: 0 min 17.4 sec omap4-panda-es PASS: 0 min 56.9 sec imx6dl-wandboard,wand-dual PASS: 0 min 18.1 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 30.2 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.1 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.6 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.0 sec armada-370-mirabox PASS: 0 min 20.2 sec Console logs for failures ========================= multi_lpae_defconfig -------------------- omap5-uevm: FAIL: last 80 lines of boot log: -------------------------------------------- Connected to omap5uevm console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(omap5uevm console)> hardreset (user:khilman) Reboot omap5uevm Reboot: omap5uevm ; phidget 1 2 : off, sleep, on 0 U-Boot# found: 002/053 2 ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.37 seconds. # PYBOOT: Result: FAIL

10 years, 4 months

mainline boot: 46 pass, 1 fail (v3.14-rc4-151-g3154da3)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.14-rc4-151-g3154da3 Failed boot tests (console logs at the end) =========================================== omap5-uevm: FAIL: multi_v7_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.2 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 53.0 sec am335x-boneblack PASS: 0 min 25.4 sec omap3-beagle-xm PASS: 1 min 0.9 sec legacy,3530beagle PASS: 2 min 7.3 sec omap4-panda PASS: 1 min 12.0 sec omap3-overo-tobi PASS: 0 min 23.0 sec am335x-bone PASS: 0 min 27.2 sec omap3-overo-storm-tobi PASS: 0 min 25.2 sec omap5-uevm PASS: 1 min 3.8 sec omap4-panda-es PASS: 1 min 7.8 sec legacy,3730storm PASS: 0 min 23.5 sec legacy,3530overo PASS: 0 min 21.1 sec multi_lpae_defconfig -------------------- omap5-uevm PASS: 1 min 40.4 sec sun7i-a20-cubieboard2 PASS: 0 min 14.2 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.0 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.3 sec imx6q-wandboard PASS: 0 min 16.8 sec msm_defconfig ------------- qcom-apq8074-dragonboard PASS: 1 min 9.4 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 54.0 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.6 sec sun4i-a10-cubieboard PASS: 0 min 16.9 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 29.3 sec multi_v7_defconfig ------------------ ste-snowball PASS: 1 min 17.8 sec tegra30-beaver PASS: 0 min 24.1 sec am335x-boneblack PASS: 0 min 23.3 sec omap3-beagle-xm PASS: 0 min 53.7 sec sun7i-a20-cubieboard2 PASS: 0 min 14.2 sec armada-370-mirabox PASS: 0 min 22.3 sec omap4-panda PASS: 0 min 56.1 sec armada-xp-openblocks-ax3-4 PASS: 0 min 24.9 sec sun4i-a10-cubieboard PASS: 0 min 19.4 sec bcm28155-ap PASS: 1 min 4.0 sec omap3-overo-tobi PASS: 0 min 21.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.8 sec am335x-bone PASS: 0 min 25.9 sec omap3-overo-storm-tobi PASS: 0 min 24.3 sec omap5-uevm FAIL: 0 min 31.4 sec imx6q-wandboard PASS: 0 min 17.2 sec omap4-panda-es PASS: 0 min 57.0 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.9 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 35.1 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.1 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.5 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 20.2 sec Console logs for failures ========================= multi_v7_defconfig ------------------ omap5-uevm: FAIL: last 80 lines of boot log: -------------------------------------------- Connected to omap5uevm console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(omap5uevm console)> hardreset (user:khilman) Reboot omap5uevm Reboot: omap5uevm ; phidget 1 2 : off, sleep, on 0 U-Boot# found: 002/037 2 ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.38 seconds. # PYBOOT: Result: FAIL

10 years, 4 months

[PATCH V6 0/7] cpufreq: suspend early/resume late: dpm_{suspend|resume}()

by Viresh Kumar

This patchset creates/calls cpufreq suspend/resume callbacks from dpm_{suspend|resume}() for handling suspend/resume of cpufreq governors and core. There are multiple problems that are fixed by this patch: - Nishanth Menon (TI) found an interesting problem on his platform, OMAP. His board wasn't working well with suspend/resume as calls for removing non-boot CPUs was turning out into a call to drivers ->target() which then tries to play with regulators. But regulators and their I2C bus were already suspended and this resulted in a failure. Many platforms have such problems, samsung, tegra, etc.. They solved it with driver specific PM notifiers where they used to disable their driver's ->target() routine. - Lan Tianyu (Intel) & Jinhyuk Choi (Broadcom) found an issue where tunables configuration for clusters/sockets with non-boot CPUs was getting lost after suspend/resume, as we were notifying governors with CPUFREQ_GOV_POLICY_EXIT on removal of the last cpu for that policy and so deallocating memory for tunables. This is fixed by this patch as we don't allow any operation on governors after device suspend and before device resume now. This is already tested by few people and so incorporating their Tested-by as well. I have tested this again on latest stuff on my thinkpad for several suspend/resume cycles. V6->V7: - Fixed crash reported by S.Warren on systems without a cpufreq driver. - Moved some function doc-comments to patch 1 from a later patch. For-v3.15 Viresh Kumar (7): cpufreq: suspend governors on system suspend/hibernate cpufreq: suspend governors from dpm_{suspend|resume}() cpufreq: call driver's suspend/resume for each policy cpufreq: Implement cpufreq_generic_suspend() cpufreq: exynos: Use cpufreq_generic_suspend() cpufreq: s5pv210: Use cpufreq_generic_suspend() cpufreq: Tegra: Use cpufreq_generic_suspend() drivers/base/power/main.c | 5 ++ drivers/cpufreq/cpufreq.c | 137 +++++++++++++++++++++++--------------- drivers/cpufreq/exynos-cpufreq.c | 96 ++------------------------ drivers/cpufreq/s5pv210-cpufreq.c | 49 +------------- drivers/cpufreq/tegra-cpufreq.c | 46 ++----------- include/linux/cpufreq.h | 11 +++ 6 files changed, 113 insertions(+), 231 deletions(-) -- 1.7.12.rc2.18.g61b472e

10 years, 4 months

queue boot: 17 pass, 1 fail (v3.10.32-39-g07e42bb)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: queue Git describe: v3.10.32-39-g07e42bb Failed boot tests (console logs at the end) =========================================== imx6dl-wandboard,wand-solo: FAIL: imx_v6_v7_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 14.6 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 53.4 sec omap3-beagle-xm PASS: 0 min 58.1 sec legacy,3530beagle PASS: 0 min 40.1 sec omap4-panda PASS: 1 min 14.8 sec omap3-tobi PASS: 0 min 36.5 sec am335x-bone PASS: 0 min 26.3 sec omap4-panda-es PASS: 1 min 2.1 sec legacy,3730storm PASS: 0 min 20.6 sec legacy,3530overo PASS: 0 min 20.9 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 21.7 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 17.1 sec imx6dl-wandboard,wand-solo FAIL: 0 min 31.4 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.1 sec armada-370-mirabox PASS: 0 min 19.6 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 30.3 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 16.4 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 17.0 sec Console logs for failures ========================= imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-solo: FAIL: last 80 lines of boot log: ------------------------------------------------------------ Connected to wand-solo console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(wand-solo console)> hardreset (user:khilman) Reboot wand-solo Reboot: wand-solo ; phidget 2 2 : off, sleep, on U-Boot 2013.04-00012-g0b44183-dirty (May 15 2013 - 16:16:11) CPU: Freescale i.MX6SOLO rev1.1 at 792 MHz Reset cause: POR Board: Wandboard DRAM: 512 MiB WARNING: Caches not enabled MMC: FSL_SDHC: 0 *** Warning - bad CRC, using default env 0 => ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.38 seconds. # PYBOOT: Result: FAIL

10 years, 4 months

[PATCH v3 0/5] [RFC] Support for creating generic host_bridge from device tree

by Liviu Dudau

This is v3 of my attempt to add support for a generic pci_host_bridge controller created from a description passed in the device tree. Changes from v2: - Use range->cpu_addr when calling pci_address_to_pio() - Introduce pci_register_io_range() helper function in order to register io ranges ahead of their conversion to PIO values. This is needed as no information is being stored yet regarding the range mapping, making pci_address_to_pio() fail. Default weak implementation does nothing, to cover the default weak implementation of pci_address_to_pio() that expects direct mapping of physical addresses into PIO values (x86 view). Changes from v1: - Add patch to fix conversion of IO ranges into IO resources. - Added a domain_nr member to pci_host_bridge structure, and a new function to create a root bus in a given domain number. In order to facilitate that I propose changing the order of initialisation between pci_host_bridge and it's related bus in pci_create_root_bus() as sort of a rever of 7b5436635800. This is done in patch 1/4 and 2/4. - Added a simple allocator of domain numbers in drivers/pci/host-bridge.c. The code will first try to get a domain id from of_alias_get_id(..., "pci-domain") and if that fails assign the next unallocated domain id. - Changed the name of the function that creates the generic host bridge from pci_host_bridge_of_init to of_create_pci_host_bridge and exported as GPL symbol. v1 thread here: https://lkml.org/lkml/2014/2/3/380 The following is an edit of the original blurb: Following the discussion started here [1], I now have a proposal for tackling generic support for host bridges described via device tree. It is an initial stab at it, to try to get feedback and suggestions, but it is functional enough that I have PCI Express for arm64 working on an FPGA using the patch that I am also publishing that adds support for PCI for that platform. Looking at the existing architectures that fit the requirements (use of device tree and PCI) yields the powerpc and microblaze as generic enough to make them candidates for conversion. I have a tentative patch for microblaze that I can only compile test it, unfortunately using qemu-microblaze leads to an early crash in the kernel. As Bjorn has mentioned in the previous discussion, the idea is to add to struct pci_host_bridge enough data to be able to reduce the size or remove the architecture specific pci_controller structure. arm64 support actually manages to get rid of all the architecture static data and has no pci_controller structure defined. For host bridge drivers that means a change of API unless architectures decide to provide a compatibility layer (comments here please). In order to initialise a host bridge with the new API, the following example code is sufficient for a _probe() function: static int myhostbridge_probe(struct platform_device *pdev) { int err; struct device_node *dev; struct pci_host_bridge *bridge; struct myhostbridge_port *pp; resource_size_t lastbus; dev = pdev->dev.of_node; if (!of_device_is_available(dev)) { pr_warn("%s: disabled\n", dev->full_name); return -ENODEV; } pp = kzalloc(sizeof(struct myhostbridge_port), GFP_KERNEL); if (!pp) return -ENOMEM; bridge = of_create_pci_host_bridge(&pdev->dev, &myhostbridge_ops, pp); if (!bridge) { err = -EINVAL; goto bridge_init_fail; } err = myhostbridge_setup(bridge->bus); if (err) goto bridge_init_fail; /* We always enable PCI domains and we keep domain 0 backward * compatible in /proc for video cards */ pci_add_flags(PCI_ENABLE_PROC_DOMAINS | PCI_COMPAT_DOMAIN_0); pci_add_flags(PCI_REASSIGN_ALL_BUS | PCI_REASSIGN_ALL_RSRC); lastbus = pci_scan_child_bus(bridge->bus); pci_bus_update_busn_res_end(bridge->bus, lastbus); pci_assign_unassigned_bus_resources(bridge->bus); pci_bus_add_devices(bridge->bus); return 0; bridge_init_fail: kfree(pp); return err; } [1] http://thread.gmane.org/gmane.linux.kernel.pci/25946 Best regards, Liviu Liviu Dudau (5): pci: Introduce pci_register_io_range() helper function. pci: OF: Fix the conversion of IO ranges into IO resources. pci: Create pci_host_bridge before its associated bus in pci_create_root_bus. pci: Introduce a domain number for pci_host_bridge. pci: Add support for creating a generic host_bridge from device tree drivers/of/address.c | 39 +++++++++++++ drivers/pci/host-bridge.c | 134 +++++++++++++++++++++++++++++++++++++++++++++ drivers/pci/probe.c | 66 ++++++++++++++-------- include/linux/of_address.h | 14 +---- include/linux/pci.h | 17 ++++++ 5 files changed, 236 insertions(+), 34 deletions(-) -- 1.9.0

10 years, 4 months

queue boot: 41 pass, 0 fail (v3.13.5-78-g29d766a)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: queue Git describe: v3.13.5-78-g29d766a Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.1 sec omap2plus_defconfig ------------------- legacy,3730xm PASS: 0 min 52.3 sec am335x-boneblack PASS: 0 min 25.4 sec omap3-beagle-xm PASS: 0 min 59.4 sec legacy,3530beagle PASS: 0 min 30.9 sec omap4-panda PASS: 1 min 6.4 sec omap3-tobi PASS: 0 min 22.2 sec am335x-bone PASS: 0 min 27.1 sec omap4-panda-es PASS: 1 min 2.4 sec legacy,3730storm PASS: 0 min 20.2 sec legacy,3530overo PASS: 0 min 21.0 sec multi_lpae_defconfig -------------------- sun7i-a20-cubieboard2 PASS: 0 min 13.5 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.1 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.3 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.2 sec imx6q-wandboard PASS: 0 min 16.8 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 11.4 sec sun4i-a10-cubieboard PASS: 0 min 12.2 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 58.9 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 30.1 sec multi_v7_defconfig ------------------ ste-snowball PASS: 0 min 29.4 sec tegra30-beaver PASS: 0 min 14.3 sec am335x-boneblack PASS: 0 min 22.2 sec omap3-beagle-xm PASS: 1 min 4.2 sec sun7i-a20-cubieboard2 PASS: 0 min 13.4 sec armada-370-mirabox PASS: 0 min 20.6 sec omap4-panda PASS: 1 min 5.5 sec armada-xp-openblocks-ax3-4 PASS: 0 min 22.8 sec sun4i-a10-cubieboard PASS: 0 min 17.8 sec bcm28155-ap PASS: 1 min 4.1 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.0 sec omap3-tobi PASS: 0 min 20.6 sec am335x-bone PASS: 0 min 23.9 sec imx6q-wandboard PASS: 0 min 16.2 sec omap4-panda-es PASS: 1 min 3.6 sec imx6dl-wandboard,wand-dual PASS: 0 min 17.3 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 27.9 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.3 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.4 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 21.9 sec armada-370-mirabox PASS: 0 min 19.9 sec

10 years, 4 months

mainline boot: 45 pass, 2 fail (v3.14-rc4-120-g8427def)

by Kevin's boot bot

Automated DT boot report for various ARM defconfigs. Tree/Branch: mainline Git describe: v3.14-rc4-120-g8427def Failed boot tests (console logs at the end) =========================================== legacy,3730xm: FAIL: omap2plus_defconfig omap3-beagle-xm: FAIL: omap2plus_defconfig Full Report =========== da8xx_omapl_defconfig --------------------- da850-evm PASS: 0 min 15.2 sec omap2plus_defconfig ------------------- legacy,3730xm FAIL: 0 min 43.0 sec am335x-boneblack PASS: 0 min 25.6 sec omap3-beagle-xm FAIL: 0 min 31.4 sec legacy,3530beagle PASS: 0 min 35.9 sec omap4-panda PASS: 1 min 13.0 sec omap3-overo-tobi PASS: 0 min 22.9 sec am335x-bone PASS: 0 min 27.3 sec omap3-overo-storm-tobi PASS: 0 min 25.6 sec omap5-uevm PASS: 1 min 2.6 sec omap4-panda-es PASS: 1 min 13.0 sec legacy,3730storm PASS: 0 min 23.8 sec legacy,3530overo PASS: 0 min 21.0 sec multi_lpae_defconfig -------------------- omap5-uevm PASS: 1 min 43.6 sec sun7i-a20-cubieboard2 PASS: 0 min 14.0 sec tegra_defconfig --------------- tegra30-beaver PASS: 0 min 17.0 sec imx_v6_v7_defconfig ------------------- imx6dl-wandboard,wand-dual PASS: 0 min 18.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 18.3 sec imx6q-wandboard PASS: 0 min 17.0 sec msm_defconfig ------------- qcom-apq8074-dragonboard PASS: 1 min 9.4 sec bcm_defconfig ------------- bcm28155-ap PASS: 0 min 53.6 sec sunxi_defconfig --------------- sun7i-a20-cubieboard2 PASS: 0 min 12.7 sec sun4i-a10-cubieboard PASS: 0 min 16.9 sec exynos_defconfig ---------------- exynos5250-arndale PASS: 0 min 30.1 sec multi_v7_defconfig ------------------ ste-snowball PASS: 1 min 20.5 sec tegra30-beaver PASS: 0 min 16.9 sec am335x-boneblack PASS: 0 min 23.2 sec omap3-beagle-xm PASS: 0 min 51.3 sec sun7i-a20-cubieboard2 PASS: 0 min 14.2 sec armada-370-mirabox PASS: 0 min 22.3 sec omap4-panda PASS: 1 min 2.5 sec armada-xp-openblocks-ax3-4 PASS: 0 min 24.9 sec sun4i-a10-cubieboard PASS: 0 min 18.5 sec bcm28155-ap PASS: 0 min 59.1 sec omap3-overo-tobi PASS: 0 min 21.4 sec imx6dl-wandboard,wand-solo PASS: 0 min 17.6 sec am335x-bone PASS: 0 min 25.9 sec omap3-overo-storm-tobi PASS: 0 min 24.0 sec omap5-uevm PASS: 1 min 49.4 sec imx6q-wandboard PASS: 0 min 17.3 sec omap4-panda-es PASS: 0 min 49.7 sec imx6dl-wandboard,wand-dual PASS: 0 min 18.1 sec u8500_defconfig --------------- ste-snowball PASS: 0 min 30.9 sec sama5_defconfig --------------- sama5d35ek PASS: 0 min 17.1 sec davinci_all_defconfig --------------------- legacy,dm365evm PASS: 0 min 16.6 sec mvebu_defconfig --------------- armada-xp-openblocks-ax3-4 PASS: 0 min 22.2 sec armada-370-mirabox PASS: 0 min 20.3 sec Console logs for failures ========================= omap2plus_defconfig ------------------- legacy,3730xm: FAIL: last 80 lines of boot log: ----------------------------------------------- U-Boot 2013.04 (Jan 17 2014 - 10:48:29) arm-linux-gnueabi-gcc (Ubuntu/Linaro 4.7.3-1ubuntu1) 4.7.3 GNU ld (GNU Binutils for Ubuntu) 2.23.2 OMAP3 beagleboard.org #setenv usbethaddr 2a:45:34:6d:b4:5d setenv usbethaddr 2a:45:34:6d:b4:5d OMAP3 beagleboard.org # setenv preboot "dcache off; usb start" # For USB net setenv preboot "dcache off; usb start" # For USB net OMAP3 beagleboard.org # setenv bootargs console=ttyO2,115200n8 earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 setenv bootargs console=ttyO2,115200n8 earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 OMAP3 beagleboard.org #setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' setenv netargs 'setenv bootargs ${bootargs} ip=${ipaddr}:${serverip}:${gatewayip}:${netmask}::::192.168.1.254:none' OMAP3 beagleboard.org # if test -n ${initenv}; then run initenv; fi if test -n ${initenv}; then run initenv; fi OMAP3 beagleboard.org # if test -n ${preboot}; then run preboot; fi if test -n ${preboot}; then run preboot; fi (Re)start USB... USB0: USB EHCI 1.00 scanning bus 0 for devices... 3 USB Device(s) found scanning usb for storage devices... 0 Storage Device(s) found scanning usb for ethernet devices... 1 Ethernet Device(s) found OMAP3 beagleboard.org #setenv autoload no; setenv autoboot no setenv autoload no; setenv autoboot no OMAP3 beagleboard.org # dhcp dhcp ERROR: Need valid 'usbnet_devaddr' to be set at ether.c:2369/usb_eth_init() Waiting for Ethernet connection... done. BOOTP broadcast 1 EHCI timed out on TD - token=0x8008d80 BOOTP broadcast 2 DHCP client bound to address 192.168.1.190 OMAP3 beagleboard.org #setenv serverip 192.168.1.2 setenv serverip 192.168.1.2 OMAP3 beagleboard.org # if test -n ${netargs}; then run netargs; fi if test -n ${netargs}; then run netargs; fi OMAP3 beagleboard.org # tftp 0x80200000 192.168.1.2:tmp/3730xm-y26vuV/zImage tftp 0x80200000 192.168.1.2:tmp/3730xm-y26vuV/zImage Waiting for Ethernet connection... done. Using sms0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.190 Filename 'tmp/3730xm-y26vuV/zImage'. Load address: 0x80200000 Loading: *T ################################################################# ################################################################# ################################################################# ################################################################# ################################ 504.9 KiB/s done Bytes transferred = 4277400 (414498 hex) OMAP3 beagleboard.org # tftp 0x81000000 192.168.1.2:buildroot.cpio.gz.uboot tftp 0x81000000 192.168.1.2:buildroot.cpio.gz.uboot Waiting for Ethernet connection... done. Using sms0 device TFTP from server 192.168.1.2; our IP address is 192.168.1.190 Filename 'buildroot.cpio.gz.uboot'. Load address: 0x81000000 Loading: *T ############################################ 113.3 KiB/s done Bytes transferred = 642602 (9ce2a hex) OMAP3 beagleboard.org # printenv bootargs printenv bootargs bootargs=console=ttyO2,115200n8 earlyprintk rw root=/dev/mmcblk0p2 rootwait rootfstype=ext4 ip=192.168.1.190:192.168.1.2:192.168.1.254:255.255.255.0::::192.168.1.254:none OMAP3 beagleboard.org # bootz 0x80200000 0x81000000 bootz 0x80200000 0x81000000 ## Loading init Ramdisk from Legacy Image at 81000000 ... Image Name: Image Type: ARM Linux RAMDisk Image (uncompressed) Data Size: 642538 Bytes = 627.5 KiB Load Address: 00000000 Entry Point: 00000000 Starting kernel ... ~$off # PYBOOT: Exception: kernel: ERROR: did not start booting. # PYBOOT: Time: 43.02 seconds. # PYBOOT: Result: FAIL omap3-beagle-xm: FAIL: last 80 lines of boot log: ------------------------------------------------- Connected to 3730xm console [channel connected] (~$quit to exit) (user:khilman) is already connected ~$hardreset Command(3730xm console)> hardreset (user:khilman) Reboot 3730xm Reboot: 3730xm ; phidget 0 2 : off, sleep, on 0 OMAP3 beagleboard.org # ~$off # PYBOOT: Exception: ERROR: Could not break into autoboot. # PYBOOT: Time: 31.38 seconds. # PYBOOT: Result: FAIL

10 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

linaro-kernel March 2014