- PGP Signed by an unknown key
On Thu, May 01, 2014 at 03:24:18PM +0100, Jon Medhurst (Tixy) wrote:
I personally don't care one way or the other, I'm just a piggy-in-the-middle patch monkey chimera who'd wish people would make
up
their minds what they want :-)
So if Mark H, Mark B, and Robin can come to a consensus on what the task packing config should be, then tell me...
I have no real opinion on what the best configuration is, I'm assuming this is intended as a per system tunable and that the main point of the change was to demonstrate best practice for doing the tuning better.
My problem here is that this patch doesn't just revert the change that turns off task packing, it also reverts the config that most will probably have been building with...
hmp_full_threshold now changes from:
unsigned int hmp_full_threshold = 650; /* 80% of the 800Mhz freq * NICE_0_LOAD */
To:
unsigned int hmp_full_threshold = (NICE_0_LOAD * 9) / 8;
As I suspect most will be building with TC2 enabled.
Yes it is a tunable, and yes it can be set for a platform.. but it is just more messing about when this patch finally gets reverted.
We have already reverted the latest patch, but what would be cleaner is to revert the first patch and then add a second patch to remove the other bit of config and just set the value to the one that is most likely the most common default?
Mark