On 02/26/2014 12:22 AM, Srikar Dronamraju wrote:
-/**
- get_sd_load_idx - Obtain the load index for a given sched domain.
- @sd: The sched_domain whose load_idx is to be obtained.
- @idle: The idle status of the CPU for whose sd load_idx is obtained.
- Return: The load index.
- */
-static inline int get_sd_load_idx(struct sched_domain *sd,
enum cpu_idle_type idle)-{
- int load_idx;
- switch (idle) {
- case CPU_NOT_IDLE:
load_idx = sd->busy_idx;break;- case CPU_NEWLY_IDLE:
load_idx = sd->newidle_idx;break;- default:
load_idx = sd->idle_idx;break;- }
- return load_idx;
-}
Since the last caller to get_sd_load_idx(), does it make sense to remove the function definition for get_sd_load_idx() in the previous patch itself?
yes. it's reasonable.
Or
@@ -5903,13 +5868,11 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd struct sched_domain *child = env->sd->child; struct sched_group *sg = env->sd->groups; struct sg_lb_stats tmp_sgs;
- int load_idx, prefer_sibling = 0;
- int prefer_sibling = 0;
if (child && child->flags & SD_PREFER_SIBLING) prefer_sibling = 1;
- load_idx = 0;
- do { struct sg_lb_stats *sgs = &tmp_sgs; int local_group;
The single line change in the previous patch gets removed here so why not club them.
Uh, the first patch want to just show the load_idx connection in current logical.
Yes, we can club them, but this connection will be flooded in code.