Re: [PATCH 01/17] PM / OPP: get/put regulators from OPP core

On 12/22, Viresh Kumar wrote:

diff --git a/drivers/base/power/opp/opp.h b/drivers/base/power/opp/opp.h index 690638ef36ee..c4a03ad34100 100644 --- a/drivers/base/power/opp/opp.h +++ b/drivers/base/power/opp/opp.h @@ -18,6 +18,7 @@ #include <linux/kernel.h> #include <linux/list.h> #include <linux/limits.h> +#include <linux/regulator/consumer.h>

This include doesn't seem necessary. Forward declare struct regulator instead?

#include <linux/pm_opp.h> #include <linux/rculist.h> #include <linux/rcupdate.h> @@ -132,6 +133,8 @@ struct device_list_opp {

• @supported_hw: Array of version number to support.
• @supported_hw_count: Number of elements in supported_hw array.
• @prop_name: A name to postfix to many DT properties, while parsing them.

• • @regulator: Supply Regulator

Is there a reason we capitalize regulator?