Re: [RFC patch 2/2] ARM: at91: cpuidle: move the driver to drivers/cpuidle directory

On 04/15/2013 04:20 PM, Jean-Christophe PLAGNIOL-VILLARD wrote:

On 15:29 Mon 15 Apr , Daniel Lezcano wrote:

...

We don't have any dependency with the SoC specific code.

Move the driver to the drivers/cpuidle directory.

Add Nicolas Ferre as author of the driver, so it will be in copy of the emails.

Signed-off-by: Daniel Lezcano daniel.lezcano@linaro.org

please use -M when generating the patch

Oh, right. Thanks for reminding me the option.

[ ... ]

...

+#include <linux/module.h> +#include <linux/init.h> +#include <linux/cpuidle.h> +#include <asm/cpuidle.h>

+#define AT91_MAX_STATES 2

+extern void (*at91_standby_ops)(void);

really don't like can we pass it via the pm?

I agree, it is hackish. Can you elaborate when you say "pass it via the pm" ?