On 31-07-15, 13:23, Kirill A. Shutemov wrote:
On Fri, Jul 31, 2015 at 11:41:09AM +0200, Vlastimil Babka wrote:
On 07/31/2015 10:38 AM, Viresh Kumar wrote:
Hi,
This cleans up the usage of IS_ERR(_OR_NULL)(), where the callers have added additional unlikely compiler flag to them. It also fixes the definition of IS_ERR_OR_NULL(), to use unlikely for all checks it does.
[+CC Steven Rostedt]
Any idea what the compiler does in the case of "if (likely(IS_ERR(...)))"? There are apparently such cases in the source.
We have two cases in code:
drivers/rtc/rtc-gemini.c: if (likely(IS_ERR(rtc->rtc_dev)))
This one is already fixed in my series (sent a v2 to fix changelog as well)
drivers/staging/lustre/lustre/obdclass/lu_object.c: if (likely(IS_ERR(shadow) && PTR_ERR(shadow) == -ENOENT)) {
And I have sent a patch for this (in reply the your mail).